From nobody Sat Apr 27 20:23:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491007729686120.62320544991371; Fri, 31 Mar 2017 17:48:49 -0700 (PDT) Received: from localhost ([::1]:43392 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7Dj-0005jF-SP for importer@patchew.org; Fri, 31 Mar 2017 20:48:47 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51507) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7Bd-0004QE-OY for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:46:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cu7BZ-0005mL-Ro for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:46:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9774) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cu7BZ-0005m9-G6 for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:46:33 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5CEDB345599; Sat, 1 Apr 2017 00:46:32 +0000 (UTC) Received: from localhost (ovpn-116-5.gru2.redhat.com [10.97.116.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9D9531822F; Sat, 1 Apr 2017 00:46:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5CEDB345599 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=ehabkost@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 5CEDB345599 From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Fri, 31 Mar 2017 21:46:06 -0300 Message-Id: <20170401004624.30886-2-ehabkost@redhat.com> In-Reply-To: <20170401004624.30886-1-ehabkost@redhat.com> References: <20170401004624.30886-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Sat, 01 Apr 2017 00:46:32 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC 01/19] qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , Alexander Graf , Markus Armbruster , Marcel Apfelbaum , Laszlo Ersek Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" cannot_instantiate_with_device_add_yet was introduced by commit 837d37167dc446af8a91189108b363c04609e296 to replace no_user. It was supposed to be a temporary measure. When it was introduced, we had 54 cannot_instantiate_with_device_add_yet=3Dtrue lines in the code. Today (3 years later) this number has not shrinked: we now have 57 cannot_instantiate_with_device_add_yet=3Dtrue lines. I think it is safe to say it is not a temporary measure, and we won't see the flag go away soon. Instead of a long field name that misleads people to believe it is temporary, replace it a shorter and less misleading field: user_creatable. Except for code comments, changes were generated using the following Coccinelle patch: @@ expression DC; @@ ( -DC->cannot_instantiate_with_device_add_yet =3D false; +DC->user_creatable =3D true; | -DC->cannot_instantiate_with_device_add_yet =3D true; +DC->user_creatable =3D false; ) @@ typedef ObjectClass; expression dc; identifier class, data; @@ static void device_class_init(ObjectClass *class, void *data) { ... dc->hotpluggable =3D true; +dc->user_creatable =3D true; ... } @@ @@ struct DeviceClass { ... -bool cannot_instantiate_with_device_add_yet; +bool user_creatable; ... } @@ expression DC; @@ ( -!DC->cannot_instantiate_with_device_add_yet +DC->user_creatable | -DC->cannot_instantiate_with_device_add_yet +!DC->user_creatable ) Cc: Markus Armbruster Cc: Laszlo Ersek Cc: Marcel Apfelbaum Cc: Peter Maydell Cc: Thomas Huth Signed-off-by: Eduardo Habkost Acked-by: Alistair Francis --- include/hw/qdev-core.h | 10 +++++----- include/hw/qdev-properties.h | 4 ++-- hw/acpi/piix4.c | 2 +- hw/arm/spitz.c | 2 +- hw/audio/marvell_88w8618.c | 2 +- hw/audio/pcspk.c | 2 +- hw/core/or-irq.c | 2 +- hw/core/qdev.c | 1 + hw/core/register.c | 2 +- hw/dma/i8257.c | 2 +- hw/dma/sparc32_dma.c | 2 +- hw/gpio/omap_gpio.c | 4 ++-- hw/i2c/omap_i2c.c | 2 +- hw/i2c/smbus_eeprom.c | 2 +- hw/i2c/smbus_ich9.c | 2 +- hw/i386/pc.c | 2 +- hw/input/vmmouse.c | 2 +- hw/intc/apic_common.c | 2 +- hw/intc/etraxfs_pic.c | 2 +- hw/intc/grlib_irqmp.c | 2 +- hw/intc/i8259_common.c | 2 +- hw/intc/nios2_iic.c | 2 +- hw/intc/omap_intc.c | 4 ++-- hw/isa/lpc_ich9.c | 2 +- hw/isa/piix4.c | 2 +- hw/isa/vt82c686.c | 2 +- hw/mips/gt64xxx_pci.c | 2 +- hw/misc/vmport.c | 2 +- hw/net/dp8393x.c | 2 +- hw/net/etraxfs_eth.c | 2 +- hw/net/lance.c | 2 +- hw/pci-bridge/dec.c | 2 +- hw/pci-bridge/pci_expander_bridge.c | 2 +- hw/pci-host/apb.c | 2 +- hw/pci-host/bonito.c | 2 +- hw/pci-host/gpex.c | 2 +- hw/pci-host/grackle.c | 2 +- hw/pci-host/piix.c | 6 +++--- hw/pci-host/ppce500.c | 2 +- hw/pci-host/prep.c | 2 +- hw/pci-host/q35.c | 4 ++-- hw/pci-host/uninorth.c | 8 ++++---- hw/pci-host/versatile.c | 2 +- hw/pci-host/xilinx-pcie.c | 2 +- hw/ppc/ppc4xx_pci.c | 2 +- hw/ppc/spapr_drc.c | 2 +- hw/s390x/s390-pci-bus.c | 2 +- hw/sd/milkymist-memcard.c | 2 +- hw/sd/pl181.c | 2 +- hw/sh4/sh_pci.c | 2 +- hw/timer/i8254_common.c | 2 +- hw/timer/mc146818rtc.c | 2 +- monitor.c | 2 +- qdev-monitor.c | 6 +++--- qom/cpu.c | 2 +- target/i386/cpu.c | 2 +- 56 files changed, 71 insertions(+), 70 deletions(-) diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index b44b476765..bc4e6f0486 100644 --- a/include/hw/qdev-core.h +++ b/include/hw/qdev-core.h @@ -103,16 +103,16 @@ typedef struct DeviceClass { Property *props; =20 /* - * Shall we hide this device model from -device / device_add? + * Can this device be instantiated with -device / device_add? * All devices should support instantiation with device_add, and * this flag should not exist. But we're not there, yet. Some * devices fail to instantiate with cryptic error messages. * Others instantiate, but don't work. Exposing users to such - * behavior would be cruel; this flag serves to protect them. It - * should never be set without a comment explaining why it is set. - * TODO remove once we're there + * behavior would be cruel; clearing this flag will protect them. + * It should never be cleared without a comment explaining why it + * is cleared. */ - bool cannot_instantiate_with_device_add_yet; + bool user_creatable; /* * Does this device model survive object_unref(object_new(TNAME))? * All device models should, and this flag shouldn't exist. Some diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h index 7ac315331a..5c6e13b993 100644 --- a/include/hw/qdev-properties.h +++ b/include/hw/qdev-properties.h @@ -134,12 +134,12 @@ extern PropertyInfo qdev_prop_arraylen; * device_add, so add code like this: * |* Reason: pointer property "NAME-OF-YOUR-PROP" *| * DeviceClass *dc =3D DEVICE_CLASS(class); - * dc->cannot_instantiate_with_device_add_yet =3D true; + * dc->user_creatable =3D false; * * - If the property may safely remain null, document it like this: * |* * * Note: pointer property "interrupt_vector" may remain null, thus - * * no need for dc->cannot_instantiate_with_device_add_yet =3D true; + * * no need for dc->user_creatable =3D false; * *| */ #define DEFINE_PROP_PTR(_n, _s, _f) \ diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c index a553a7e110..f4fd5907b8 100644 --- a/hw/acpi/piix4.c +++ b/hw/acpi/piix4.c @@ -700,7 +700,7 @@ static void piix4_pm_class_init(ObjectClass *klass, voi= d *data) * Reason: part of PIIX4 southbridge, needs to be wired up, * e.g. by mips_malta_init() */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; dc->hotpluggable =3D false; hc->plug =3D piix4_device_plug_cb; hc->unplug_request =3D piix4_device_unplug_request_cb; diff --git a/hw/arm/spitz.c b/hw/arm/spitz.c index fe2d5a764c..324626847c 100644 --- a/hw/arm/spitz.c +++ b/hw/arm/spitz.c @@ -1076,7 +1076,7 @@ static void sl_nand_class_init(ObjectClass *klass, vo= id *data) dc->vmsd =3D &vmstate_sl_nand_info; dc->props =3D sl_nand_properties; /* Reason: init() method uses drive_get() */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo sl_nand_info =3D { diff --git a/hw/audio/marvell_88w8618.c b/hw/audio/marvell_88w8618.c index 511b004287..4f65f8c199 100644 --- a/hw/audio/marvell_88w8618.c +++ b/hw/audio/marvell_88w8618.c @@ -292,7 +292,7 @@ static void mv88w8618_audio_class_init(ObjectClass *kla= ss, void *data) dc->vmsd =3D &mv88w8618_audio_vmsd; dc->props =3D mv88w8618_audio_properties; /* Reason: pointer property "wm8750" */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo mv88w8618_audio_info =3D { diff --git a/hw/audio/pcspk.c b/hw/audio/pcspk.c index 798002277b..9b99358d87 100644 --- a/hw/audio/pcspk.c +++ b/hw/audio/pcspk.c @@ -223,7 +223,7 @@ static void pcspk_class_initfn(ObjectClass *klass, void= *data) dc->vmsd =3D &vmstate_spk; dc->props =3D pcspk_properties; /* Reason: realize sets global pcspk_state */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo pcspk_info =3D { diff --git a/hw/core/or-irq.c b/hw/core/or-irq.c index 1485d5b285..f9d76c4641 100644 --- a/hw/core/or-irq.c +++ b/hw/core/or-irq.c @@ -91,7 +91,7 @@ static void or_irq_class_init(ObjectClass *klass, void *d= ata) dc->vmsd =3D &vmstate_or_irq; =20 /* Reason: Needs to be wired up to work, e.g. see stm32f205_soc.c */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo or_irq_type_info =3D { diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 1e7fb33246..4132a8bee3 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -1159,6 +1159,7 @@ static void device_class_init(ObjectClass *class, voi= d *data) * should override it in their class_init() */ dc->hotpluggable =3D true; + dc->user_creatable =3D true; } =20 void device_reset(DeviceState *dev) diff --git a/hw/core/register.c b/hw/core/register.c index dc335a79a9..da38ef3a54 100644 --- a/hw/core/register.c +++ b/hw/core/register.c @@ -288,7 +288,7 @@ static void register_class_init(ObjectClass *oc, void *= data) DeviceClass *dc =3D DEVICE_CLASS(oc); =20 /* Reason: needs to be wired up to work */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo register_info =3D { diff --git a/hw/dma/i8257.c b/hw/dma/i8257.c index 8bd82e8bc8..bd23e893bf 100644 --- a/hw/dma/i8257.c +++ b/hw/dma/i8257.c @@ -601,7 +601,7 @@ static void i8257_class_init(ObjectClass *klass, void *= data) idc->schedule =3D i8257_dma_schedule; idc->register_channel =3D i8257_dma_register_channel; /* Reason: needs to be wired up by isa_bus_dma() to work */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo i8257_info =3D { diff --git a/hw/dma/sparc32_dma.c b/hw/dma/sparc32_dma.c index 9d545e412e..9c6bdc6295 100644 --- a/hw/dma/sparc32_dma.c +++ b/hw/dma/sparc32_dma.c @@ -305,7 +305,7 @@ static void sparc32_dma_class_init(ObjectClass *klass, = void *data) dc->vmsd =3D &vmstate_dma; dc->props =3D sparc32_dma_properties; /* Reason: pointer property "iommu_opaque" */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo sparc32_dma_info =3D { diff --git a/hw/gpio/omap_gpio.c b/hw/gpio/omap_gpio.c index dabef4a119..1df394eb12 100644 --- a/hw/gpio/omap_gpio.c +++ b/hw/gpio/omap_gpio.c @@ -773,7 +773,7 @@ static void omap_gpio_class_init(ObjectClass *klass, vo= id *data) dc->reset =3D omap_gpif_reset; dc->props =3D omap_gpio_properties; /* Reason: pointer property "clk" */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo omap_gpio_info =3D { @@ -804,7 +804,7 @@ static void omap2_gpio_class_init(ObjectClass *klass, v= oid *data) dc->reset =3D omap2_gpif_reset; dc->props =3D omap2_gpio_properties; /* Reason: pointer properties "iclk", "fclk0", ..., "fclk5" */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo omap2_gpio_info =3D { diff --git a/hw/i2c/omap_i2c.c b/hw/i2c/omap_i2c.c index f7c92ea00c..f6e80bee25 100644 --- a/hw/i2c/omap_i2c.c +++ b/hw/i2c/omap_i2c.c @@ -491,7 +491,7 @@ static void omap_i2c_class_init(ObjectClass *klass, voi= d *data) dc->props =3D omap_i2c_properties; dc->reset =3D omap_i2c_reset; /* Reason: pointer properties "iclk", "fclk" */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; dc->realize =3D omap_i2c_realize; } =20 diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c index 5b7bd891bc..b13ec0fe7a 100644 --- a/hw/i2c/smbus_eeprom.c +++ b/hw/i2c/smbus_eeprom.c @@ -123,7 +123,7 @@ static void smbus_eeprom_class_initfn(ObjectClass *klas= s, void *data) sc->read_data =3D eeprom_read_data; dc->props =3D smbus_eeprom_properties; /* Reason: pointer property "data" */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo smbus_eeprom_info =3D { diff --git a/hw/i2c/smbus_ich9.c b/hw/i2c/smbus_ich9.c index 48fab22625..ea51e09186 100644 --- a/hw/i2c/smbus_ich9.c +++ b/hw/i2c/smbus_ich9.c @@ -103,7 +103,7 @@ static void ich9_smb_class_init(ObjectClass *klass, voi= d *data) * Reason: part of ICH9 southbridge, needs to be wired up by * pc_q35_init() */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 I2CBus *ich9_smb_init(PCIBus *bus, int devfn, uint32_t smb_io_base) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index d24388e05f..610050eb4f 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -597,7 +597,7 @@ static void port92_class_initfn(ObjectClass *klass, voi= d *data) * wiring: its A20 output line needs to be wired up by * port92_init(). */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo port92_info =3D { diff --git a/hw/input/vmmouse.c b/hw/input/vmmouse.c index 6d15a887c6..4747da9a8d 100644 --- a/hw/input/vmmouse.c +++ b/hw/input/vmmouse.c @@ -286,7 +286,7 @@ static void vmmouse_class_initfn(ObjectClass *klass, vo= id *data) dc->vmsd =3D &vmstate_vmmouse; dc->props =3D vmmouse_properties; /* Reason: pointer property "ps2_mouse" */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo vmmouse_info =3D { diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c index c3829e31b5..1ef56f8d10 100644 --- a/hw/intc/apic_common.c +++ b/hw/intc/apic_common.c @@ -501,7 +501,7 @@ static void apic_common_class_init(ObjectClass *klass, = void *data) * Reason: APIC and CPU need to be wired up by * x86_cpu_apic_create() */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo apic_common_type =3D { diff --git a/hw/intc/etraxfs_pic.c b/hw/intc/etraxfs_pic.c index 64a6f4b4ba..1bfde2f09e 100644 --- a/hw/intc/etraxfs_pic.c +++ b/hw/intc/etraxfs_pic.c @@ -173,7 +173,7 @@ static void etraxfs_pic_class_init(ObjectClass *klass, = void *data) dc->props =3D etraxfs_pic_properties; /* * Note: pointer property "interrupt_vector" may remain null, thus - * no need for dc->cannot_instantiate_with_device_add_yet =3D true; + * no need for dc->user_creatable =3D false; */ } =20 diff --git a/hw/intc/grlib_irqmp.c b/hw/intc/grlib_irqmp.c index ac7e63f38b..94659ee256 100644 --- a/hw/intc/grlib_irqmp.c +++ b/hw/intc/grlib_irqmp.c @@ -360,7 +360,7 @@ static void grlib_irqmp_class_init(ObjectClass *klass, = void *data) dc->reset =3D grlib_irqmp_reset; dc->props =3D grlib_irqmp_properties; /* Reason: pointer properties "set_pil_in", "set_pil_in_opaque" */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; dc->realize =3D grlib_irqmp_realize; } =20 diff --git a/hw/intc/i8259_common.c b/hw/intc/i8259_common.c index d9a5e8b217..c2fd563b5b 100644 --- a/hw/intc/i8259_common.c +++ b/hw/intc/i8259_common.c @@ -144,7 +144,7 @@ static void pic_common_class_init(ObjectClass *klass, v= oid *data) * wiring of the slave to the master is hard-coded in device model * code. */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo pic_common_type =3D { diff --git a/hw/intc/nios2_iic.c b/hw/intc/nios2_iic.c index 190b6fdbf3..016426f964 100644 --- a/hw/intc/nios2_iic.c +++ b/hw/intc/nios2_iic.c @@ -80,7 +80,7 @@ static void altera_iic_class_init(ObjectClass *klass, voi= d *data) DeviceClass *dc =3D DEVICE_CLASS(klass); =20 /* Reason: needs to be wired up, e.g. by nios2_10m50_ghrd_init() */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; dc->realize =3D altera_iic_realize; } =20 diff --git a/hw/intc/omap_intc.c b/hw/intc/omap_intc.c index 877be67971..ccdda89dab 100644 --- a/hw/intc/omap_intc.c +++ b/hw/intc/omap_intc.c @@ -401,7 +401,7 @@ static void omap_intc_class_init(ObjectClass *klass, vo= id *data) dc->reset =3D omap_inth_reset; dc->props =3D omap_intc_properties; /* Reason: pointer property "clk" */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; dc->realize =3D omap_intc_realize; } =20 @@ -656,7 +656,7 @@ static void omap2_intc_class_init(ObjectClass *klass, v= oid *data) dc->reset =3D omap_inth_reset; dc->props =3D omap2_intc_properties; /* Reason: pointer property "iclk", "fclk" */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; dc->realize =3D omap2_intc_realize; } =20 diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c index 59930dd9d0..cdc854a822 100644 --- a/hw/isa/lpc_ich9.c +++ b/hw/isa/lpc_ich9.c @@ -810,7 +810,7 @@ static void ich9_lpc_class_init(ObjectClass *klass, voi= d *data) * Reason: part of ICH9 southbridge, needs to be wired up by * pc_q35_init() */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; hc->plug =3D ich9_pm_device_plug_cb; hc->unplug_request =3D ich9_pm_device_unplug_request_cb; hc->unplug =3D ich9_pm_device_unplug_cb; diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c index 5500fcc4d6..f811eba59d 100644 --- a/hw/isa/piix4.c +++ b/hw/isa/piix4.c @@ -123,7 +123,7 @@ static void piix4_class_init(ObjectClass *klass, void *= data) * Reason: part of PIIX4 southbridge, needs to be wired up, * e.g. by mips_malta_init() */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; dc->hotpluggable =3D false; } =20 diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c index 41d5254f8e..50dc83df77 100644 --- a/hw/isa/vt82c686.c +++ b/hw/isa/vt82c686.c @@ -494,7 +494,7 @@ static void via_class_init(ObjectClass *klass, void *da= ta) * Reason: part of VIA VT82C686 southbridge, needs to be wired up, * e.g. by mips_fulong2e_init() */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo via_info =3D { diff --git a/hw/mips/gt64xxx_pci.c b/hw/mips/gt64xxx_pci.c index 4811843ab6..e8b2eef688 100644 --- a/hw/mips/gt64xxx_pci.c +++ b/hw/mips/gt64xxx_pci.c @@ -1224,7 +1224,7 @@ static void gt64120_pci_class_init(ObjectClass *klass= , void *data) * PCI-facing part of the host bridge, not usable without the * host-facing part, which can't be device_add'ed, yet. */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo gt64120_pci_info =3D { diff --git a/hw/misc/vmport.c b/hw/misc/vmport.c index be40930b8b..165500223f 100644 --- a/hw/misc/vmport.c +++ b/hw/misc/vmport.c @@ -163,7 +163,7 @@ static void vmport_class_initfn(ObjectClass *klass, voi= d *data) =20 dc->realize =3D vmport_realizefn; /* Reason: realize sets global port_state */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo vmport_info =3D { diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c index efa33ad40a..b53fcaa8bc 100644 --- a/hw/net/dp8393x.c +++ b/hw/net/dp8393x.c @@ -934,7 +934,7 @@ static void dp8393x_class_init(ObjectClass *klass, void= *data) dc->vmsd =3D &vmstate_dp8393x; dc->props =3D dp8393x_properties; /* Reason: dma_mr property can't be set */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo dp8393x_info =3D { diff --git a/hw/net/etraxfs_eth.c b/hw/net/etraxfs_eth.c index efaa49faae..013c8d0a41 100644 --- a/hw/net/etraxfs_eth.c +++ b/hw/net/etraxfs_eth.c @@ -630,7 +630,7 @@ static void etraxfs_eth_class_init(ObjectClass *klass, = void *data) k->init =3D fs_eth_init; dc->props =3D etraxfs_eth_properties; /* Reason: pointer properties "dma_out", "dma_in" */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo etraxfs_eth_info =3D { diff --git a/hw/net/lance.c b/hw/net/lance.c index 573d724bcf..92b0c68274 100644 --- a/hw/net/lance.c +++ b/hw/net/lance.c @@ -165,7 +165,7 @@ static void lance_class_init(ObjectClass *klass, void *= data) dc->vmsd =3D &vmstate_lance; dc->props =3D lance_properties; /* Reason: pointer property "dma" */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo lance_info =3D { diff --git a/hw/pci-bridge/dec.c b/hw/pci-bridge/dec.c index 840c96198a..cca93620ac 100644 --- a/hw/pci-bridge/dec.c +++ b/hw/pci-bridge/dec.c @@ -128,7 +128,7 @@ static void dec_21154_pci_host_class_init(ObjectClass *= klass, void *data) * PCI-facing part of the host bridge, not usable without the * host-facing part, which can't be device_add'ed, yet. */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo dec_21154_pci_host_info =3D { diff --git a/hw/pci-bridge/pci_expander_bridge.c b/hw/pci-bridge/pci_expand= er_bridge.c index 6ac187fa32..ff59abf208 100644 --- a/hw/pci-bridge/pci_expander_bridge.c +++ b/hw/pci-bridge/pci_expander_bridge.c @@ -150,7 +150,7 @@ static void pxb_host_class_init(ObjectClass *class, voi= d *data) =20 dc->fw_name =3D "pci"; /* Reason: Internal part of the pxb/pxb-pcie device, not usable by its= elf */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; sbc->explicit_ofw_unit_address =3D pxb_host_ofw_unit_address; hc->root_bus_path =3D pxb_host_root_bus_path; } diff --git a/hw/pci-host/apb.c b/hw/pci-host/apb.c index 653e711121..edc88f4c65 100644 --- a/hw/pci-host/apb.c +++ b/hw/pci-host/apb.c @@ -810,7 +810,7 @@ static void pbm_pci_host_class_init(ObjectClass *klass,= void *data) * PCI-facing part of the host bridge, not usable without the * host-facing part, which can't be device_add'ed, yet. */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo pbm_pci_host_info =3D { diff --git a/hw/pci-host/bonito.c b/hw/pci-host/bonito.c index 1999ece590..85a3bb0dd2 100644 --- a/hw/pci-host/bonito.c +++ b/hw/pci-host/bonito.c @@ -825,7 +825,7 @@ static void bonito_class_init(ObjectClass *klass, void = *data) * PCI-facing part of the host bridge, not usable without the * host-facing part, which can't be device_add'ed, yet. */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo bonito_info =3D { diff --git a/hw/pci-host/gpex.c b/hw/pci-host/gpex.c index 66055ee5cc..e2629ce70d 100644 --- a/hw/pci-host/gpex.c +++ b/hw/pci-host/gpex.c @@ -136,7 +136,7 @@ static void gpex_root_class_init(ObjectClass *klass, vo= id *data) * PCI-facing part of the host bridge, not usable without the * host-facing part, which can't be device_add'ed, yet. */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo gpex_root_info =3D { diff --git a/hw/pci-host/grackle.c b/hw/pci-host/grackle.c index 2c8acdaaca..2e281f6155 100644 --- a/hw/pci-host/grackle.c +++ b/hw/pci-host/grackle.c @@ -134,7 +134,7 @@ static void grackle_pci_class_init(ObjectClass *klass, = void *data) * PCI-facing part of the host bridge, not usable without the * host-facing part, which can't be device_add'ed, yet. */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo grackle_pci_info =3D { diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index f9218aa952..81f3a9e211 100644 --- a/hw/pci-host/piix.c +++ b/hw/pci-host/piix.c @@ -691,7 +691,7 @@ static void pci_piix3_class_init(ObjectClass *klass, vo= id *data) * Reason: part of PIIX3 southbridge, needs to be wired up by * pc_piix.c's pc_init1() */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo piix3_pci_type_info =3D { @@ -745,7 +745,7 @@ static void i440fx_class_init(ObjectClass *klass, void = *data) * PCI-facing part of the host bridge, not usable without the * host-facing part, which can't be device_add'ed, yet. */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; dc->hotpluggable =3D false; } =20 @@ -874,7 +874,7 @@ static void i440fx_pcihost_class_init(ObjectClass *klas= s, void *data) dc->fw_name =3D "pci"; dc->props =3D i440fx_props; /* Reason: needs to be wired up by pc_init1 */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo i440fx_pcihost_info =3D { diff --git a/hw/pci-host/ppce500.c b/hw/pci-host/ppce500.c index e502bc0505..becc0eeb76 100644 --- a/hw/pci-host/ppce500.c +++ b/hw/pci-host/ppce500.c @@ -508,7 +508,7 @@ static void e500_host_bridge_class_init(ObjectClass *kl= ass, void *data) * PCI-facing part of the host bridge, not usable without the * host-facing part, which can't be device_add'ed, yet. */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo e500_host_bridge_info =3D { diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c index 260a119a9e..900a6edfcf 100644 --- a/hw/pci-host/prep.c +++ b/hw/pci-host/prep.c @@ -364,7 +364,7 @@ static void raven_class_init(ObjectClass *klass, void *= data) * Reason: PCI-facing part of the host bridge, not usable without * the host-facing part, which can't be device_add'ed, yet. */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo raven_info =3D { diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c index 344f77b10c..cd5c49616e 100644 --- a/hw/pci-host/q35.c +++ b/hw/pci-host/q35.c @@ -156,7 +156,7 @@ static void q35_host_class_init(ObjectClass *klass, voi= d *data) dc->realize =3D q35_host_realize; dc->props =3D mch_props; /* Reason: needs to be wired up by pc_q35_init */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); dc->fw_name =3D "pci"; } @@ -549,7 +549,7 @@ static void mch_class_init(ObjectClass *klass, void *da= ta) * PCI-facing part of the host bridge, not usable without the * host-facing part, which can't be device_add'ed, yet. */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo mch_info =3D { diff --git a/hw/pci-host/uninorth.c b/hw/pci-host/uninorth.c index df342ac3cb..6cf5e59f86 100644 --- a/hw/pci-host/uninorth.c +++ b/hw/pci-host/uninorth.c @@ -366,7 +366,7 @@ static void unin_main_pci_host_class_init(ObjectClass *= klass, void *data) * PCI-facing part of the host bridge, not usable without the * host-facing part, which can't be device_add'ed, yet. */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo unin_main_pci_host_info =3D { @@ -390,7 +390,7 @@ static void u3_agp_pci_host_class_init(ObjectClass *kla= ss, void *data) * PCI-facing part of the host bridge, not usable without the * host-facing part, which can't be device_add'ed, yet. */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo u3_agp_pci_host_info =3D { @@ -414,7 +414,7 @@ static void unin_agp_pci_host_class_init(ObjectClass *k= lass, void *data) * PCI-facing part of the host bridge, not usable without the * host-facing part, which can't be device_add'ed, yet. */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo unin_agp_pci_host_info =3D { @@ -438,7 +438,7 @@ static void unin_internal_pci_host_class_init(ObjectCla= ss *klass, void *data) * PCI-facing part of the host bridge, not usable without the * host-facing part, which can't be device_add'ed, yet. */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo unin_internal_pci_host_info =3D { diff --git a/hw/pci-host/versatile.c b/hw/pci-host/versatile.c index 467cbb9cb8..cc51fc87a3 100644 --- a/hw/pci-host/versatile.c +++ b/hw/pci-host/versatile.c @@ -479,7 +479,7 @@ static void versatile_pci_host_class_init(ObjectClass *= klass, void *data) * PCI-facing part of the host bridge, not usable without the * host-facing part, which can't be device_add'ed, yet. */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo versatile_pci_host_info =3D { diff --git a/hw/pci-host/xilinx-pcie.c b/hw/pci-host/xilinx-pcie.c index 8b71e2d950..a968cea2af 100644 --- a/hw/pci-host/xilinx-pcie.c +++ b/hw/pci-host/xilinx-pcie.c @@ -309,7 +309,7 @@ static void xilinx_pcie_root_class_init(ObjectClass *kl= ass, void *data) * PCI-facing part of the host bridge, not usable without the * host-facing part, which can't be device_add'ed, yet. */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo xilinx_pcie_root_info =3D { diff --git a/hw/ppc/ppc4xx_pci.c b/hw/ppc/ppc4xx_pci.c index dc19682970..6953f8b9ac 100644 --- a/hw/ppc/ppc4xx_pci.c +++ b/hw/ppc/ppc4xx_pci.c @@ -351,7 +351,7 @@ static void ppc4xx_host_bridge_class_init(ObjectClass *= klass, void *data) * PCI-facing part of the host bridge, not usable without the * host-facing part, which can't be device_add'ed, yet. */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo ppc4xx_host_bridge_info =3D { diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c index a1cdc875b1..9fa5545991 100644 --- a/hw/ppc/spapr_drc.c +++ b/hw/ppc/spapr_drc.c @@ -675,7 +675,7 @@ static void spapr_dr_connector_class_init(ObjectClass *= k, void *data) /* * Reason: it crashes FIXME find and document the real reason */ - dk->cannot_instantiate_with_device_add_yet =3D true; + dk->user_creatable =3D false; } =20 static const TypeInfo spapr_dr_connector_info =3D { diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c index 69b0291e8a..1ec30c45ce 100644 --- a/hw/s390x/s390-pci-bus.c +++ b/hw/s390x/s390-pci-bus.c @@ -867,7 +867,7 @@ static void s390_pcihost_class_init(ObjectClass *klass,= void *data) DeviceClass *dc =3D DEVICE_CLASS(klass); HotplugHandlerClass *hc =3D HOTPLUG_HANDLER_CLASS(klass); =20 - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; dc->reset =3D s390_pcihost_reset; k->init =3D s390_pcihost_init; hc->plug =3D s390_pcihost_hot_plug; diff --git a/hw/sd/milkymist-memcard.c b/hw/sd/milkymist-memcard.c index 1f2f0ed44a..4008c81002 100644 --- a/hw/sd/milkymist-memcard.c +++ b/hw/sd/milkymist-memcard.c @@ -299,7 +299,7 @@ static void milkymist_memcard_class_init(ObjectClass *k= lass, void *data) dc->reset =3D milkymist_memcard_reset; dc->vmsd =3D &vmstate_milkymist_memcard; /* Reason: init() method uses drive_get_next() */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo milkymist_memcard_info =3D { diff --git a/hw/sd/pl181.c b/hw/sd/pl181.c index 82c63a4fb5..55c8098ecd 100644 --- a/hw/sd/pl181.c +++ b/hw/sd/pl181.c @@ -515,7 +515,7 @@ static void pl181_class_init(ObjectClass *klass, void *= data) k->vmsd =3D &vmstate_pl181; k->reset =3D pl181_reset; /* Reason: init() method uses drive_get_next() */ - k->cannot_instantiate_with_device_add_yet =3D true; + k->user_creatable =3D false; k->realize =3D pl181_realize; } =20 diff --git a/hw/sh4/sh_pci.c b/hw/sh4/sh_pci.c index 1747628f3d..38395c082b 100644 --- a/hw/sh4/sh_pci.c +++ b/hw/sh4/sh_pci.c @@ -171,7 +171,7 @@ static void sh_pci_host_class_init(ObjectClass *klass, = void *data) * PCI-facing part of the host bridge, not usable without the * host-facing part, which can't be device_add'ed, yet. */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo sh_pci_host_info =3D { diff --git a/hw/timer/i8254_common.c b/hw/timer/i8254_common.c index e18299a482..976d5200f1 100644 --- a/hw/timer/i8254_common.c +++ b/hw/timer/i8254_common.c @@ -287,7 +287,7 @@ static void pit_common_class_init(ObjectClass *klass, v= oid *data) * wired to the HPET, and because of that, some wiring is always * done by board code. */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo pit_common_type =3D { diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c index 4165450250..93de3e1cc5 100644 --- a/hw/timer/mc146818rtc.c +++ b/hw/timer/mc146818rtc.c @@ -973,7 +973,7 @@ static void rtc_class_initfn(ObjectClass *klass, void *= data) dc->vmsd =3D &vmstate_rtc; dc->props =3D mc146818rtc_properties; /* Reason: needs to be wired up by rtc_init() */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static void rtc_finalize(Object *obj) diff --git a/monitor.c b/monitor.c index be282ecb80..e06edec2bd 100644 --- a/monitor.c +++ b/monitor.c @@ -3156,7 +3156,7 @@ void device_add_completion(ReadLineState *rs, int nb_= args, const char *str) TYPE_DEVICE); name =3D object_class_get_name(OBJECT_CLASS(dc)); =20 - if (!dc->cannot_instantiate_with_device_add_yet + if (dc->user_creatable && !strncmp(name, str, len)) { readline_add_completion(rs, name); } diff --git a/qdev-monitor.c b/qdev-monitor.c index 5f2fcdfc45..e4c180c6bc 100644 --- a/qdev-monitor.c +++ b/qdev-monitor.c @@ -113,7 +113,7 @@ static void qdev_print_devinfo(DeviceClass *dc) if (dc->desc) { error_printf(", desc \"%s\"", dc->desc); } - if (dc->cannot_instantiate_with_device_add_yet) { + if (!dc->user_creatable) { error_printf(", no-user"); } error_printf("\n"); @@ -155,7 +155,7 @@ static void qdev_print_devinfos(bool show_no_user) ? !test_bit(i, dc->categories) : !bitmap_empty(dc->categories, DEVICE_CATEGORY_MAX)) || (!show_no_user - && dc->cannot_instantiate_with_device_add_yet)) { + && !dc->user_creatable)) { continue; } if (!cat_printed) { @@ -240,7 +240,7 @@ static DeviceClass *qdev_get_device_class(const char **= driver, Error **errp) } =20 dc =3D DEVICE_CLASS(oc); - if (dc->cannot_instantiate_with_device_add_yet || + if (!dc->user_creatable || (qdev_hotplug && !dc->hotpluggable)) { error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "driver", "pluggable device type"); diff --git a/qom/cpu.c b/qom/cpu.c index f02e9c0fae..73ae140d7e 100644 --- a/qom/cpu.c +++ b/qom/cpu.c @@ -449,7 +449,7 @@ static void cpu_class_init(ObjectClass *klass, void *da= ta) * Reason: CPUs still need special care by board code: wiring up * IRQs, adding reset handlers, halting non-first CPUs, ... */ - dc->cannot_instantiate_with_device_add_yet =3D true; + dc->user_creatable =3D false; } =20 static const TypeInfo cpu_type_info =3D { diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 13c0985f11..4b3bfb3802 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -4066,7 +4066,7 @@ static void x86_cpu_common_class_init(ObjectClass *oc= , void *data) cc->cpu_exec_enter =3D x86_cpu_exec_enter; cc->cpu_exec_exit =3D x86_cpu_exec_exit; =20 - dc->cannot_instantiate_with_device_add_yet =3D false; + dc->user_creatable =3D true; } =20 static const TypeInfo x86_cpu_type_info =3D { --=20 2.11.0.259.g40922b1 From nobody Sat Apr 27 20:23:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491007721370412.46305413984214; Fri, 31 Mar 2017 17:48:41 -0700 (PDT) Received: from localhost ([::1]:43391 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7Db-0005cl-QK for importer@patchew.org; Fri, 31 Mar 2017 20:48:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51509) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7Be-0004QQ-62 for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:46:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cu7Bd-0005nR-8b for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:46:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37688) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cu7Bd-0005mr-21 for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:46:37 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F27687D0FC; Sat, 1 Apr 2017 00:46:35 +0000 (UTC) Received: from localhost (ovpn-116-5.gru2.redhat.com [10.97.116.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id C6BC177CB2; Sat, 1 Apr 2017 00:46:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com F27687D0FC Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=ehabkost@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com F27687D0FC From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Fri, 31 Mar 2017 21:46:07 -0300 Message-Id: <20170401004624.30886-3-ehabkost@redhat.com> In-Reply-To: <20170401004624.30886-1-ehabkost@redhat.com> References: <20170401004624.30886-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Sat, 01 Apr 2017 00:46:36 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC 02/19] s390: Add FIXME for unexplained user_creatable=false line X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , Frank Blaschka , Christian Borntraeger , Alexander Graf , Markus Armbruster , Cornelia Huck , Marcel Apfelbaum , Laszlo Ersek , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" TYPE_S390_PCI_HOST_BRIDGE has user_creatable=3Dfalse but has no comment explaining why. Add a FIXME to document that. Cc: Frank Blaschka Cc: Cornelia Huck Cc: Christian Borntraeger Cc: Alexander Graf Cc: Richard Henderson Signed-off-by: Eduardo Habkost --- hw/s390x/s390-pci-bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c index 1ec30c45ce..2c3b960bdf 100644 --- a/hw/s390x/s390-pci-bus.c +++ b/hw/s390x/s390-pci-bus.c @@ -867,7 +867,7 @@ static void s390_pcihost_class_init(ObjectClass *klass,= void *data) DeviceClass *dc =3D DEVICE_CLASS(klass); HotplugHandlerClass *hc =3D HOTPLUG_HANDLER_CLASS(klass); =20 - dc->user_creatable =3D false; + dc->user_creatable =3D false; /*FIXME: explain why */ dc->reset =3D s390_pcihost_reset; k->init =3D s390_pcihost_init; hc->plug =3D s390_pcihost_hot_plug; --=20 2.11.0.259.g40922b1 From nobody Sat Apr 27 20:23:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 149100803085034.48643849093196; Fri, 31 Mar 2017 17:53:50 -0700 (PDT) Received: from localhost ([::1]:43423 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7Ia-0001GY-Fl for importer@patchew.org; Fri, 31 Mar 2017 20:53:48 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7C6-0004lW-62 for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cu7C2-0006Bp-Es for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47114) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cu7Bq-0005uO-H4; Fri, 31 Mar 2017 20:46:50 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4734CC065862; Sat, 1 Apr 2017 00:46:48 +0000 (UTC) Received: from localhost (ovpn-116-5.gru2.redhat.com [10.97.116.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 64BE117CFB; Sat, 1 Apr 2017 00:46:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 4734CC065862 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=ehabkost@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 4734CC065862 From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Fri, 31 Mar 2017 21:46:08 -0300 Message-Id: <20170401004624.30886-4-ehabkost@redhat.com> In-Reply-To: <20170401004624.30886-1-ehabkost@redhat.com> References: <20170401004624.30886-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Sat, 01 Apr 2017 00:46:49 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC 03/19] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Michael S. Tsirkin" , Jason Wang , Markus Armbruster , Gerd Hoffmann , "Edgar E. Iglesias" , qemu-block@nongnu.org, Alexander Graf , Shannon Zhao , Marcel Apfelbaum , Richard Henderson , Laszlo Ersek , Thomas Huth , "Gabriel L . Somlo" , Alistair Francis , Beniamino Galvani , Alex Williamson , qemu-arm@nongnu.org, Igor Mammedov , Scott Wood , John Snow , David Gibson , Kevin Wolf , Prasad J Pandit , Max Reitz , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" commit 33cd52b5d7b9adfd009e95f07e6c64dd88ae2a31 unset cannot_instantiate_with_device_add_yet in TYPE_SYSBUS, making all kinds of untested devices available to -device and device_add. The problem with that is: setting has_dynamic_sysbus on a machine-type lets it accept all the 288 sysbus device types we have in QEMU, and most of them were never meant to be used with -device. That's a lot of untested code. Fortunately today we have just a few has_dynamic_sysbus=3D1 machines: virt, pc-q35-*, ppce500, and spapr. virt, ppce500, and spapr have extra checks to ensure just a few device types can be instantiated: * virt supports only TYPE_VFIO_CALXEDA_XGMAC, TYPE_VFIO_AMD_XGBE. * ppce500 supports only TYPE_ETSEC_COMMON. * spapr supports only TYPE_SPAPR_PCI_HOST_BRIDGE. q35 has no code to block unsupported sysbus devices, however, and accepts all device types. Fortunately, only the following 20 device types are compiled into the qemu-system-x86_64 and qemu-system-i386 binaries: * allwinner-ahci * amd-iommu * cfi.pflash01 * esp * fw_cfg_io * fw_cfg_mem * generic-sdhci * hpet * intel-iommu * ioapic * isabus-bridge * kvmclock * kvm-ioapic * kvmvapic * SUNW,fdtwo * sysbus-ahci * sysbus-fdc * sysbus-ohci * unimplemented-device * virtio-mmio Instead of requiring each machine-type with has_dynamic_sysbus=3D1 to implement its own mechanism to block unsupported devices, we can use the user_creatable flag to ensure we won't let the user plug anything that will never work. This patch adds user_creatable=3Dtrue explicitly to the 24 device types mentioned above, to keep compatibility, and set user_creatable=3Dfalse on TYPE_SYS_BUS_DEVICE. Subsequent patches will remove user_creatable=3Dtrue from the devices that were not meant to be creatable using -device despite being currently accepted by q35. Cc: Peter Maydell Cc: Alexander Graf Cc: John Snow Cc: Kevin Wolf Cc: Max Reitz Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: "Michael S. Tsirkin" Cc: Scott Wood Cc: Jason Wang Cc: David Gibson Cc: Gerd Hoffmann Cc: Alex Williamson Cc: qemu-block@nongnu.org Cc: qemu-ppc@nongnu.org Cc: Alistair Francis Cc: Beniamino Galvani Cc: "Edgar E. Iglesias" Cc: Gabriel L. Somlo Cc: Igor Mammedov Cc: Laszlo Ersek Cc: Marcel Apfelbaum Cc: Prasad J Pandit Cc: qemu-arm@nongnu.org Cc: Shannon Zhao Cc: Thomas Huth Signed-off-by: Eduardo Habkost --- hw/block/fdc.c | 10 ++++++++++ hw/block/pflash_cfi01.c | 5 +++++ hw/core/sysbus.c | 11 +++++++++++ hw/i386/amd_iommu.c | 5 +++++ hw/i386/intel_iommu.c | 5 +++++ hw/i386/kvm/clock.c | 5 +++++ hw/i386/kvm/ioapic.c | 5 +++++ hw/i386/kvmvapic.c | 5 +++++ hw/ide/ahci.c | 10 ++++++++++ hw/intc/ioapic.c | 5 +++++ hw/isa/isa-bus.c | 5 +++++ hw/misc/unimp.c | 5 +++++ hw/net/fsl_etsec/etsec.c | 1 + hw/nvram/fw_cfg.c | 10 ++++++++++ hw/ppc/spapr_pci.c | 1 + hw/scsi/esp.c | 5 +++++ hw/sd/sdhci.c | 5 +++++ hw/timer/hpet.c | 5 +++++ hw/usb/hcd-ohci.c | 5 +++++ hw/vfio/amd-xgbe.c | 1 + hw/vfio/calxeda-xgmac.c | 1 + hw/virtio/virtio-mmio.c | 5 +++++ 22 files changed, 115 insertions(+) diff --git a/hw/block/fdc.c b/hw/block/fdc.c index a328693d15..a06c8e358c 100644 --- a/hw/block/fdc.c +++ b/hw/block/fdc.c @@ -2880,6 +2880,11 @@ static void sysbus_fdc_class_init(ObjectClass *klass= , void *data) =20 dc->props =3D sysbus_fdc_properties; set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo sysbus_fdc_info =3D { @@ -2906,6 +2911,11 @@ static void sun4m_fdc_class_init(ObjectClass *klass,= void *data) =20 dc->props =3D sun4m_fdc_properties; set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo sun4m_fdc_info =3D { diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c index 594d4cf6fe..f48dc20035 100644 --- a/hw/block/pflash_cfi01.c +++ b/hw/block/pflash_cfi01.c @@ -927,6 +927,11 @@ static void pflash_cfi01_class_init(ObjectClass *klass= , void *data) dc->props =3D pflash_cfi01_properties; dc->vmsd =3D &vmstate_pflash; set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 =20 diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c index c0f560b289..2d4121dd67 100644 --- a/hw/core/sysbus.c +++ b/hw/core/sysbus.c @@ -326,6 +326,17 @@ static void sysbus_device_class_init(ObjectClass *klas= s, void *data) DeviceClass *k =3D DEVICE_CLASS(klass); k->init =3D sysbus_device_init; k->bus_type =3D TYPE_SYSTEM_BUS; + /* + * device_add plugs devices into suitable bus. For "real" buses, + * that actually connects the device. For sysbus, the connections + * need to be made separately, and device_add can't do that. The + * device would be left unconnected, and will probably not work + * + * However, a few machines and a few devices can handle a few sysbus + * devices, if the device subclass overrides user_creatable=3Dtrue and + * the machine has has_dynamic_sysbus=3D1. + */ + k->user_creatable =3D false; } =20 static const TypeInfo sysbus_device_type_info =3D { diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c index f86a40aa30..1d139f3f6a 100644 --- a/hw/i386/amd_iommu.c +++ b/hw/i386/amd_iommu.c @@ -1186,6 +1186,11 @@ static void amdvi_class_init(ObjectClass *klass, voi= d* data) dc->vmsd =3D &vmstate_amdvi; dc->hotpluggable =3D false; dc_class->realize =3D amdvi_realize; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo amdvi =3D { diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 22d8226e43..5e5125f34b 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -2601,6 +2601,11 @@ static void vtd_class_init(ObjectClass *klass, void = *data) dc->hotpluggable =3D false; x86_class->realize =3D vtd_realize; x86_class->int_remap =3D vtd_int_remap; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo vtd_info =3D { diff --git a/hw/i386/kvm/clock.c b/hw/i386/kvm/clock.c index 13eca374cd..0dbf083b17 100644 --- a/hw/i386/kvm/clock.c +++ b/hw/i386/kvm/clock.c @@ -286,6 +286,11 @@ static void kvmclock_class_init(ObjectClass *klass, vo= id *data) dc->realize =3D kvmclock_realize; dc->vmsd =3D &kvmclock_vmsd; dc->props =3D kvmclock_properties; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo kvmclock_info =3D { diff --git a/hw/i386/kvm/ioapic.c b/hw/i386/kvm/ioapic.c index 98ca480792..cdc35de661 100644 --- a/hw/i386/kvm/ioapic.c +++ b/hw/i386/kvm/ioapic.c @@ -167,6 +167,11 @@ static void kvm_ioapic_class_init(ObjectClass *klass, = void *data) k->post_load =3D kvm_ioapic_put; dc->reset =3D kvm_ioapic_reset; dc->props =3D kvm_ioapic_properties; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo kvm_ioapic_info =3D { diff --git a/hw/i386/kvmvapic.c b/hw/i386/kvmvapic.c index 82a49556af..fbada19253 100644 --- a/hw/i386/kvmvapic.c +++ b/hw/i386/kvmvapic.c @@ -856,6 +856,11 @@ static void vapic_class_init(ObjectClass *klass, void = *data) dc->reset =3D vapic_reset; dc->vmsd =3D &vmstate_vapic; dc->realize =3D vapic_realize; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo vapic_type =3D { diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index f60826d6e0..b1b7780d56 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -1721,6 +1721,11 @@ static void sysbus_ahci_class_init(ObjectClass *klas= s, void *data) dc->props =3D sysbus_ahci_properties; dc->reset =3D sysbus_ahci_reset; set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo sysbus_ahci_info =3D { @@ -1815,6 +1820,11 @@ static void allwinner_ahci_class_init(ObjectClass *k= lass, void *data) DeviceClass *dc =3D DEVICE_CLASS(klass); =20 dc->vmsd =3D &vmstate_allwinner_ahci; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo allwinner_ahci_info =3D { diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c index 37c4386ae3..38af393538 100644 --- a/hw/intc/ioapic.c +++ b/hw/intc/ioapic.c @@ -448,6 +448,11 @@ static void ioapic_class_init(ObjectClass *klass, void= *data) k->post_load =3D ioapic_update_kvm_routes; dc->reset =3D ioapic_reset_common; dc->props =3D ioapic_properties; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo ioapic_info =3D { diff --git a/hw/isa/isa-bus.c b/hw/isa/isa-bus.c index 348e0eab9d..576dbf1763 100644 --- a/hw/isa/isa-bus.c +++ b/hw/isa/isa-bus.c @@ -221,6 +221,11 @@ static void isabus_bridge_class_init(ObjectClass *klas= s, void *data) =20 set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); dc->fw_name =3D "isa"; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo isabus_bridge_info =3D { diff --git a/hw/misc/unimp.c b/hw/misc/unimp.c index bcbb585888..284f096beb 100644 --- a/hw/misc/unimp.c +++ b/hw/misc/unimp.c @@ -90,6 +90,11 @@ static void unimp_class_init(ObjectClass *klass, void *d= ata) =20 dc->realize =3D unimp_realize; dc->props =3D unimp_properties; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo unimp_info =3D { diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c index aa2b0d5a85..b230b88753 100644 --- a/hw/net/fsl_etsec/etsec.c +++ b/hw/net/fsl_etsec/etsec.c @@ -416,6 +416,7 @@ static void etsec_class_init(ObjectClass *klass, void *= data) dc->realize =3D etsec_realize; dc->reset =3D etsec_reset; dc->props =3D etsec_properties; + dc->user_creatable =3D true; } =20 static TypeInfo etsec_info =3D { diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index 316fca9bc1..60bf4fdd2e 100644 --- a/hw/nvram/fw_cfg.c +++ b/hw/nvram/fw_cfg.c @@ -1101,6 +1101,11 @@ static void fw_cfg_io_class_init(ObjectClass *klass,= void *data) =20 dc->realize =3D fw_cfg_io_realize; dc->props =3D fw_cfg_io_properties; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo fw_cfg_io_info =3D { @@ -1167,6 +1172,11 @@ static void fw_cfg_mem_class_init(ObjectClass *klass= , void *data) =20 dc->realize =3D fw_cfg_mem_realize; dc->props =3D fw_cfg_mem_properties; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo fw_cfg_mem_info =3D { diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index 98c52e411f..360eeb2e40 100644 --- a/hw/ppc/spapr_pci.c +++ b/hw/ppc/spapr_pci.c @@ -1990,6 +1990,7 @@ static void spapr_phb_class_init(ObjectClass *klass, = void *data) dc->props =3D spapr_phb_properties; dc->reset =3D spapr_phb_reset; dc->vmsd =3D &vmstate_spapr_pci; + dc->user_creatable =3D true; set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); hp->plug =3D spapr_phb_hot_plug_child; hp->unplug =3D spapr_phb_hot_unplug_child; diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c index eee831efeb..1087b8f14f 100644 --- a/hw/scsi/esp.c +++ b/hw/scsi/esp.c @@ -728,6 +728,11 @@ static void sysbus_esp_class_init(ObjectClass *klass, = void *data) dc->reset =3D sysbus_esp_hard_reset; dc->vmsd =3D &vmstate_sysbus_esp_scsi; set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo sysbus_esp_info =3D { diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index 6d6a791ee9..186555188b 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -1360,6 +1360,11 @@ static void sdhci_sysbus_class_init(ObjectClass *kla= ss, void *data) dc->props =3D sdhci_sysbus_properties; dc->realize =3D sdhci_sysbus_realize; dc->reset =3D sdhci_poweron_reset; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo sdhci_sysbus_info =3D { diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c index a2c18b30c3..b5dab1c8e2 100644 --- a/hw/timer/hpet.c +++ b/hw/timer/hpet.c @@ -771,6 +771,11 @@ static void hpet_device_class_init(ObjectClass *klass,= void *data) dc->reset =3D hpet_reset; dc->vmsd =3D &vmstate_hpet; dc->props =3D hpet_device_properties; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo hpet_device_info =3D { diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index 3ada35e954..0e17fb1e60 100644 --- a/hw/usb/hcd-ohci.c +++ b/hw/usb/hcd-ohci.c @@ -2159,6 +2159,11 @@ static void ohci_sysbus_class_init(ObjectClass *klas= s, void *data) dc->desc =3D "OHCI USB Controller"; dc->props =3D ohci_sysbus_properties; dc->reset =3D usb_ohci_reset_sysbus; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo ohci_sysbus_info =3D { diff --git a/hw/vfio/amd-xgbe.c b/hw/vfio/amd-xgbe.c index 2c60310cf9..f0b6624530 100644 --- a/hw/vfio/amd-xgbe.c +++ b/hw/vfio/amd-xgbe.c @@ -38,6 +38,7 @@ static void vfio_amd_xgbe_class_init(ObjectClass *klass, = void *data) dc->realize =3D amd_xgbe_realize; dc->desc =3D "VFIO AMD XGBE"; dc->vmsd =3D &vfio_platform_amd_xgbe_vmstate; + dc->user_creatable =3D true; } =20 static const TypeInfo vfio_amd_xgbe_dev_info =3D { diff --git a/hw/vfio/calxeda-xgmac.c b/hw/vfio/calxeda-xgmac.c index bb15d588e5..6fae3c5772 100644 --- a/hw/vfio/calxeda-xgmac.c +++ b/hw/vfio/calxeda-xgmac.c @@ -38,6 +38,7 @@ static void vfio_calxeda_xgmac_class_init(ObjectClass *kl= ass, void *data) dc->realize =3D calxeda_xgmac_realize; dc->desc =3D "VFIO Calxeda XGMAC"; dc->vmsd =3D &vfio_platform_calxeda_xgmac_vmstate; + dc->user_creatable =3D true; } =20 static const TypeInfo vfio_calxeda_xgmac_dev_info =3D { diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c index 5807aa87fe..b595512a3d 100644 --- a/hw/virtio/virtio-mmio.c +++ b/hw/virtio/virtio-mmio.c @@ -450,6 +450,11 @@ static void virtio_mmio_class_init(ObjectClass *klass,= void *data) dc->reset =3D virtio_mmio_reset; set_bit(DEVICE_CATEGORY_MISC, dc->categories); dc->props =3D virtio_mmio_properties; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo virtio_mmio_info =3D { --=20 2.11.0.259.g40922b1 From nobody Sat Apr 27 20:23:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491007885214547.5875672569163; Fri, 31 Mar 2017 17:51:25 -0700 (PDT) Received: from localhost ([::1]:43408 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7GF-0007l8-QU for importer@patchew.org; Fri, 31 Mar 2017 20:51:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51591) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7Bx-0004f1-Td for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:46:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cu7Bw-000638-Vi for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:46:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47160) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cu7Bu-0005yE-HR; Fri, 31 Mar 2017 20:46:54 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7AB2AC065864; Sat, 1 Apr 2017 00:46:53 +0000 (UTC) Received: from localhost (ovpn-116-5.gru2.redhat.com [10.97.116.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id B35B96031D; Sat, 1 Apr 2017 00:46:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7AB2AC065864 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=ehabkost@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7AB2AC065864 From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Fri, 31 Mar 2017 21:46:09 -0300 Message-Id: <20170401004624.30886-5-ehabkost@redhat.com> In-Reply-To: <20170401004624.30886-1-ehabkost@redhat.com> References: <20170401004624.30886-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Sat, 01 Apr 2017 00:46:53 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC 04/19] fdc: Remove user_creatable flag from sysbus-fdc & SUNW, fdtwo X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , Thomas Huth , qemu-block@nongnu.org, John Snow , Alexander Graf , Markus Armbruster , Marcel Apfelbaum , Max Reitz , Laszlo Ersek Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" sysbus-fdc and SUNW,fdtwo devices need to be wired by the fdc initialization code, and can't be used with -device. Unset user_creatable on their device classes. Cc: John Snow Cc: Kevin Wolf Cc: Max Reitz Cc: qemu-block@nongnu.org Cc: Thomas Huth Signed-off-by: Eduardo Habkost --- hw/block/fdc.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/hw/block/fdc.c b/hw/block/fdc.c index a06c8e358c..a328693d15 100644 --- a/hw/block/fdc.c +++ b/hw/block/fdc.c @@ -2880,11 +2880,6 @@ static void sysbus_fdc_class_init(ObjectClass *klass= , void *data) =20 dc->props =3D sysbus_fdc_properties; set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); - /* - * FIXME: Set only for compatibility on q35 machine-type. - * Probably never meant to be user-creatable - */ - dc->user_creatable =3D true; } =20 static const TypeInfo sysbus_fdc_info =3D { @@ -2911,11 +2906,6 @@ static void sun4m_fdc_class_init(ObjectClass *klass,= void *data) =20 dc->props =3D sun4m_fdc_properties; set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); - /* - * FIXME: Set only for compatibility on q35 machine-type. - * Probably never meant to be user-creatable - */ - dc->user_creatable =3D true; } =20 static const TypeInfo sun4m_fdc_info =3D { --=20 2.11.0.259.g40922b1 From nobody Sat Apr 27 20:23:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491007744702429.71337314405605; Fri, 31 Mar 2017 17:49:04 -0700 (PDT) Received: from localhost ([::1]:43393 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7Dz-0005v2-Ad for importer@patchew.org; Fri, 31 Mar 2017 20:49:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51636) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7C3-0004kf-85 for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cu7C2-0006Bk-EF for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37344) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cu7By-00064P-1i; Fri, 31 Mar 2017 20:46:58 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0807EE700C; Sat, 1 Apr 2017 00:46:57 +0000 (UTC) Received: from localhost (ovpn-116-5.gru2.redhat.com [10.97.116.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id E29C07EBD6; Sat, 1 Apr 2017 00:46:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0807EE700C Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=ehabkost@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 0807EE700C From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Fri, 31 Mar 2017 21:46:10 -0300 Message-Id: <20170401004624.30886-6-ehabkost@redhat.com> In-Reply-To: <20170401004624.30886-1-ehabkost@redhat.com> References: <20170401004624.30886-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Sat, 01 Apr 2017 00:46:57 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC 05/19] pflash_cfi01: Remove user_creatable flag X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , Thomas Huth , qemu-block@nongnu.org, Alexander Graf , Markus Armbruster , Marcel Apfelbaum , Max Reitz , Laszlo Ersek Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" TYPE_CFI_PFLASH01 devices need to be mapped by pflash_cfi01_register() and can't be used with -device. Remove user_creatable from the device class. Cc: Kevin Wolf Cc: Max Reitz Cc: qemu-block@nongnu.org Cc: Laszlo Ersek Signed-off-by: Eduardo Habkost Reviewed-by: Laszlo Ersek Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/block/pflash_cfi01.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c index f48dc20035..594d4cf6fe 100644 --- a/hw/block/pflash_cfi01.c +++ b/hw/block/pflash_cfi01.c @@ -927,11 +927,6 @@ static void pflash_cfi01_class_init(ObjectClass *klass= , void *data) dc->props =3D pflash_cfi01_properties; dc->vmsd =3D &vmstate_pflash; set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); - /* - * FIXME: Set only for compatibility on q35 machine-type. - * Probably never meant to be user-creatable - */ - dc->user_creatable =3D true; } =20 =20 --=20 2.11.0.259.g40922b1 From nobody Sat Apr 27 20:23:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491007875447571.256029018756; Fri, 31 Mar 2017 17:51:15 -0700 (PDT) Received: from localhost ([::1]:43407 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7G6-0007fr-4s for importer@patchew.org; Fri, 31 Mar 2017 20:51:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7C6-0004lV-61 for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cu7C3-0006Ds-SP for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52436) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cu7C3-0006CU-MS for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:03 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A041333C175; Sat, 1 Apr 2017 00:47:02 +0000 (UTC) Received: from localhost (ovpn-116-5.gru2.redhat.com [10.97.116.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7798F5C54F; Sat, 1 Apr 2017 00:46:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A041333C175 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=ehabkost@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A041333C175 From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Fri, 31 Mar 2017 21:46:11 -0300 Message-Id: <20170401004624.30886-7-ehabkost@redhat.com> In-Reply-To: <20170401004624.30886-1-ehabkost@redhat.com> References: <20170401004624.30886-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Sat, 01 Apr 2017 00:47:02 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC 06/19] iommu: Remove FIXME comment about user_creatable=true X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , "Michael S. Tsirkin" , Alexander Graf , Markus Armbruster , Marcel Apfelbaum , Laszlo Ersek Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" amd-iommu and intel-iommu are really meant to be used with -device, so they need user_creatable=3Dtrue. Remove the FIXME comment. Cc: Marcel Apfelbaum Cc: "Michael S. Tsirkin" Signed-off-by: Eduardo Habkost --- hw/i386/amd_iommu.c | 4 ---- hw/i386/intel_iommu.c | 4 ---- 2 files changed, 8 deletions(-) diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c index 1d139f3f6a..748c3648bb 100644 --- a/hw/i386/amd_iommu.c +++ b/hw/i386/amd_iommu.c @@ -1186,10 +1186,6 @@ static void amdvi_class_init(ObjectClass *klass, voi= d* data) dc->vmsd =3D &vmstate_amdvi; dc->hotpluggable =3D false; dc_class->realize =3D amdvi_realize; - /* - * FIXME: Set only for compatibility on q35 machine-type. - * Probably never meant to be user-creatable - */ dc->user_creatable =3D true; } =20 diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 5e5125f34b..1db33df5b7 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -2601,10 +2601,6 @@ static void vtd_class_init(ObjectClass *klass, void = *data) dc->hotpluggable =3D false; x86_class->realize =3D vtd_realize; x86_class->int_remap =3D vtd_int_remap; - /* - * FIXME: Set only for compatibility on q35 machine-type. - * Probably never meant to be user-creatable - */ dc->user_creatable =3D true; } =20 --=20 2.11.0.259.g40922b1 From nobody Sat Apr 27 20:23:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491007897779268.73587182907215; Fri, 31 Mar 2017 17:51:37 -0700 (PDT) Received: from localhost ([::1]:43410 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7GS-0007w6-HZ for importer@patchew.org; Fri, 31 Mar 2017 20:51:36 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51686) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7CC-0004pz-9K for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cu7C9-0006PS-G6 for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47288) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cu7C9-0006Ns-9x for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:09 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 498CAC05B3E3; Sat, 1 Apr 2017 00:47:08 +0000 (UTC) Received: from localhost (ovpn-116-5.gru2.redhat.com [10.97.116.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1D81417DC6; Sat, 1 Apr 2017 00:47:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 498CAC05B3E3 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=ehabkost@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 498CAC05B3E3 From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Fri, 31 Mar 2017 21:46:12 -0300 Message-Id: <20170401004624.30886-8-ehabkost@redhat.com> In-Reply-To: <20170401004624.30886-1-ehabkost@redhat.com> References: <20170401004624.30886-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Sat, 01 Apr 2017 00:47:08 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC 07/19] kvmclock: Remove user_creatable flag X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , "Michael S. Tsirkin" , Alexander Graf , Markus Armbruster , Marcel Apfelbaum , Paolo Bonzini , Laszlo Ersek , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" kvmclock should be used by guests only when the appropriate CPUID feature flags are set on the VCPU, and it is automatically created by kvmclock_create() when those feature flags are set. This means creating a kvmclock device using -device is useless. Remove user_creatable from its device class. Cc: "Michael S. Tsirkin" Cc: Paolo Bonzini Cc: Richard Henderson Signed-off-by: Eduardo Habkost --- hw/i386/kvm/clock.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hw/i386/kvm/clock.c b/hw/i386/kvm/clock.c index 0dbf083b17..13eca374cd 100644 --- a/hw/i386/kvm/clock.c +++ b/hw/i386/kvm/clock.c @@ -286,11 +286,6 @@ static void kvmclock_class_init(ObjectClass *klass, vo= id *data) dc->realize =3D kvmclock_realize; dc->vmsd =3D &kvmclock_vmsd; dc->props =3D kvmclock_properties; - /* - * FIXME: Set only for compatibility on q35 machine-type. - * Probably never meant to be user-creatable - */ - dc->user_creatable =3D true; } =20 static const TypeInfo kvmclock_info =3D { --=20 2.11.0.259.g40922b1 From nobody Sat Apr 27 20:23:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 149100789080369.48674932657013; Fri, 31 Mar 2017 17:51:30 -0700 (PDT) Received: from localhost ([::1]:43409 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7GL-0007q2-B3 for importer@patchew.org; Fri, 31 Mar 2017 20:51:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7CF-0004t8-HQ for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cu7CE-0006Xk-JU for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46894) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cu7CE-0006WH-EZ for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:14 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 63786C04F4A1; Sat, 1 Apr 2017 00:47:13 +0000 (UTC) Received: from localhost (ovpn-116-5.gru2.redhat.com [10.97.116.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id AA4006031D; Sat, 1 Apr 2017 00:47:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 63786C04F4A1 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=ehabkost@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 63786C04F4A1 From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Fri, 31 Mar 2017 21:46:13 -0300 Message-Id: <20170401004624.30886-9-ehabkost@redhat.com> In-Reply-To: <20170401004624.30886-1-ehabkost@redhat.com> References: <20170401004624.30886-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Sat, 01 Apr 2017 00:47:13 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC 08/19] ioapic: Remove user_creatable flag X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , "Michael S. Tsirkin" , Alexander Graf , Markus Armbruster , Paolo Bonzini , Marcel Apfelbaum , Igor Mammedov , Laszlo Ersek , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" An ioapic device is already created by the q35 initialization code, and using "-device ioapic" or "-device kvm-ioapic" will always fail with "Only 1 ioapics allowed". Remove the user_creatable flag from the ioapic device classes. Cc: Igor Mammedov Cc: "Michael S. Tsirkin" Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Eduardo Habkost --- hw/i386/kvm/ioapic.c | 5 ----- hw/intc/ioapic.c | 5 ----- 2 files changed, 10 deletions(-) diff --git a/hw/i386/kvm/ioapic.c b/hw/i386/kvm/ioapic.c index cdc35de661..98ca480792 100644 --- a/hw/i386/kvm/ioapic.c +++ b/hw/i386/kvm/ioapic.c @@ -167,11 +167,6 @@ static void kvm_ioapic_class_init(ObjectClass *klass, = void *data) k->post_load =3D kvm_ioapic_put; dc->reset =3D kvm_ioapic_reset; dc->props =3D kvm_ioapic_properties; - /* - * FIXME: Set only for compatibility on q35 machine-type. - * Probably never meant to be user-creatable - */ - dc->user_creatable =3D true; } =20 static const TypeInfo kvm_ioapic_info =3D { diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c index 38af393538..37c4386ae3 100644 --- a/hw/intc/ioapic.c +++ b/hw/intc/ioapic.c @@ -448,11 +448,6 @@ static void ioapic_class_init(ObjectClass *klass, void= *data) k->post_load =3D ioapic_update_kvm_routes; dc->reset =3D ioapic_reset_common; dc->props =3D ioapic_properties; - /* - * FIXME: Set only for compatibility on q35 machine-type. - * Probably never meant to be user-creatable - */ - dc->user_creatable =3D true; } =20 static const TypeInfo ioapic_info =3D { --=20 2.11.0.259.g40922b1 From nobody Sat Apr 27 20:23:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491008073232592.0586123016345; Fri, 31 Mar 2017 17:54:33 -0700 (PDT) Received: from localhost ([::1]:43426 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7JH-0001ql-Tc for importer@patchew.org; Fri, 31 Mar 2017 20:54:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51738) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7CH-0004uo-B6 for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cu7CG-0006bS-Jw for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48388) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cu7CG-0006ZM-EV for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:16 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6BA1C92333; Sat, 1 Apr 2017 00:47:15 +0000 (UTC) Received: from localhost (ovpn-116-5.gru2.redhat.com [10.97.116.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id DEA155C6D5; Sat, 1 Apr 2017 00:47:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6BA1C92333 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=ehabkost@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 6BA1C92333 From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Fri, 31 Mar 2017 21:46:14 -0300 Message-Id: <20170401004624.30886-10-ehabkost@redhat.com> In-Reply-To: <20170401004624.30886-1-ehabkost@redhat.com> References: <20170401004624.30886-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Sat, 01 Apr 2017 00:47:15 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC 09/19] kvmvapic: Remove user_creatable flag X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , "Michael S. Tsirkin" , Alexander Graf , Markus Armbruster , Paolo Bonzini , Marcel Apfelbaum , Igor Mammedov , Laszlo Ersek , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The kvmvapic device needs to be created by apic_common_realize() when apic-common.vapic=3Don is set, not using -device. Remove the user_creatable flag from the device class. Cc: Igor Mammedov Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: "Michael S. Tsirkin" Signed-off-by: Eduardo Habkost --- hw/i386/kvmvapic.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hw/i386/kvmvapic.c b/hw/i386/kvmvapic.c index fbada19253..82a49556af 100644 --- a/hw/i386/kvmvapic.c +++ b/hw/i386/kvmvapic.c @@ -856,11 +856,6 @@ static void vapic_class_init(ObjectClass *klass, void = *data) dc->reset =3D vapic_reset; dc->vmsd =3D &vmstate_vapic; dc->realize =3D vapic_realize; - /* - * FIXME: Set only for compatibility on q35 machine-type. - * Probably never meant to be user-creatable - */ - dc->user_creatable =3D true; } =20 static const TypeInfo vapic_type =3D { --=20 2.11.0.259.g40922b1 From nobody Sat Apr 27 20:23:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491008175410299.2827502318256; Fri, 31 Mar 2017 17:56:15 -0700 (PDT) Received: from localhost ([::1]:43438 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7Kw-0003KM-4p for importer@patchew.org; Fri, 31 Mar 2017 20:56:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51813) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7CT-00052p-15 for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cu7CS-0006qp-8U for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52594) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cu7CM-0006l1-22; Fri, 31 Mar 2017 20:47:22 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D695833C175; Sat, 1 Apr 2017 00:47:20 +0000 (UTC) Received: from localhost (ovpn-116-5.gru2.redhat.com [10.97.116.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id EE37A77CB2; Sat, 1 Apr 2017 00:47:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D695833C175 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=ehabkost@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com D695833C175 From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Fri, 31 Mar 2017 21:46:15 -0300 Message-Id: <20170401004624.30886-11-ehabkost@redhat.com> In-Reply-To: <20170401004624.30886-1-ehabkost@redhat.com> References: <20170401004624.30886-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Sat, 01 Apr 2017 00:47:21 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC 10/19] sysbus-ahci: Remove user_creatable flag X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , qemu-block@nongnu.org, Rob Herring , John Snow , Alexander Graf , Markus Armbruster , Marcel Apfelbaum , "Edgar E. Iglesias" , Alistair Francis , Laszlo Ersek Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The sysbus-ahci devices are supposed to be created and wired by code from other devices, like calxeda_init() and xlnx_zynqmp_realize(), and won't work with -device. Remove the user_creatable flag from the device class. Cc: John Snow Cc: qemu-block@nongnu.org Cc: Rob Herring Cc: Peter Maydell Cc: Alistair Francis Cc: "Edgar E. Iglesias" Signed-off-by: Eduardo Habkost Reviewed-by: Alistair Francis --- hw/ide/ahci.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index b1b7780d56..68f2ce09ee 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -1721,11 +1721,6 @@ static void sysbus_ahci_class_init(ObjectClass *klas= s, void *data) dc->props =3D sysbus_ahci_properties; dc->reset =3D sysbus_ahci_reset; set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); - /* - * FIXME: Set only for compatibility on q35 machine-type. - * Probably never meant to be user-creatable - */ - dc->user_creatable =3D true; } =20 static const TypeInfo sysbus_ahci_info =3D { --=20 2.11.0.259.g40922b1 From nobody Sat Apr 27 20:23:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491008194591481.8853431365387; Fri, 31 Mar 2017 17:56:34 -0700 (PDT) Received: from localhost ([::1]:43439 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7LF-0003XT-3P for importer@patchew.org; Fri, 31 Mar 2017 20:56:33 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7CY-00058V-JJ for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cu7CV-0006vd-Iz for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48460) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cu7CR-0006oy-ED; Fri, 31 Mar 2017 20:47:27 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5C0C79232D; Sat, 1 Apr 2017 00:47:26 +0000 (UTC) Received: from localhost (ovpn-116-5.gru2.redhat.com [10.97.116.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4E3A960BE2; Sat, 1 Apr 2017 00:47:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5C0C79232D Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=ehabkost@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 5C0C79232D From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Fri, 31 Mar 2017 21:46:16 -0300 Message-Id: <20170401004624.30886-12-ehabkost@redhat.com> In-Reply-To: <20170401004624.30886-1-ehabkost@redhat.com> References: <20170401004624.30886-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Sat, 01 Apr 2017 00:47:26 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC 11/19] allwinner-ahci: Remove user_creatable flag X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , qemu-block@nongnu.org, John Snow , Alexander Graf , Markus Armbruster , Beniamino Galvani , qemu-arm@nongnu.org, Marcel Apfelbaum , Laszlo Ersek Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" allwinner-ahci needs to be created and wired by the alwinner-a10 device, and won't work with -device. Remove the user_creatable flag from the device class. Cc: John Snow Cc: qemu-block@nongnu.org Cc: Beniamino Galvani Cc: Peter Maydell Cc: qemu-arm@nongnu.org Signed-off-by: Eduardo Habkost --- hw/ide/ahci.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 68f2ce09ee..f60826d6e0 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -1815,11 +1815,6 @@ static void allwinner_ahci_class_init(ObjectClass *k= lass, void *data) DeviceClass *dc =3D DEVICE_CLASS(klass); =20 dc->vmsd =3D &vmstate_allwinner_ahci; - /* - * FIXME: Set only for compatibility on q35 machine-type. - * Probably never meant to be user-creatable - */ - dc->user_creatable =3D true; } =20 static const TypeInfo allwinner_ahci_info =3D { --=20 2.11.0.259.g40922b1 From nobody Sat Apr 27 20:23:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491008049250311.1298959522227; Fri, 31 Mar 2017 17:54:09 -0700 (PDT) Received: from localhost ([::1]:43424 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7It-0001XE-RS for importer@patchew.org; Fri, 31 Mar 2017 20:54:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7CY-00058W-JY for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cu7CW-0006wu-Rf for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48504) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cu7CW-0006vx-Ln for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:32 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 974EA9232F; Sat, 1 Apr 2017 00:47:31 +0000 (UTC) Received: from localhost (ovpn-116-5.gru2.redhat.com [10.97.116.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id C9E0181864; Sat, 1 Apr 2017 00:47:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 974EA9232F Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=ehabkost@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 974EA9232F From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Fri, 31 Mar 2017 21:46:17 -0300 Message-Id: <20170401004624.30886-13-ehabkost@redhat.com> In-Reply-To: <20170401004624.30886-1-ehabkost@redhat.com> References: <20170401004624.30886-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Sat, 01 Apr 2017 00:47:31 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC 12/19] isabus-bridge: Remove user_creatable flag X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , "Michael S. Tsirkin" , Alexander Graf , Markus Armbruster , Marcel Apfelbaum , Laszlo Ersek Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" isabus-bridge needs to be created by isa_bus_new(), and won't work with -device, as it won't create the TYPE_ISA_BUS bus itself. Remove the user_creatable flag from the device class. Cc: Marcel Apfelbaum Cc: "Michael S. Tsirkin" Signed-off-by: Eduardo Habkost --- hw/isa/isa-bus.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hw/isa/isa-bus.c b/hw/isa/isa-bus.c index 576dbf1763..348e0eab9d 100644 --- a/hw/isa/isa-bus.c +++ b/hw/isa/isa-bus.c @@ -221,11 +221,6 @@ static void isabus_bridge_class_init(ObjectClass *klas= s, void *data) =20 set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); dc->fw_name =3D "isa"; - /* - * FIXME: Set only for compatibility on q35 machine-type. - * Probably never meant to be user-creatable - */ - dc->user_creatable =3D true; } =20 static const TypeInfo isabus_bridge_info =3D { --=20 2.11.0.259.g40922b1 From nobody Sat Apr 27 20:23:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491008055076447.7276450699277; Fri, 31 Mar 2017 17:54:15 -0700 (PDT) Received: from localhost ([::1]:43425 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7Iz-0001cw-PZ for importer@patchew.org; Fri, 31 Mar 2017 20:54:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51932) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7Cb-00058a-6W for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cu7Ca-0006zd-BS for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49768) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cu7Ca-0006yw-69 for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:36 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 28B249E193; Sat, 1 Apr 2017 00:47:35 +0000 (UTC) Received: from localhost (ovpn-116-5.gru2.redhat.com [10.97.116.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id ED2C96031D; Sat, 1 Apr 2017 00:47:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 28B249E193 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=ehabkost@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 28B249E193 From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Fri, 31 Mar 2017 21:46:18 -0300 Message-Id: <20170401004624.30886-14-ehabkost@redhat.com> In-Reply-To: <20170401004624.30886-1-ehabkost@redhat.com> References: <20170401004624.30886-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Sat, 01 Apr 2017 00:47:35 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC 13/19] unimplemented-device: Remove user_creatable flag X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , Alexander Graf , Markus Armbruster , Marcel Apfelbaum , Laszlo Ersek Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" unimplemented-device needs to be created and mapped using create_unimplemented_device(), and won't work with -device. Remove the user_creatable flag from the device class. Cc: Peter Maydell Signed-off-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/misc/unimp.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hw/misc/unimp.c b/hw/misc/unimp.c index 284f096beb..bcbb585888 100644 --- a/hw/misc/unimp.c +++ b/hw/misc/unimp.c @@ -90,11 +90,6 @@ static void unimp_class_init(ObjectClass *klass, void *d= ata) =20 dc->realize =3D unimp_realize; dc->props =3D unimp_properties; - /* - * FIXME: Set only for compatibility on q35 machine-type. - * Probably never meant to be user-creatable - */ - dc->user_creatable =3D true; } =20 static const TypeInfo unimp_info =3D { --=20 2.11.0.259.g40922b1 From nobody Sat Apr 27 20:23:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491008303913747.5013717253861; Fri, 31 Mar 2017 17:58:23 -0700 (PDT) Received: from localhost ([::1]:43445 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7N0-00059v-Nx for importer@patchew.org; Fri, 31 Mar 2017 20:58:22 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51958) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7Ci-0005H7-T0 for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cu7Cf-00072X-QP for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52752) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cu7Cf-00071k-KW for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:41 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8FFFF345599; Sat, 1 Apr 2017 00:47:40 +0000 (UTC) Received: from localhost (ovpn-116-5.gru2.redhat.com [10.97.116.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9FA4677CB2; Sat, 1 Apr 2017 00:47:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8FFFF345599 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=ehabkost@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 8FFFF345599 From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Fri, 31 Mar 2017 21:46:19 -0300 Message-Id: <20170401004624.30886-15-ehabkost@redhat.com> In-Reply-To: <20170401004624.30886-1-ehabkost@redhat.com> References: <20170401004624.30886-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Sat, 01 Apr 2017 00:47:40 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC 14/19] fw_cfg: Remove user_creatable flag X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , "Michael S. Tsirkin" , "Gabriel L . Somlo" , Alexander Graf , Markus Armbruster , Marcel Apfelbaum , Laszlo Ersek Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" fw_cfg won't work with -device, as: * fw_cfg_init1() won't get called for the device; * The device won't appear at /machine/fw_cfg, and won't work with the -fw_cfg command-line option. Remove the user_creatable flag from the device class. Cc: "Michael S. Tsirkin" Cc: Laszlo Ersek Cc: Gabriel L. Somlo Signed-off-by: Eduardo Habkost Reviewed-by: Laszlo Ersek --- hw/nvram/fw_cfg.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index 60bf4fdd2e..316fca9bc1 100644 --- a/hw/nvram/fw_cfg.c +++ b/hw/nvram/fw_cfg.c @@ -1101,11 +1101,6 @@ static void fw_cfg_io_class_init(ObjectClass *klass,= void *data) =20 dc->realize =3D fw_cfg_io_realize; dc->props =3D fw_cfg_io_properties; - /* - * FIXME: Set only for compatibility on q35 machine-type. - * Probably never meant to be user-creatable - */ - dc->user_creatable =3D true; } =20 static const TypeInfo fw_cfg_io_info =3D { @@ -1172,11 +1167,6 @@ static void fw_cfg_mem_class_init(ObjectClass *klass= , void *data) =20 dc->realize =3D fw_cfg_mem_realize; dc->props =3D fw_cfg_mem_properties; - /* - * FIXME: Set only for compatibility on q35 machine-type. - * Probably never meant to be user-creatable - */ - dc->user_creatable =3D true; } =20 static const TypeInfo fw_cfg_mem_info =3D { --=20 2.11.0.259.g40922b1 From nobody Sat Apr 27 20:23:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491008203179499.3707679190171; Fri, 31 Mar 2017 17:56:43 -0700 (PDT) Received: from localhost ([::1]:43440 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7LO-0003fk-0q for importer@patchew.org; Fri, 31 Mar 2017 20:56:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51971) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7Ck-0005I5-DH for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cu7Cj-00075Q-FW for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39372) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cu7Cj-00074Z-9c for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:45 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3ABF68810; Sat, 1 Apr 2017 00:47:44 +0000 (UTC) Received: from localhost (ovpn-116-5.gru2.redhat.com [10.97.116.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 073B360BE2; Sat, 1 Apr 2017 00:47:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3ABF68810 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=ehabkost@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 3ABF68810 From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Fri, 31 Mar 2017 21:46:20 -0300 Message-Id: <20170401004624.30886-16-ehabkost@redhat.com> In-Reply-To: <20170401004624.30886-1-ehabkost@redhat.com> References: <20170401004624.30886-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Sat, 01 Apr 2017 00:47:44 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC 15/19] esp: Remove user_creatable flag X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , Alexander Graf , Markus Armbruster , Marcel Apfelbaum , Paolo Bonzini , Laszlo Ersek Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" esp devices aren't going to work with -device, as they need to be wired by esp_init(). Remove the user_creatable flag from the device class. Cc: Paolo Bonzini Signed-off-by: Eduardo Habkost --- hw/scsi/esp.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c index 1087b8f14f..eee831efeb 100644 --- a/hw/scsi/esp.c +++ b/hw/scsi/esp.c @@ -728,11 +728,6 @@ static void sysbus_esp_class_init(ObjectClass *klass, = void *data) dc->reset =3D sysbus_esp_hard_reset; dc->vmsd =3D &vmstate_sysbus_esp_scsi; set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); - /* - * FIXME: Set only for compatibility on q35 machine-type. - * Probably never meant to be user-creatable - */ - dc->user_creatable =3D true; } =20 static const TypeInfo sysbus_esp_info =3D { --=20 2.11.0.259.g40922b1 From nobody Sat Apr 27 20:23:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491008318647980.0305360814276; Fri, 31 Mar 2017 17:58:38 -0700 (PDT) Received: from localhost ([::1]:43446 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7NF-0005Lg-Fa for importer@patchew.org; Fri, 31 Mar 2017 20:58:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7Co-0005KX-A3 for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cu7Cn-00077s-B0 for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38244) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cu7Cn-00077L-5P for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:49 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E0E6D2EAA9E; Sat, 1 Apr 2017 00:47:47 +0000 (UTC) Received: from localhost (ovpn-116-5.gru2.redhat.com [10.97.116.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9F47918F1C; Sat, 1 Apr 2017 00:47:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E0E6D2EAA9E Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=ehabkost@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com E0E6D2EAA9E From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Fri, 31 Mar 2017 21:46:21 -0300 Message-Id: <20170401004624.30886-17-ehabkost@redhat.com> In-Reply-To: <20170401004624.30886-1-ehabkost@redhat.com> References: <20170401004624.30886-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Sat, 01 Apr 2017 00:47:48 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC 16/19] generic-sdhci: Remove user_creatable flag X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , Prasad J Pandit , "Michael S. Tsirkin" , Alexander Graf , Markus Armbruster , Marcel Apfelbaum , "Edgar E. Iglesias" , Alistair Francis , Laszlo Ersek , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" generic-sdhci needs to be wired by other devices' code, so it can't be used with -device. Remove the user_creatable flag from the device class. Cc: Peter Maydell Cc: "Edgar E. Iglesias" Cc: David Gibson Cc: Alexander Graf Cc: "Michael S. Tsirkin" Cc: Marcel Apfelbaum Cc: Prasad J Pandit Cc: Alistair Francis Signed-off-by: Eduardo Habkost Reviewed-by: Alistair Francis --- hw/sd/sdhci.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index 186555188b..6d6a791ee9 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -1360,11 +1360,6 @@ static void sdhci_sysbus_class_init(ObjectClass *kla= ss, void *data) dc->props =3D sdhci_sysbus_properties; dc->realize =3D sdhci_sysbus_realize; dc->reset =3D sdhci_poweron_reset; - /* - * FIXME: Set only for compatibility on q35 machine-type. - * Probably never meant to be user-creatable - */ - dc->user_creatable =3D true; } =20 static const TypeInfo sdhci_sysbus_info =3D { --=20 2.11.0.259.g40922b1 From nobody Sat Apr 27 20:23:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491008280827150.04410993213708; Fri, 31 Mar 2017 17:58:00 -0700 (PDT) Received: from localhost ([::1]:43444 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7Md-0004sC-GJ for importer@patchew.org; Fri, 31 Mar 2017 20:57:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7Cr-0005Kt-HM for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cu7Cp-00079W-10 for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48676) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cu7Co-00078t-S4 for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:50 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CF76D92333; Sat, 1 Apr 2017 00:47:49 +0000 (UTC) Received: from localhost (ovpn-116-5.gru2.redhat.com [10.97.116.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5506D77EB7; Sat, 1 Apr 2017 00:47:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CF76D92333 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=ehabkost@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com CF76D92333 From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Fri, 31 Mar 2017 21:46:22 -0300 Message-Id: <20170401004624.30886-18-ehabkost@redhat.com> In-Reply-To: <20170401004624.30886-1-ehabkost@redhat.com> References: <20170401004624.30886-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Sat, 01 Apr 2017 00:47:50 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC 17/19] hpet: Remove user_creatable flag X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , "Michael S. Tsirkin" , Alexander Graf , Markus Armbruster , Marcel Apfelbaum , Paolo Bonzini , Laszlo Ersek Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" hpet needs to be mappend and wired by the board code and won't work with -device. Remove the user_creatable flag from the device class. Cc: "Michael S. Tsirkin" Cc: Paolo Bonzini Signed-off-by: Eduardo Habkost --- hw/timer/hpet.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c index b5dab1c8e2..a2c18b30c3 100644 --- a/hw/timer/hpet.c +++ b/hw/timer/hpet.c @@ -771,11 +771,6 @@ static void hpet_device_class_init(ObjectClass *klass,= void *data) dc->reset =3D hpet_reset; dc->vmsd =3D &vmstate_hpet; dc->props =3D hpet_device_properties; - /* - * FIXME: Set only for compatibility on q35 machine-type. - * Probably never meant to be user-creatable - */ - dc->user_creatable =3D true; } =20 static const TypeInfo hpet_device_info =3D { --=20 2.11.0.259.g40922b1 From nobody Sat Apr 27 20:23:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491008398461847.736390780687; Fri, 31 Mar 2017 17:59:58 -0700 (PDT) Received: from localhost ([::1]:43450 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7OV-0006GL-MX for importer@patchew.org; Fri, 31 Mar 2017 20:59:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52040) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7Ct-0005Mc-Gn for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cu7Cs-0007D8-Ou for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49916) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cu7Cs-0007CG-JN for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:54 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 95C289E193; Sat, 1 Apr 2017 00:47:53 +0000 (UTC) Received: from localhost (ovpn-116-5.gru2.redhat.com [10.97.116.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 316A277EBF; Sat, 1 Apr 2017 00:47:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 95C289E193 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=ehabkost@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 95C289E193 From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Fri, 31 Mar 2017 21:46:23 -0300 Message-Id: <20170401004624.30886-19-ehabkost@redhat.com> In-Reply-To: <20170401004624.30886-1-ehabkost@redhat.com> References: <20170401004624.30886-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Sat, 01 Apr 2017 00:47:53 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC 18/19] sysbus-ohci: Remove user_creatable flag X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , Alexander Graf , Markus Armbruster , Gerd Hoffmann , Marcel Apfelbaum , Laszlo Ersek Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" sysbus-ohci needs to be mappend and wired by device or board code, and won't work with -device. Remove the user_creatable flag from the device class. Cc: Gerd Hoffmann Signed-off-by: Eduardo Habkost --- hw/usb/hcd-ohci.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index 0e17fb1e60..3ada35e954 100644 --- a/hw/usb/hcd-ohci.c +++ b/hw/usb/hcd-ohci.c @@ -2159,11 +2159,6 @@ static void ohci_sysbus_class_init(ObjectClass *klas= s, void *data) dc->desc =3D "OHCI USB Controller"; dc->props =3D ohci_sysbus_properties; dc->reset =3D usb_ohci_reset_sysbus; - /* - * FIXME: Set only for compatibility on q35 machine-type. - * Probably never meant to be user-creatable - */ - dc->user_creatable =3D true; } =20 static const TypeInfo ohci_sysbus_info =3D { --=20 2.11.0.259.g40922b1 From nobody Sat Apr 27 20:23:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491008470530367.1834774305738; Fri, 31 Mar 2017 18:01:10 -0700 (PDT) Received: from localhost ([::1]:43461 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7Ph-00079I-6W for importer@patchew.org; Fri, 31 Mar 2017 21:01:09 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52079) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7D0-0005TD-Aj for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:48:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cu7Cy-0007HS-1f for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:48:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49976) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cu7Cx-0007H0-Rd for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:59 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C3109DA0A5; Sat, 1 Apr 2017 00:47:58 +0000 (UTC) Received: from localhost (ovpn-116-5.gru2.redhat.com [10.97.116.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0A0FF7EBD6; Sat, 1 Apr 2017 00:47:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C3109DA0A5 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=ehabkost@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com C3109DA0A5 From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Fri, 31 Mar 2017 21:46:24 -0300 Message-Id: <20170401004624.30886-20-ehabkost@redhat.com> In-Reply-To: <20170401004624.30886-1-ehabkost@redhat.com> References: <20170401004624.30886-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Sat, 01 Apr 2017 00:47:58 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC 19/19] virtio-mmio: Remove user_creatable flag X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , "Michael S. Tsirkin" , Alexander Graf , Markus Armbruster , Shannon Zhao , Marcel Apfelbaum , Laszlo Ersek Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" virtio-mmio needs to be wired and mapped by other device or board code, and won't work with -device. Remove the user_creatable flag from the device class. Cc: Peter Maydell Cc: Shannon Zhao Cc: "Michael S. Tsirkin" Signed-off-by: Eduardo Habkost Reviewed-by: Laszlo Ersek --- hw/virtio/virtio-mmio.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c index b595512a3d..5807aa87fe 100644 --- a/hw/virtio/virtio-mmio.c +++ b/hw/virtio/virtio-mmio.c @@ -450,11 +450,6 @@ static void virtio_mmio_class_init(ObjectClass *klass,= void *data) dc->reset =3D virtio_mmio_reset; set_bit(DEVICE_CATEGORY_MISC, dc->categories); dc->props =3D virtio_mmio_properties; - /* - * FIXME: Set only for compatibility on q35 machine-type. - * Probably never meant to be user-creatable - */ - dc->user_creatable =3D true; } =20 static const TypeInfo virtio_mmio_info =3D { --=20 2.11.0.259.g40922b1