[Qemu-devel] [PATCH for-2.10 0/2] etsec: (TYPE_)ETSEC_COMMON macro cleanup

Eduardo Habkost posted 2 patches 6 years, 12 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170331192724.14339-1-ehabkost@redhat.com
Test checkpatch passed
Test docker passed
Test s390x passed
hw/net/fsl_etsec/etsec.h |  6 +++---
hw/net/fsl_etsec/etsec.c | 10 +++++-----
hw/ppc/e500.c            |  4 ++--
3 files changed, 10 insertions(+), 10 deletions(-)
[Qemu-devel] [PATCH for-2.10 0/2] etsec: (TYPE_)ETSEC_COMMON macro cleanup
Posted by Eduardo Habkost 6 years, 12 months ago
When working on other things, I got confused by the etsec code,
that didn't use the TYPE_ETSEC_COMMON macro in its type
declaration, and had no subclasses despite being named
ETSEC_COMMON.

This is a very simple cleanup to remove the _COMMON suffix from
the macros, and to use the TYPE_ETSEC macro when registering and
creating devices instead of hardcoding the "eTSEC" name.

Cc: Alexander Graf <agraf@suse.de>
Cc: Scott Wood <scottwood@freescale.com>
Cc: Jason Wang <jasowang@redhat.com>
Cc: Fabien Chouteau <chouteau@adacore.com>
Cc: qemu-ppc@nongnu.org

Eduardo Habkost (2):
  etsec: Rename (TYPE_)ETSEC_COMMON to (TYPE_)ETSEC
  etsec: Use TYPE_ETSEC macro when registering/creating device

 hw/net/fsl_etsec/etsec.h |  6 +++---
 hw/net/fsl_etsec/etsec.c | 10 +++++-----
 hw/ppc/e500.c            |  4 ++--
 3 files changed, 10 insertions(+), 10 deletions(-)

-- 
2.11.0.259.g40922b1


Re: [Qemu-devel] [PATCH for-2.10 0/2] etsec: (TYPE_)ETSEC_COMMON macro cleanup
Posted by Philippe Mathieu-Daudé 6 years, 12 months ago
On 03/31/2017 04:27 PM, Eduardo Habkost wrote:
> When working on other things, I got confused by the etsec code,
> that didn't use the TYPE_ETSEC_COMMON macro in its type
> declaration, and had no subclasses despite being named
> ETSEC_COMMON.
>
> This is a very simple cleanup to remove the _COMMON suffix from
> the macros, and to use the TYPE_ETSEC macro when registering and
> creating devices instead of hardcoding the "eTSEC" name.
>
> Cc: Alexander Graf <agraf@suse.de>
> Cc: Scott Wood <scottwood@freescale.com>
> Cc: Jason Wang <jasowang@redhat.com>
> Cc: Fabien Chouteau <chouteau@adacore.com>
> Cc: qemu-ppc@nongnu.org
>
> Eduardo Habkost (2):
>   etsec: Rename (TYPE_)ETSEC_COMMON to (TYPE_)ETSEC
>   etsec: Use TYPE_ETSEC macro when registering/creating device

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

>
>  hw/net/fsl_etsec/etsec.h |  6 +++---
>  hw/net/fsl_etsec/etsec.c | 10 +++++-----
>  hw/ppc/e500.c            |  4 ++--
>  3 files changed, 10 insertions(+), 10 deletions(-)
>

Re: [Qemu-devel] [PATCH for-2.10 0/2] etsec: (TYPE_)ETSEC_COMMON macro cleanup
Posted by Fabien Chouteau 6 years, 11 months ago
On 02/04/2017 14:42, Philippe Mathieu-Daudé wrote:
> On 03/31/2017 04:27 PM, Eduardo Habkost wrote:
>> When working on other things, I got confused by the etsec code,
>> that didn't use the TYPE_ETSEC_COMMON macro in its type
>> declaration, and had no subclasses despite being named
>> ETSEC_COMMON.
>>
>> This is a very simple cleanup to remove the _COMMON suffix from
>> the macros, and to use the TYPE_ETSEC macro when registering and
>> creating devices instead of hardcoding the "eTSEC" name.
>>
>> Cc: Alexander Graf <agraf@suse.de>
>> Cc: Scott Wood <scottwood@freescale.com>
>> Cc: Jason Wang <jasowang@redhat.com>
>> Cc: Fabien Chouteau <chouteau@adacore.com>
>> Cc: qemu-ppc@nongnu.org
>>
>> Eduardo Habkost (2):
>>   etsec: Rename (TYPE_)ETSEC_COMMON to (TYPE_)ETSEC
>>   etsec: Use TYPE_ETSEC macro when registering/creating device
> 
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> 

Reviewed-by: Fabien Chouteau <chouteau@adacore.com>


Thanks Eduardo,