From nobody Sun Apr 28 07:10:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1490401379458630.3972991316232; Fri, 24 Mar 2017 17:22:59 -0700 (PDT) Received: from localhost ([::1]:35409 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1crZTt-000194-Kk for importer@patchew.org; Fri, 24 Mar 2017 20:22:57 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1crZSk-0000IQ-63 for qemu-devel@nongnu.org; Fri, 24 Mar 2017 20:21:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1crZSh-0002WG-0w for qemu-devel@nongnu.org; Fri, 24 Mar 2017 20:21:46 -0400 Received: from mail-dm3nam03on0132.outbound.protection.outlook.com ([104.47.41.132]:39936 helo=NAM03-DM3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1crZSg-0002Vw-F9 for qemu-devel@nongnu.org; Fri, 24 Mar 2017 20:21:42 -0400 Received: from vroomfondel.redmond.corp.microsoft.com (2001:4898:80e8:a::202) by SN1PR21MB0062.namprd21.prod.outlook.com (10.161.254.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1005.2; Fri, 24 Mar 2017 23:46:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=9y/uwmotatriiWBGEBumtn0XCu2iSVpWBZUIOeW/8JU=; b=FOqiu1s+VgekMncGOQ5Zzuu/iCLKvQFTCECn1BtOHk7ZBk0Ik+e7mYYnOYynvqP1SQ5mhpKx9vw6R3vm/kFSkO2oNrGLxkCy6MRw1xgxHegNAX12kEYqkvjlNvkk244BAWFX2L3TqK7DtGQjDQjHLbezLTaxnOt8juPDyyttSPQ= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none; nongnu.org; dmarc=none action=none header.from=microsoft.com; From: Andrew Baumann To: Date: Fri, 24 Mar 2017 16:46:46 -0700 Message-ID: <20170324234646.15264-1-Andrew.Baumann@microsoft.com> X-Mailer: git-send-email 2.8.3 MIME-Version: 1.0 X-Originating-IP: [2001:4898:80e8:a::202] X-ClientProxiedBy: DM5PR16CA0001.namprd16.prod.outlook.com (10.173.216.11) To SN1PR21MB0062.namprd21.prod.outlook.com (10.161.254.148) X-MS-Office365-Filtering-Correlation-Id: a82809df-fdd3-4bde-195e-08d473100f50 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(201703131423014)(201703031133020); SRVR:SN1PR21MB0062; X-Microsoft-Exchange-Diagnostics: 1; SN1PR21MB0062; 3:oDJ46+WMfeT8lPZmdaUqHBpwsGzIAKAG7K+9sxxs4mVojKrQidLNLfGi6ChDffHAVnrki+NBwS179DYtVsLpy9A9togMObDcTneaC/LI/a8eY3zFUImWbUfyDn6xInlCX0WL6bvgi46ZJcXgoNbohHOIm+pJJgsIth6Ydz9XlBr95clegxp1pKD8a7zp+Gq4UHjMiGaB/7vrP9xgt7G9X/buzU6zLCdr/dAeIXtQ2n2GpommkPwl5IqgzdOjnOB2fXcuAyloHLAMhs9VB2RkbOTAUXy43JbCFd2quWg6/1lmnMt+SJtqwUczQ2LCN+XcHCQFdg6yki1OB/qIz/Jwg9E8+5hmkthNTIF7w6ElttY=; 25:mPkeIqfu5DwE8c6xD0YMHB7cg1uhTn3dKsLF/OljddBR/3Q4V/RL3yxL41FET9eYOMa8c3WyZfbEgukICXD1qlRNyR6TWAsG+10sxuORs1w9yu5p8vWs9GqQldPs3gqHv9hYQV6CF4UOt+mzd06h3q17gtGUgW0ciE/I0TlQPyBfZMWF7b8ttAfTNcE6rtLPZUQQro6+xkTuUqD/9/0tYjyWpicaHwtGUzyS9W50Al/Mi4Q1sjPEZr+Cjktyh0iF1o8peUXkJB7KT2wsXUwaMVfNL/G+e+j/Ag0zwhVAcUhebRIHsbSalgiwLttUCdxncCN/ElzyeL8mn1q34czuwpLACIOoDt08rNMB9RknZhzKXVR/lI+g7fGJKfnAJa2RlGAtX57cKYZmKpLGrb7c1aiS/SlqcT/5E8SQKcEJWpdnxOcRYgdZwXtDsC3KHO1ca+69s9PRR8VR0HaoRDyanA== X-Microsoft-Exchange-Diagnostics: 1; SN1PR21MB0062; 31:BEqWEISfvk1YbZCVT8t+g1+F9i5Jq9nY1gonDaniE9BcnPC3+zAdWEomTLULV0Q0zg8BjyreVgvoieOWeybAlZHwmCLTdJAR3W4rTIL6cepEyICoWcuqWQdbl5/btKy06pJv5ualzDbvxzlz0jDM77BszaSQWvGd21vgx/aB7szxDHZvyHDmL39X+rgnsBH0lz4l+euSqPZlWCrNDZnLsLyILg/vVLmfInwTA7j33rrrkdTR5bpFXUcNHwG0J/ePRUMiPf7BdqiyKxZLkSKUwI+rz1FxaXJzDLkPpY+iZZk=; 20:03VhXX7NhXAFEEcHxAlZDW5ZLtkaMzXWY4N156QtVVKRGxAlYSZAc3gfT/5ZddYIcHwacySO04/LjAnoicd5hvpXVN9gJe6jvjOu9jgKvTprhAH81keQz3pxeutZs2seWODy2Vdw3QVDtgU76mD2la1pZxMzzLs4IEYpE/w0vPLIj6us3b6En0qjrFuNF2iGHBGJzLESpav6+Xw+1QIr6elzjZOLpJfD+I8fi6c+gSQDIlSCCCu7GOhgGXVxEHGY8VEmdD8UGX+X9FkXvhKDQg0nc2D2iEje/lClubYdkvw5oxJpqElOpidw1QKV/Cv9L0zDbQZ2R4sriFM1MEuP9vcbbmPNr7HQZ3oxVziegOljWPZUudYwyJg+IFdwqqbzRYQ2OhsQN0bHjbMN+43iPN5u6nKmPbPyGQTFIkPc2EZvxRqy9KXmSeviEk9tpqiOZ5Z6n3kFdtn8+ohlgw7jE14LOMQvefGvOIYGh6TgnwUWrxJJCF8Y1JF4iNT0zBs7 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040393)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006021)(93001021)(6055026)(6041248)(20161123562025)(20161123555025)(201703131423018)(201702281528018)(201703061421016)(201703061406016)(20161123560025)(20161123558025)(20161123564025)(6072148); SRVR:SN1PR21MB0062; BCL:0; PCL:0; RULEID:; SRVR:SN1PR21MB0062; X-Microsoft-Exchange-Diagnostics: 1; SN1PR21MB0062; 4:JqdJPKzbZ6XJKUsCuPkCEAwfXJnjAICD3NJJzpxxLHn7Og44E4Gm1YmrfM5XWM5HYkGVsvL8DYRY0+54uNwyBxSq7YQDWMrhGxxQHt1QTwk2v4qNxEUW/m+PG5jbFjYvMwUZT6s9HImofk0ENBs/+TmcKJH2gvyfDzrcIFYE9k0BE4c8vAGGfkspj5q0W1bsckr/zGRndBmvWhKwlM+ZMPFPoD1loK1k6WcjQGtovVok/5fpDm9fe1W7LpS6cSS1s8p3yAV9XxQI/mSOhc5b/kWcgZGBlkomIdLWF+aag+VnmeoaWD1eVx1ehptXUzM26tDUgSh1FRn+JslRS/sXofz2QGItQXYf4UjmS4gOV+TdFSTm63zEZQ/+R7mdK6xkRj4Pupyg6rl+uIzwtWofcicN0r95xnVozbrOT8dJkq3yhBbckgIodH6t0Hv27nkURS0KwWy8s6YHvvICHnktki9pYQ1VDFgBrLhEbwJ1hsCr5dt7fGuhyhFgB9wGQesgvV1JEg06Wgd6d1eb+hSNUvUXD9SXYQc1JKLxxzDvUZmEYgiINfXyc1yZKhc6FqWNvw9fH16PsA33GromncD/CAWbAPXkkimujaizpYXYX2TQ7Ngyfquyt73kGJLeUz6YKxnR220gZFgOjgVyiaLS1wdgz+BwIA5K1hcAADPjOLCS/ArJ2TOCa39FBqLC8OUDCvdGMtVGffZKWfxWSxesgPyEWPgcKS6NhYzjH0NHVci00gkvqZKvNjpvSOKAnBL/eHiEnquDlyX1X2jtDP6XhXQ05LenLL4SubUAtdtVZLSUrgbCQGVXcWTXpdNIRA3k X-Forefront-PRVS: 0256C18696 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(6009001)(39450400003)(39840400002)(39860400002)(39410400002)(39850400002)(81166006)(50226002)(6486002)(2351001)(8676002)(10290500002)(5660300001)(25786009)(2906002)(54906002)(10090500001)(38730400002)(53936002)(4326008)(5005710100001)(107886003)(50466002)(110136004)(48376002)(86612001)(5003940100001)(189998001)(47776003)(36756003)(305945005)(1076002)(6116002)(7736002)(6666003)(86362001)(42186005)(50986999)(6916009); DIR:OUT; SFP:1102; SCL:1; SRVR:SN1PR21MB0062; H:vroomfondel.redmond.corp.microsoft.com; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR21MB0062; 23:wfBG/xIyIbRrEMbwKA7z11d1g0LtXWSEWNSSDBz4E?= =?us-ascii?Q?Scr3C7gFgkbACXBvdSVY+YMwY31e9YwJRRQhJd0m1idLpgr2GqvTyHBrQ3aW?= =?us-ascii?Q?TXgUWUHprRJUjF1futncJ/UaadDyWoFKJQ2pkjtg7wCZDpeL5F5Fdzyu32cB?= =?us-ascii?Q?zhNIBt15dgzTBS0MEtnJikbkUxco2w3THOUEiH3/Smvn7PUw4dC1ggizKqm6?= =?us-ascii?Q?dZX7XY4JCelsFBOT2FH/9HYxNLj6D7yfJnqZdaOipoBq/8rbypfIk4RmDgbH?= =?us-ascii?Q?a2BNjrvkpuYsWU5sqeSzK5e5gDl59DZzdfrK5dA9scnbr34cMKbyJpGo67pm?= =?us-ascii?Q?4dfmTdPWXaettAuA1GPNOSG/VOEibaC5RJs3iWP+1jc4u2LOkyUaLT+g7Du7?= =?us-ascii?Q?Zbl71w5ImIuC+FmzMqr2Q82xzeVg99PYh4Isjv7bmhVzsfhaS9Uk/MKs/8nr?= =?us-ascii?Q?Vw1tGw8dU94DUeY6zdwINDEHl+Fhu3TywnMOx/i6fcQrMqEhTJe5tjKMRGQs?= =?us-ascii?Q?l+y7DG6n8DGEPle2PD0XkAmdIkl3dLMkD81bmlrhwPoB/McQ8rQ7NDO7GpzP?= =?us-ascii?Q?8qcqaMDnP+KfmCyV6JzTHR+FSlKRJSScXp8/Z+kf6nckZmDANoi3bR4sbJG+?= =?us-ascii?Q?u/tL0rRg0d60l+WPMaZM6qcAMzF59NXei/0cOldUqtFx1Ha8Dt9+mMDOTVLQ?= =?us-ascii?Q?M2JObr3KVdIK0csOqPxOYuV8Ns6ted2V4IW47vbHzgxSnRWi3YaM446jJ34R?= =?us-ascii?Q?gJaZgkXepVWrfu7EGZOVQzp/4cfHfkBkb9y9cwouJjIxeQMmVZiY+v8dH6hH?= =?us-ascii?Q?TVjixkNrCtPbX9ZhTPpJaiBIBbLOdFf91gmBh2VjXwdXqE91/q/HYGARYGq6?= =?us-ascii?Q?bMnfC0U/KZ643aBl4/CE9CglrhILF3HM0z+mxlHNM2LhJUivqVlJm3Ndt7N2?= =?us-ascii?Q?Hus+oV/UJRBLSn+6chmnt779nDmgMvCGFQWjebcl56gyp2b1MGCg0DYyRHAt?= =?us-ascii?Q?lM0ugi2NsLih3FMI5K9hH4ai1sohFmdeaVnDd1GJq4HNNLqeOnSUX0BNM4IB?= =?us-ascii?Q?9W9cqU=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN1PR21MB0062; 6:pGRUbv/bFXsx4gIaptHu8/jwpXa9gMdaSyMLVdurXx0MDC+WLclXPMGL4+G63f4VbRNPti7W52JozvAcKorxasX4gQkCD4qG02k9ZxQIM1Ad8P31mOWc6jajwkjZjZ8Tx5fMJNHjVlDkEfngWgR/mA8q0PoFTXLFIR9g1yNfELH1piAJxl71kSfIQoFLxNC335uybsA8Gz8SriDclQA/jdfp7ZPif9LAmk+pZvyarzkMw1QhTboWEdlS/2bUYFx0B3CsmNv/lfD21rmqigxs2vOt5uzbeHofHOWOm3B+bHqk6JUDXp+nDmbD1oELUEqQHDZqnUtcSEsIa8KziFWyDphTdxdctfOa+De46KauQeFgpc8bn29JJ6TgaxXdyfPKRD33wFAdRqWGEAupdqCUi3rArunO/yoidS7RRboR3rU=; 5:YGqd1Tp2mH+UT6YgVWuSI+t1uNfSxWurROZ8/xYEv0b59skMlwojaU9kA0a026FplRzMrC0LdLkuDrLsOQO9qVeimh2yPrAHzquPM+j0xs/hcrKLdPDs4whuKb2t+cuudq1ScTv1Fgdf9B2M5wJlxQ==; 24:oKNZ5IR+bMw3yDwHhU66zXzvcjNmiDWTMt+R0WpV0kvOKJUkylYieNPQmmgiKeJsua59jdpdsVRmZLMmn3pyX9K1ZeUeFpbxcLqRZp7A+40= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN1PR21MB0062; 7:lIySJqLbxF9yvA2FZUn0o1JvJueykkOXnpl8Kl0YJsTD9VyxjmSHJYCN+uHb1FQu/9G1sJsUgqSRLKJBk1eH3rSn/kKA1yBdLmgtAnQMtKsl52Ty3kVMeDw3BQBLprS+yiVpxIVBrqoB1NUyFE0+eX16TaNs6IqANPZqCDttbtdqfwZPaeoyezcgAz3lyRD6pYsGn7UrkiOFZE2f1ZRYEbohUCoiopHGeLqkwTHIlO7GGXq0zMfsRO5sPbT/EQ6A5nyai9E65fEPP+sML4a8mk8BS9QWOifB8xbgiUnr/9AsrGRVbIDf99BOgl9wNsUyij78c9gdwZWD5f7j/zVnzw== X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2017 23:46:57.5698 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR21MB0062 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.41.132 Subject: [Qemu-devel] [PATCH] tap-win32: don't abort in tap_enable(); enables -netdev tap X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Weil , Jason Wang , Andrew Baumann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The docs generally steer users away from using the legacy -net parameter, however on win32 attempting to enable a tap device using -netdev tap fails at an abort() in tap_enable(). Removing the abort()s seems to be enough to get everything working, so do that. Signed-off-by: Andrew Baumann --- net/tap-win32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/tap-win32.c b/net/tap-win32.c index 662f9b6..3620843 100644 --- a/net/tap-win32.c +++ b/net/tap-win32.c @@ -811,10 +811,10 @@ int net_init_tap(const Netdev *netdev, const char *na= me, =20 int tap_enable(NetClientState *nc) { - abort(); + return 0; } =20 int tap_disable(NetClientState *nc) { - abort(); + return 0; } --=20 2.8.3