From nobody Thu May 2 20:16:19 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1490260999264277.19134899912297; Thu, 23 Mar 2017 02:23:19 -0700 (PDT) Received: from localhost ([::1]:55114 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cqyxi-0005Ta-5z for importer@patchew.org; Thu, 23 Mar 2017 05:23:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cqyx1-0005C1-9E for qemu-devel@nongnu.org; Thu, 23 Mar 2017 05:22:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cqyww-0006Ov-Id for qemu-devel@nongnu.org; Thu, 23 Mar 2017 05:22:35 -0400 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:33662) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cqyww-0006Om-B7 for qemu-devel@nongnu.org; Thu, 23 Mar 2017 05:22:30 -0400 Received: by mail-wm0-x242.google.com with SMTP id n11so15234265wma.0 for ; Thu, 23 Mar 2017 02:22:30 -0700 (PDT) Received: from bark.daynix ([141.226.163.173]) by smtp.gmail.com with ESMTPSA id h16sm5062319wrc.5.2017.03.23.02.22.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Mar 2017 02:22:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=zQnaXmX4R58UEGy31D878tacD1DA6bziRX4JJzj2PLk=; b=x/fmsEWK1CC1kY1o/b75W1I0baygPQuWqBAmo7K7grrl55sg4JI1I9tn/Z8w3eIMl7 EYmpm4Y0QtoIpmfeegd1aooKI/HgQsgIiBD2OT0/snvaOhDudeH0cAlnYfWPB4lrOUbi konV48ctm/DxNwbc6Ii/c+THJFIUgD/SgJYYvsfRe7cncvhb9TRYZgAcRmL91HK639gZ bztamdU3hy7Hj1b61w/RHLtzTJBEvqItsFhATag9YGAXYLaqpFxAzoyVaYtmcN7dkdFO NQ6Xsdc8jMO0kYlwOomiZp+Va0nBtzKh/Ge6NhpLdC5/ehrNivKiprWFCPttDyBKDOPx Yz7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=zQnaXmX4R58UEGy31D878tacD1DA6bziRX4JJzj2PLk=; b=M5IzTg/7yx9XOWOS/c7zuzdZQEg5vOzSfxLkQISFDYuJuR8UllJwTpD/PsOHwMlVLe rdVEohrNhMLy3mEcz7dTqCRj+voq8Lpnjeim9J4/KL/t79OVGpm8X8v0kuMWvW5OKW3Z fm0NoX7WpxTamW6s0qJ8MW2s9o7pwWYnxVmxSK8IyaJlOXonMPoO8BL9qOkx5719cLve drYAYmG9IFtdXXIulvF8rXbseewoZ4FF55kRDq3ZdXTi3aPC3u5JSnUiuaf2HW0u6jc3 /ye9hr9qhDrbkdxGiwNoTqSVK5pNOrnfhk66pe+7eHJzLc8Dx5cHLlUin1YTga7khgII A0Tw== X-Gm-Message-State: AFeK/H1b1Se7t8jWFFZ3drEI0F7CWPd59DL3tQbbHsPjyiog8gOWG2x/VjvZwGRWOVVdPA== X-Received: by 10.28.170.206 with SMTP id t197mr1863099wme.61.1490260949293; Thu, 23 Mar 2017 02:22:29 -0700 (PDT) From: Sameeh Jubran To: qemu-devel@nongnu.org, Michael Roth Date: Thu, 23 Mar 2017 11:22:11 +0200 Message-Id: <20170323092211.29990-1-sameeh@daynix.com> X-Mailer: git-send-email 2.9.3 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::242 Subject: [Qemu-devel] [PATCH qemu-ga v2] qga: Make qemu-ga compile statically for Windows X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yan Vugenfirer , Stefan Hajnoczi , Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Attempting to compile qemu-ga statically as follows for Windows causes the following error: Compilation: ./configure --disable-docs --target-list=3Dx86_64-softmmu \ --cross-prefix=3Dx86_64-w64-mingw32- --static \ --enable-guest-agent-msi --with-vss-sdk=3D/path/to/VSSSDK72 make -j8 qemu-ga Error: path/to/qemu/stubs/error-printf.c:7: undefined reference to `__imp_g_te= st_config_vars' collect2: error: ld returned 1 exit status Makefile:444: recipe for target 'qemu-ga.exe' failed make: *** [qemu-ga.exe] Error 1 This is caused by a bug in the pkg-config file for glib as it doesn't define GLIB_STATIC_COMPILATION for pkg-config --static. Signed-off-by: Stefan Hajnoczi Signed-off-by: Sameeh Jubran Reviewed-by: Stefan Hajnoczi --- configure | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/configure b/configure index b9a30cf..8210494 100755 --- a/configure +++ b/configure @@ -3041,6 +3041,13 @@ if test "$modules" =3D yes; then glib_modules=3D"$glib_modules gmodule-2.0" fi =20 +# This workaround is required due to a bug in pkg-config file for glib as = it +# doesn't define GLIB_STATIC_COMPILATION for pkg-config --static + +if test "$static" =3D yes -a "$mingw32" =3D yes; then + QEMU_CFLAGS=3D"-DGLIB_STATIC_COMPILATION $QEMU_CFLAGS" +fi + for i in $glib_modules; do if $pkg_config --atleast-version=3D$glib_req_ver $i; then glib_cflags=3D$($pkg_config --cflags $i) --=20 2.9.3