From nobody Fri May 3 09:26:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1490215856411256.6503079478995; Wed, 22 Mar 2017 13:50:56 -0700 (PDT) Received: from localhost ([::1]:53239 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cqnDb-00052z-31 for importer@patchew.org; Wed, 22 Mar 2017 16:50:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cqnC1-0003uY-3g for qemu-devel@nongnu.org; Wed, 22 Mar 2017 16:49:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cqnC0-0000UG-6u for qemu-devel@nongnu.org; Wed, 22 Mar 2017 16:49:17 -0400 Received: from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:34127) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cqnC0-0000UC-2f; Wed, 22 Mar 2017 16:49:16 -0400 Received: by mail-qt0-x244.google.com with SMTP id x35so26891985qtc.1; Wed, 22 Mar 2017 13:49:15 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id u43sm1767263qtc.11.2017.03.22.13.49.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Mar 2017 13:49:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LIMA2wvKe270j63sGVKHnGpcmb+TjhsBtlsud8HbtA8=; b=fi0XQnp+ywGZ3nbakOCGELXyXWCFWqDsSp1dJPzvtXNWqcRODNvvfyqae6gx7Zc9TV rlIyL4u9Pn7sOWTq/RZ1300HECJIEcDs91zLanV5VsYXelOlTCFo1XKMXdYcTJo2m8x1 lsZ3d+KraQ5+KBFLlMx3qXMsO9lUhqd8kSyKU6LuN0OukCBYvirbZTdPDC7QYSTAALdE M22Xp2x9oH9toRAY0b9ruTq5a8NvRR+UlPLi3fkXzb90eQ31o4Bp2OlgU0SoSzbBsDeI BcDitmfoPRDyeeTkw7BuazTSYqrit3Zy+VhuCESOZsx1gPIe6WvF1UxYwNoZCtD7FW9B 1FAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=LIMA2wvKe270j63sGVKHnGpcmb+TjhsBtlsud8HbtA8=; b=d9jE5RqgQQOnhjl+yODaKu62G3gsYIaxEKNA9+goG6ATw/iMVs/oGAgiGaNdDwWt5r T1pnn9wgdjNAjRIbkUAzmC1r6kNvS39KfmX9mqJzvXiv+VoWYIoFBd2E25iatCw6Bx1H fEgOdhi/vhApmOtCcKVe/V2jf6mpIVG3JFRds0HJx4GXSpeLbeVxl9tuIq+WpLq2SFWh uuNydBjl2BtmSiW08alcsN6SmDXd/V76JwEJ11gGYiFMhcqWx5FQ1zjbvyrzfO1Bsjhb sAQXRRM6L44QpLOMcLjCvtgfWJZlIpgxLxhJUpdltmwUS/F1aSFkkzYZ+0Ux7GEn8f75 Pj1A== X-Gm-Message-State: AFeK/H06/U/bssJgFMavLkJcQKKaA1HrpogFGWy9BHVWENlYccJ6+wERHqHM7c8nU3QIjQ== X-Received: by 10.237.35.83 with SMTP id i19mr39424459qtc.70.1490215754472; Wed, 22 Mar 2017 13:49:14 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Michael Roth , Peter Crosthwaite , Alexander Graf , Gerd Hoffmann Date: Wed, 22 Mar 2017 17:48:42 -0300 Message-Id: <20170322204844.446-2-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170322204844.446-1-f4bug@amsat.org> References: <20170322204844.446-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c0d::244 Subject: [Qemu-devel] [PATCH RESEND 1/3] usb-ccid: make ccid_write_data_block() cope with null buffers X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RSF_0 Z_629925259 SPT_0 static code analyzer complain: hw/usb/dev-smartcard-reader.c:816:5: warning: Null pointer passed as an arg= ument to a 'nonnull' parameter memcpy(p->abData, data, len); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- hw/usb/dev-smartcard-reader.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c index 757b8b3f5a..c38a4e5886 100644 --- a/hw/usb/dev-smartcard-reader.c +++ b/hw/usb/dev-smartcard-reader.c @@ -799,8 +799,14 @@ static void ccid_write_parameters(USBCCIDState *s, CCI= D_Header *recv) static void ccid_write_data_block(USBCCIDState *s, uint8_t slot, uint8_t s= eq, const uint8_t *data, uint32_t len) { - CCID_DataBlock *p =3D ccid_reserve_recv_buf(s, sizeof(*p) + len); + CCID_DataBlock *p; =20 + if (len =3D=3D 0) { + return; + } + g_assert(data !=3D NULL); + + p =3D ccid_reserve_recv_buf(s, sizeof(*p) + len); if (p =3D=3D NULL) { return; } --=20 2.11.0 From nobody Fri May 3 09:26:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1490215849096958.7092159487623; Wed, 22 Mar 2017 13:50:49 -0700 (PDT) Received: from localhost ([::1]:53238 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cqnDT-0004yB-Rx for importer@patchew.org; Wed, 22 Mar 2017 16:50:47 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49498) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cqnC5-0003xl-Bi for qemu-devel@nongnu.org; Wed, 22 Mar 2017 16:49:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cqnC4-0000Wh-EX for qemu-devel@nongnu.org; Wed, 22 Mar 2017 16:49:21 -0400 Received: from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:32944) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cqnC4-0000Wb-AV; Wed, 22 Mar 2017 16:49:20 -0400 Received: by mail-qt0-x243.google.com with SMTP id r45so26852597qte.0; Wed, 22 Mar 2017 13:49:20 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id u43sm1767263qtc.11.2017.03.22.13.49.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Mar 2017 13:49:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SqjCnCGnucxBra+5LhiSayVshgbtJGEVJX9iVTpgv6Y=; b=LSB+F7lNdHazkvvNi5CQ1OmFGw5fqQj52+qK+kjHtBuHQ149GNuqRZD1YejwIE78pk 2ziSA6DkkRn64iUd/Tu/ElUTuK4z0+vGGTX1ZCY2YBWtkDM+WStAdB/BPUSdP8bblz6b qK7eSXYQ6iozSk2PLJSb3qvNvPhEzceJTS87JalZpb4DnN3Y1stD65KI72WJOibjut7T BNQA29wCIalzUIz2rjjvvzqfoj6GeXk3+221+/+Nb+TQI1de4O13kmyXn+6Hk1T7JHDr fJa3fDwEmZNBoh4udegVTHnDzgHKJyoEaTbWFEmoNrES74TEmNSpxbSoZSRWGadnt5n8 3zKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=SqjCnCGnucxBra+5LhiSayVshgbtJGEVJX9iVTpgv6Y=; b=V3xTlq1pXfnWvhk897iw4N5uNEO7lL8WLpAlSsRdpf9TzormpBlscb72HXKEIKo0jt gulyfndeaLOhy+a/XIIVk57e2ryY2cxDqg2AbHGgpQbd1Zii8rMDxfZXOQTJUq5N4SaH S/1elMKDwQwKPQvX2Zue77zvf/KeCFdV3iQdXi6p1t7+ais9NgtoaADQ8h4gstFlqfAz fef3E9jpPTBK7C/G+0MlwMrzFUugme9PBb9R9MyuXEtcMywriAhobeSAZZTBQqwbASOj Fn2p9SOrnU9ihSguRhrjZjz1JtjwpGMS6HqSq0DM4fdHQ3cyP0jZerQrmrWl2Ixf3RSk bgOA== X-Gm-Message-State: AFeK/H1/ZYShVCG1iV3BRD044lh1UhoAxg734vr87JgrOGAhkKOt7wfPIaJj1aqKjm+/1Q== X-Received: by 10.200.50.231 with SMTP id a36mr43312296qtb.156.1490215759571; Wed, 22 Mar 2017 13:49:19 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Michael Roth , Peter Crosthwaite , Alexander Graf , Gerd Hoffmann Date: Wed, 22 Mar 2017 17:48:43 -0300 Message-Id: <20170322204844.446-3-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170322204844.446-1-f4bug@amsat.org> References: <20170322204844.446-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c0d::243 Subject: [Qemu-devel] [PATCH RESEND 2/3] device_tree: fix compiler warnings (clang 5) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RSF_0 Z_629925259 SPT_0 static code analyzer complain: device_tree.c:155:18: warning: Null pointer passed as an argument to a 'non= null' parameter while ((de =3D readdir(d)) !=3D NULL) { ^~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- device_tree.c | 1 + 1 file changed, 1 insertion(+) diff --git a/device_tree.c b/device_tree.c index 6e06320830..a24ddff02b 100644 --- a/device_tree.c +++ b/device_tree.c @@ -148,6 +148,7 @@ static void read_fstree(void *fdt, const char *dirname) d =3D opendir(dirname); if (!d) { error_setg(&error_fatal, "%s cannot open %s", __func__, dirname); + return; } =20 while ((de =3D readdir(d)) !=3D NULL) { --=20 2.11.0 From nobody Fri May 3 09:26:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1490215945885474.6940863478643; Wed, 22 Mar 2017 13:52:25 -0700 (PDT) Received: from localhost ([::1]:53246 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cqnF1-00067A-Dd for importer@patchew.org; Wed, 22 Mar 2017 16:52:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49543) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cqnC8-00040m-NM for qemu-devel@nongnu.org; Wed, 22 Mar 2017 16:49:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cqnC7-0000YA-Qw for qemu-devel@nongnu.org; Wed, 22 Mar 2017 16:49:24 -0400 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:36458) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cqnC7-0000Xf-Lt; Wed, 22 Mar 2017 16:49:23 -0400 Received: by mail-qt0-x241.google.com with SMTP id n37so26892215qtb.3; Wed, 22 Mar 2017 13:49:23 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id u43sm1767263qtc.11.2017.03.22.13.49.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Mar 2017 13:49:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VOX8vCm02+TZHvHjc4PaeSf5kYt386OJ030cl11LrV0=; b=oa+4Vyw3j8AZtOtJKwNpuKnenNELoo9HP3cmyBKa59NR0TbQbehKPcfpQwTsK+PKUX 8zBYelkgjzSWQqUqsqhDVNppRiHtR/2nAp02uKSo0iodz9khvDAHYIRiF15tcyCEvl8p Q1PHN3pIKKfd8qR0rtLV4GgUTXA/Fxk4zLXWZK6RBlekx9rPYkSbrqC16FqEpJPbdPBo kxXXY4Ryki2p0w4/JCyydeFFfWyzyyGpVuNswWCn5XZWxqKJCeaTZAoPrCJKn8IE921k hVo8JpJRbiT/cWWzx+cpdrwI7mx4mzP12P8qA6JpdQ3+wRkoMe5AaC9lYsPZCHn+0Jdn mt4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=VOX8vCm02+TZHvHjc4PaeSf5kYt386OJ030cl11LrV0=; b=c1aJbmZkV5lz1EzZZ1raxFi1aaImFRESSGaHcLMW3lul3m2b2p6kbzTtH03thmXwl4 uP9f7EYgG/MZIG6VMk6TlRIjBTitfVnREtFBItMnjk/a/bybidenf3eHjb0XwgUNI/DH dDu51PbDDaUUj74jHtDdE4OtrQKxs2Te6b1oQUHQJP671cuRjiTu00qwqObJ/m/5gX5p 1uhMKCLdQCAvlD0sfCQkyo8nwWXatsShq2/NTwLNbwUOOGh7PRcmLrt46GFzoOqbPm0G 9DK+BnlivcaohXmtGuzoaFjH/kzsVWJrlXjkGfu3lAJnuQp6JKrvY4sL4LHpyGHOEYV9 tobA== X-Gm-Message-State: AFeK/H1Vrf8WP2d7Xm43M75Z5vQpYTU4RQspb09H2NHtdCocPz0GlCH5NKmkbihHl/UP4w== X-Received: by 10.237.37.229 with SMTP id y34mr40264128qtc.30.1490215762956; Wed, 22 Mar 2017 13:49:22 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Michael Roth , Peter Crosthwaite , Alexander Graf , Gerd Hoffmann Date: Wed, 22 Mar 2017 17:48:44 -0300 Message-Id: <20170322204844.446-4-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170322204844.446-1-f4bug@amsat.org> References: <20170322204844.446-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c0d::241 Subject: [Qemu-devel] [PATCH RESEND 3/3] qga: fix compiler warnings (clang 5) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RSF_0 Z_629925259 SPT_0 static code analyzer complain: qga/commands-posix.c:2127:9: warning: Null pointer passed as an argument to= a 'nonnull' parameter closedir(dp); ^~~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- qga/commands-posix.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 73d93eb5ce..8028141534 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -2122,9 +2122,11 @@ static void transfer_memory_block(GuestMemoryBlock *= mem_blk, bool sys2memblk, * we think this VM does not support online/offline memory block, * any other solution? */ - if (!dp && errno =3D=3D ENOENT) { - result->response =3D - GUEST_MEMORY_BLOCK_RESPONSE_TYPE_OPERATION_NOT_SUPPORTED; + if (!dp) { + if (errno =3D=3D ENOENT) { + result->response =3D + GUEST_MEMORY_BLOCK_RESPONSE_TYPE_OPERATION_NOT_SUPPORT= ED; + } goto out1; } closedir(dp); --=20 2.11.0