From nobody Sat Apr 27 14:02:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1490197683958512.1443103053409; Wed, 22 Mar 2017 08:48:03 -0700 (PDT) Received: from localhost ([::1]:51711 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cqiUT-0004Bt-G9 for importer@patchew.org; Wed, 22 Mar 2017 11:48:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cqiTT-0003hA-Is for qemu-devel@nongnu.org; Wed, 22 Mar 2017 11:47:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cqiTP-0001PR-Pl for qemu-devel@nongnu.org; Wed, 22 Mar 2017 11:46:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60742) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cqiTP-0001P6-Jp; Wed, 22 Mar 2017 11:46:55 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1CA104DD7C; Wed, 22 Mar 2017 15:46:55 +0000 (UTC) Received: from evilvm.brq.redhat.com (dhcp131-51.brq.redhat.com [10.34.131.51]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1CFA27E626; Wed, 22 Mar 2017 15:46:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1CA104DD7C Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=vfeenstr@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1CA104DD7C From: Vinzenz 'evilissimo' Feenstra To: qemu-devel@nongnu.org Date: Wed, 22 Mar 2017 16:46:49 +0100 Message-Id: <20170322154649.6947-1-vfeenstr@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 22 Mar 2017 15:46:55 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] qga: Add `guest-get-timezone` command X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, Vinzenz Feenstra Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Vinzenz Feenstra Adds a new command `guest-get-timezone` reporting the currently configured timezone on the system. The information on what timezone is currently is configured is useful in case of Windows VMs where the offset of the hardware clock is required to have the same offset. This can be used for management systems like `oVirt` to detect the timezone difference and warn administrators of the misconfiguration. Signed-off-by: Vinzenz Feenstra Reviewed-by: Eric Blake --- qga/commands.c | 19 +++++++++++++++++++ qga/qapi-schema.json | 25 +++++++++++++++++++++++++ 2 files changed, 44 insertions(+) diff --git a/qga/commands.c b/qga/commands.c index 4d92946..83d7f99 100644 --- a/qga/commands.c +++ b/qga/commands.c @@ -499,3 +499,22 @@ int ga_parse_whence(GuestFileWhence *whence, Error **e= rrp) error_setg(errp, "invalid whence code %"PRId64, whence->u.value); return -1; } + +GuestTimezone *qmp_guest_get_timezone(Error **errp) +{ + GuestTimezone *info =3D g_new0(GuestTimezone, 1); + GTimeZone *tz =3D g_time_zone_new_local(); + gint32 interval =3D g_time_zone_find_interval(tz, G_TIME_TYPE_STANDARD= , 0); + gchar const *name =3D g_time_zone_get_abbreviation(tz, interval); + if (name !=3D NULL) { + info->offset =3D g_time_zone_get_offset(tz, interval) / 60; + info->zone =3D g_strdup(name); + } else { + error_setg(errp, "Timezone lookup failed"); + g_free(info); + info =3D NULL; + } + g_time_zone_unref(tz); + return info; +} + diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index a02dbf2..6683aae 100644 --- a/qga/qapi-schema.json +++ b/qga/qapi-schema.json @@ -1042,3 +1042,28 @@ 'data': { 'path': 'str', '*arg': ['str'], '*env': ['str'], '*input-data': 'str', '*capture-output': 'bool' }, 'returns': 'GuestExec' } + + +## +# @GuestTimezone: +# +# @zone: Timezone name +# @offset: Offset to UTC in minutes +# +# Since: 2.10 +## +{ 'struct': 'GuestTimezone', + 'data': { 'zone': 'str', 'offset': 'int' } } + + +## +# @guest-get-timezone: +# +# Retrieves the timezone information from the guest. +# +# Returns: The guest timezone GuestTimezone information on success. +# +# Since: 2.10 +## +{ 'command': 'guest-get-timezone', + 'returns': 'GuestTimezone' } --=20 2.9.3