From nobody Sun May 5 21:19:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1486573615831578.2698872376467; Wed, 8 Feb 2017 09:06:55 -0800 (PST) Received: from localhost ([::1]:60615 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbVhm-0003c1-1C for importer@patchew.org; Wed, 08 Feb 2017 12:06:54 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38148) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbVgY-00033V-OH for qemu-devel@nongnu.org; Wed, 08 Feb 2017 12:05:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cbVgW-0005v8-4C for qemu-devel@nongnu.org; Wed, 08 Feb 2017 12:05:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47676) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cbVgV-0005uk-Uy; Wed, 08 Feb 2017 12:05:36 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 37719C05AA59; Wed, 8 Feb 2017 17:05:35 +0000 (UTC) Received: from scv.usersys.redhat.com (vpn-58-133.rdu2.redhat.com [10.10.58.133]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v18H5Y4v026637; Wed, 8 Feb 2017 12:05:34 -0500 From: John Snow To: qemu-trivial@nongnu.org Date: Wed, 8 Feb 2017 12:05:33 -0500 Message-Id: <20170208170533.28822-1-jsnow@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 08 Feb 2017 17:05:35 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] ide: remove undefined behavior in ide-test X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, John Snow , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" trivial: initialize the dirty buffer with a random-ish byte. Stops valgrind from whining about uninitialized buffers. Signed-off-by: John Snow Reviewed-by: Stefan Hajnoczi --- tests/ide-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/ide-test.c b/tests/ide-test.c index 2fa97bc..139ebc0 100644 --- a/tests/ide-test.c +++ b/tests/ide-test.c @@ -550,6 +550,7 @@ static void make_dirty(uint8_t device) =20 guest_buf =3D guest_alloc(guest_malloc, len); buf =3D g_malloc(len); + memset(buf, rand() % 255 + 1, len); g_assert(guest_buf); g_assert(buf); =20 --=20 2.9.3