From nobody Fri May 3 17:04:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1486435264413457.5275562472541; Mon, 6 Feb 2017 18:41:04 -0800 (PST) Received: from localhost ([::1]:51670 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1caviH-00013d-Sr for importer@patchew.org; Mon, 06 Feb 2017 21:41:01 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48323) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cavaT-0003L2-HK for qemu-devel@nongnu.org; Mon, 06 Feb 2017 21:32:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cavaS-0005Qq-Ko for qemu-devel@nongnu.org; Mon, 06 Feb 2017 21:32:57 -0500 Received: from mail-it0-x244.google.com ([2607:f8b0:4001:c0b::244]:33663) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cavaS-0005QY-HE for qemu-devel@nongnu.org; Mon, 06 Feb 2017 21:32:56 -0500 Received: by mail-it0-x244.google.com with SMTP id e137so10948591itc.0 for ; Mon, 06 Feb 2017 18:32:56 -0800 (PST) Received: from bigtime.twiddle.net.twiddle.net (m865036d0.tmodns.net. [208.54.80.134]) by smtp.gmail.com with ESMTPSA id n67sm5316037ith.0.2017.02.06.18.32.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Feb 2017 18:32:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=RPY7qEmM7Pey3KWxsKHnkNcM1Uzi1Y8D+zOA5r5Kfog=; b=b+AEPHbcE6AcUOBv5iIytGxzIm6KSZokF9QFPBgZep6lm6cec6LKcvL4s3SNo70Pi9 6juhYxR94tsucWY5cA8BIYijDQOPlcwKPGLDhnN7V1YjSfKVqwUZY67NDj9itAE5R+6D +6nMSKaajbkjjzuEfDHZ4OyT5waHbqva2aFviIfZNdsn0zyWnwmzbQbtVi12CJvjIauZ 64XCUt7VhyLK5/dFQ5wU78AFbnMKF2wWRVSBykkRhkqGaR/nggb8dOl8Q2nSdk5+xQbq MGC3dBmhCikcE4rNFR+x3HWaG56GpjuOy0ddKz+EFMWXu6UJwVuqgfaRWqQaiMTQklbG 3jEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=RPY7qEmM7Pey3KWxsKHnkNcM1Uzi1Y8D+zOA5r5Kfog=; b=lYkTITDFBmGLJC3/NFrbRaKwdchBAJh+30bwCuffh+hDIoY2oK17Mn9HBeiPs8DZMS 7BIlpmUgQmj/AH5210RHd5MN+VAfiUt++lx7lMwy1T7KZKcjsdRApzxkEQyL8QyunPab L9q6wLMp7b2gINJvVhIBivlBsUuwUSYJfkpeQIoKI0e6opWNtfPqf59xwtBdBvk+Z7WJ hWAPomexIxeAMFEDm8z+E3ruxedz2OuhCjLVzeper8ox+3F88S6HttBq6T4eW+PPhaIM 6quXgP2ZCEHbw3givpnVZAdXjb4YyDeA4b72th0iZ9lDwzWigIB7556F3Di1edqaSmcp GaBg== X-Gm-Message-State: AIkVDXIu8MKpZNYgsK6F1upWXROnF7wXVNYPv3CzLl9zB+v42RxE425Lf2Hiw89isisMDg== X-Received: by 10.36.217.150 with SMTP id p144mr10294583itg.90.1486434775779; Mon, 06 Feb 2017 18:32:55 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 6 Feb 2017 18:32:25 -0800 Message-Id: <20170207023229.29431-2-rth@twiddle.net> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170207023229.29431-1-rth@twiddle.net> References: <20170207023229.29431-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4001:c0b::244 Subject: [Qemu-devel] [PULL 1/5] linux-user: add hppa magic numbers in qemu-binfmt-conf.sh X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Laurent Vivier Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Laurent Vivier As we have now a linux-user HPPA target, we can add it to the list of supported targets in qemu-binfmt-conf.sh Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Message-Id: <20170126080449.28255-2-laurent@vivier.eu> Signed-off-by: Richard Henderson --- scripts/qemu-binfmt-conf.sh | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh index de4d1c1..0f1aa63 100755 --- a/scripts/qemu-binfmt-conf.sh +++ b/scripts/qemu-binfmt-conf.sh @@ -1,9 +1,10 @@ #!/bin/sh -# enable automatic i386/ARM/M68K/MIPS/SPARC/PPC/s390 program execution by = the kernel +# enable automatic i386/ARM/M68K/MIPS/SPARC/PPC/s390/HPPA +# program execution by the kernel =20 qemu_target_list=3D"i386 i486 alpha arm sparc32plus ppc ppc64 ppc64le m68k= \ mips mipsel mipsn32 mipsn32el mips64 mips64el \ -sh4 sh4eb s390x aarch64" +sh4 sh4eb s390x aarch64 hppa" =20 i386_magic=3D'\x7fELF\x01\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\= x00\x03\x00' i386_mask=3D'\xff\xff\xff\xff\xff\xfe\xfe\xff\xff\xff\xff\xff\xff\xff\xff\= xff\xfe\xff\xff\xff' @@ -91,6 +92,10 @@ aarch64_magic=3D'\x7fELF\x02\x01\x01\x00\x00\x00\x00\x00= \x00\x00\x00\x00\x02\x00\x aarch64_mask=3D'\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\x= ff\xff\xfe\xff\xff\xff' aarch64_family=3Darm =20 +hppa_magic=3D'\x7f\x45\x4c\x46\x01\x02\x01\x00\x00\x00\x00\x00\x00\x00\x00= \x00\x00\x02\x00\x0f' +hppa_mask=3D'\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\= xff\xff\xfe\xff\xff' +hppa_family=3Dhppa + qemu_get_family() { cpu=3D${HOST_ARCH:-$(uname -m)} case "$cpu" in --=20 2.9.3 From nobody Fri May 3 17:04:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 14864348981390.25011607599594754; Mon, 6 Feb 2017 18:34:58 -0800 (PST) Received: from localhost ([::1]:51632 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cavcO-0004LN-Ct for importer@patchew.org; Mon, 06 Feb 2017 21:34:56 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48361) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cavab-0003OY-GK for qemu-devel@nongnu.org; Mon, 06 Feb 2017 21:33:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cavaY-0005T6-To for qemu-devel@nongnu.org; Mon, 06 Feb 2017 21:33:05 -0500 Received: from mail-io0-x242.google.com ([2607:f8b0:4001:c06::242]:34493) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cavaY-0005Sv-PM for qemu-devel@nongnu.org; Mon, 06 Feb 2017 21:33:02 -0500 Received: by mail-io0-x242.google.com with SMTP id c80so11559311iod.1 for ; Mon, 06 Feb 2017 18:33:02 -0800 (PST) Received: from bigtime.twiddle.net.twiddle.net (m865036d0.tmodns.net. [208.54.80.134]) by smtp.gmail.com with ESMTPSA id n67sm5316037ith.0.2017.02.06.18.32.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Feb 2017 18:33:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=PGlOm2bmaHWGcr9L7Wq4zN8IRf969KlwQOW1fMbYuz0=; b=rMk/9paCyMpB06Ko6brZwBruikAz7eerFKHA6Yw87StCGWAZOUOyZrgMhI/sJGQ4kL A8uHKwB3MyI1xVAXkyoR26AeHT+45p8VWfPGhS9xbOXi2u0s3ExJZxE+FdyaxKm+NYim xqMEWdEwEis73KZA9BvBre1V+9YJlSdr2CIasBe1/rMZzhMtgrgwchF+44WSms7KprCh YRY3x+50ciTQdY9VRZ5Ha1ZNzyyQRqlUJrbb6u++4kmpwDk4MWJanJUwIOELgf/AtOvx L4oMRPWG9xJpUm32IG8LNLdOm6425Ggza1zusEBI4FuWVrnZ7xg9S2EWVIdxmGEMF2zG ksGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=PGlOm2bmaHWGcr9L7Wq4zN8IRf969KlwQOW1fMbYuz0=; b=HMbcAZHOCtdS7dNWm/DFxetrVcUJmdyjuekI0ixqfXRY4405Y9GeNIAi5xfe9jz5+s zo+udHAhFxVDb18lbNHabqt5+gckbBuX586eqHQQ58IredTMnQK9ftWInFFrpnmBbmkT Lp1v5sLeOW1mY1XoiETzb7+NFMO/5bB5iywLLrJ0+t6bx+lw08F6m23pe2o1pKn5+2RV ky2DSywHNwlXJHaWoUK1SQwMvKA38SzJSuFWJmjGqh4XbkQTiGIhfj3ZHaPy8+ycwQMn sRQvzZPpr4IJQjrIeEGMWIgkt9bbZ6hG5J2Sthm+SROwjsJhdoGtA+eLbzRRQG8OGJdP 9S5Q== X-Gm-Message-State: AMke39kvneCG6BnGucQZ7UpEARaAijJ8tie8gBUKaKGlY5R5Yb75tEbYPB2KrCw7HF4U3w== X-Received: by 10.107.185.212 with SMTP id j203mr2736161iof.226.1486434782131; Mon, 06 Feb 2017 18:33:02 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 6 Feb 2017 18:32:26 -0800 Message-Id: <20170207023229.29431-3-rth@twiddle.net> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170207023229.29431-1-rth@twiddle.net> References: <20170207023229.29431-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4001:c06::242 Subject: [Qemu-devel] [PULL 2/5] linux-user: fix "apt-get update" on linux-user hppa X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Laurent Vivier Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Laurent Vivier apt-get was hanging on linux-user hppa. strace has shown the netlink data stream was not correctly byte swapped. It appears the fd translator function is unregistered just after it has been registered, so the translator function is not called. This patch removes the fd_trans_unregister() after the do_socket() in the TARGET_NR_socket case. This fd_trans_unregister() was added by commit e36800c linux-user: add signalfd/signalfd4 syscalls when do_socket() was not registering any fd translator. And as now it is, we must remove this fd_trans_unregister() to keep them. Reported-by: John Paul Adrian Glaubitz Signed-off-by: Laurent Vivier Tested-by: John Paul Adrian Glaubitz Message-Id: <20170126080449.28255-3-laurent@vivier.eu> Signed-off-by: Richard Henderson --- linux-user/syscall.c | 1 - 1 file changed, 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 11a311f..9be8e95 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -9343,7 +9343,6 @@ abi_long do_syscall(void *cpu_env, int num, abi_long = arg1, #ifdef TARGET_NR_socket case TARGET_NR_socket: ret =3D do_socket(arg1, arg2, arg3); - fd_trans_unregister(ret); break; #endif #ifdef TARGET_NR_socketpair --=20 2.9.3 From nobody Fri May 3 17:04:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1486435140046952.6477786660286; Mon, 6 Feb 2017 18:39:00 -0800 (PST) Received: from localhost ([::1]:51657 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cavgI-0007hR-OO for importer@patchew.org; Mon, 06 Feb 2017 21:38:58 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cavaf-0003R0-Mm for qemu-devel@nongnu.org; Mon, 06 Feb 2017 21:33:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cavaf-0005Ub-07 for qemu-devel@nongnu.org; Mon, 06 Feb 2017 21:33:09 -0500 Received: from mail-io0-x243.google.com ([2607:f8b0:4001:c06::243]:34924) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cavae-0005UU-SX for qemu-devel@nongnu.org; Mon, 06 Feb 2017 21:33:08 -0500 Received: by mail-io0-x243.google.com with SMTP id m98so11535577iod.2 for ; Mon, 06 Feb 2017 18:33:08 -0800 (PST) Received: from bigtime.twiddle.net.twiddle.net (m865036d0.tmodns.net. [208.54.80.134]) by smtp.gmail.com with ESMTPSA id n67sm5316037ith.0.2017.02.06.18.33.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Feb 2017 18:33:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=9iUC5yJXT1ExOKRpk4CBiXO+ugrWX/Zqh4gCw5p9R/g=; b=sAeoZwUe0N8dOgnDUDcCcPrEpbxD6S7Oy0IApcwpX29uLyUuNcfo/oC3Qdc0tZXoox 17ERCT9rtnxUvHxTVpY6W714T/Z38gdVyNC7veeeaVEVScusCpg2VBXHjmvPCodwAAdx qrpjKXJ6fDhjW+cyDPFUdEqaetW4TeClsfS/UB5TycpHR0JC8JVYTw+QxFTc9vaYT/NU dDwK7GJb0cEeoTmmitfFgdDsU7arTnmYBxZGP/Skc5/CQzDYwEB/8Eww0aTU3oDdAPGd qHOoZYAqlc+DGCHQH/olYJvzvvrxjyBCpZQ+yyoSR5bd/iZOSJCa7RRjxEddtYlhCK93 ASfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=9iUC5yJXT1ExOKRpk4CBiXO+ugrWX/Zqh4gCw5p9R/g=; b=kbiTzfGx4x2sofFFfs2AbaJ9OOCDy5cN5trZJeu3vZ87d8EwaaWxRYRCdUjpzZRbRh z7iplLNwH07WTVv9LR8vdvdAr3lOkAoqEFoXOMiuZXBct0vRKdwxWFfoKFWvph/qNb7+ b5uWUvAZ2gQ+AVPmpCNJEm7cJcNTIcs5oWKPke+C9tTqy9Rb+D62+aNrSOwKTQL3Xswh j+hoMOMJt7Zi8JRCrq9lWYWfiU0ZGF2xUQChFvjjDlTLT001qTg8t525oY3gMUXeCI4k WElrHvDsGMJ9uV22wYeHbyb0JbUz6H3R8UAeY9HIt7PhB+L0s1r/wv6xU9WxDC1MbTbE Lo7g== X-Gm-Message-State: AMke39mDvaIFcGGtkBF67yxCejHQ2V+iFxW4x5D7sWAkk081f3kgikaBZa8KQBC91iD4Lg== X-Received: by 10.107.132.153 with SMTP id o25mr2542095ioi.192.1486434788290; Mon, 06 Feb 2017 18:33:08 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 6 Feb 2017 18:32:27 -0800 Message-Id: <20170207023229.29431-4-rth@twiddle.net> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170207023229.29431-1-rth@twiddle.net> References: <20170207023229.29431-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4001:c06::243 Subject: [Qemu-devel] [PULL 3/5] linux-user: define correct UTS machine name for hppa X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Laurent Vivier Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Laurent Vivier the correct UTS machine name (as expected by systemd) is "parisc", not "hppa". Signed-off-by: Laurent Vivier Message-Id: <20170126080449.28255-4-laurent@vivier.eu> Signed-off-by: Richard Henderson --- linux-user/hppa/target_syscall.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/hppa/target_syscall.h b/linux-user/hppa/target_sysc= all.h index ac18a9c..e2f3668 100644 --- a/linux-user/hppa/target_syscall.h +++ b/linux-user/hppa/target_syscall.h @@ -19,7 +19,7 @@ struct target_pt_regs { target_ulong ipsw; }; =20 -#define UNAME_MACHINE "hppa" +#define UNAME_MACHINE "parisc" #define UNAME_MINIMUM_RELEASE "2.6.32" #define TARGET_CLONE_BACKWARDS #define TARGET_MINSIGSTKSZ 2048 --=20 2.9.3 From nobody Fri May 3 17:04:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1486434916846407.181439566521; Mon, 6 Feb 2017 18:35:16 -0800 (PST) Received: from localhost ([::1]:51633 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cavcg-0004Xb-MC for importer@patchew.org; Mon, 06 Feb 2017 21:35:14 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cavao-0003WO-4h for qemu-devel@nongnu.org; Mon, 06 Feb 2017 21:33:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1caval-0005X3-IJ for qemu-devel@nongnu.org; Mon, 06 Feb 2017 21:33:18 -0500 Received: from mail-it0-x243.google.com ([2607:f8b0:4001:c0b::243]:34655) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1caval-0005Wt-DZ for qemu-devel@nongnu.org; Mon, 06 Feb 2017 21:33:15 -0500 Received: by mail-it0-x243.google.com with SMTP id o185so10989079itb.1 for ; Mon, 06 Feb 2017 18:33:15 -0800 (PST) Received: from bigtime.twiddle.net.twiddle.net (m865036d0.tmodns.net. [208.54.80.134]) by smtp.gmail.com with ESMTPSA id n67sm5316037ith.0.2017.02.06.18.33.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Feb 2017 18:33:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=JHUHkIua3h717kllChKoK6ut8SblYYK0ZdQE8kL95Zc=; b=Uqvpt0fIB5hGnafSdtgaWKpU8IBHgfUAacrAOr+SlbTh/Mfo1ynfNe1gZzLtT6nx4R 4WdUxxlwEAlWL8eT3rJ54Lb6ea8x2l2fIAWhbgOjrBxloMs/sL/+rvpnrihzfqEtQYX0 KJeCXxhbL/05Ym8IzkF3dHYslDnsyecNmtycbSrXcaYUOBRxftkV8hxXp9Uqoyv4Z+EP kvPg449weZffRBqetnZYpVIcvl3YUhc6Su61jiyrALKnCFYOpaTT5ia9W1aKTscqzkba vqXiytnhPlpXyPuSS9BKwEeZXF+6oYbfO1SptgMjMCAtwdMY5b6pLxjYpWZiJj65UmUK Z8nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=JHUHkIua3h717kllChKoK6ut8SblYYK0ZdQE8kL95Zc=; b=g0Ii+7bcNHjFf1vWKsTA93PZalDqIbNhV57M4nuF6Rko3NbinqG1jZjH7v3EmMCMlX 4sCBehQCj88i5awh2DL6Khzwjlefn6mAoRpPXLZUEcxQ1pm1oCC6hn0Bz3qKCUFjRJOe mUXJTYBa6AIgcGLSoxqLjWO8mklhzyugjDE7yHWwJbjplIQjiqw9yHWRTX9qs+9iZ2Zg MOkbDH6wIKFsAQSnl98fPGn6R08isCYEguOYADuBtP7EhJBzLEW/PSTRoE/tzOj47CNx sz237gPTsbLPlFU50aVdFQV4q+3giYifGuseP9I1m2hDB/BDVfOI4YCk/OBN45TLS9PH IojQ== X-Gm-Message-State: AIkVDXLVIV34CxiOFP6FDGdMmyZkY8KU1T/sJkEdWgrVDqlyAR1jmLC1m1hwhhnmuexsrA== X-Received: by 10.36.43.194 with SMTP id h185mr10507212ita.121.1486434794769; Mon, 06 Feb 2017 18:33:14 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 6 Feb 2017 18:32:28 -0800 Message-Id: <20170207023229.29431-5-rth@twiddle.net> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170207023229.29431-1-rth@twiddle.net> References: <20170207023229.29431-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4001:c0b::243 Subject: [Qemu-devel] [PULL 4/5] target/hppa: Tidy do_cbranch X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Removes some dead code detected by Covarity. Reported-by: Paolo Bonzini Signed-off-by: Richard Henderson --- target/hppa/translate.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 4d243f7..5d571f0 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -1433,7 +1433,6 @@ static ExitStatus do_cbranch(DisasContext *ctx, targe= t_long disp, bool is_n, target_ulong dest =3D iaoq_dest(ctx, disp); TCGLabel *taken =3D NULL; TCGCond c =3D cond->c; - int which =3D 0; bool n; =20 assert(ctx->null_cond.c =3D=3D TCG_COND_NEVER); @@ -1455,14 +1454,14 @@ static ExitStatus do_cbranch(DisasContext *ctx, tar= get_long disp, bool is_n, n =3D is_n && disp < 0; if (n && use_nullify_skip(ctx)) { nullify_set(ctx, 0); - gen_goto_tb(ctx, which++, ctx->iaoq_n, ctx->iaoq_n + 4); + gen_goto_tb(ctx, 0, ctx->iaoq_n, ctx->iaoq_n + 4); } else { if (!n && ctx->null_lab) { gen_set_label(ctx->null_lab); ctx->null_lab =3D NULL; } nullify_set(ctx, n); - gen_goto_tb(ctx, which++, ctx->iaoq_b, ctx->iaoq_n); + gen_goto_tb(ctx, 0, ctx->iaoq_b, ctx->iaoq_n); } =20 gen_set_label(taken); @@ -1471,23 +1470,17 @@ static ExitStatus do_cbranch(DisasContext *ctx, tar= get_long disp, bool is_n, n =3D is_n && disp >=3D 0; if (n && use_nullify_skip(ctx)) { nullify_set(ctx, 0); - gen_goto_tb(ctx, which++, dest, dest + 4); + gen_goto_tb(ctx, 1, dest, dest + 4); } else { nullify_set(ctx, n); - gen_goto_tb(ctx, which++, ctx->iaoq_b, dest); + gen_goto_tb(ctx, 1, ctx->iaoq_b, dest); } =20 /* Not taken: the branch itself was nullified. */ if (ctx->null_lab) { gen_set_label(ctx->null_lab); ctx->null_lab =3D NULL; - if (which < 2) { - nullify_set(ctx, 0); - gen_goto_tb(ctx, which, ctx->iaoq_b, ctx->iaoq_n); - return EXIT_GOTO_TB; - } else { - return EXIT_IAQ_N_STALE; - } + return EXIT_IAQ_N_STALE; } else { return EXIT_GOTO_TB; } --=20 2.9.3 From nobody Fri May 3 17:04:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1486435159628558.3142467875834; Mon, 6 Feb 2017 18:39:19 -0800 (PST) Received: from localhost ([::1]:51658 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cavgc-0007z6-B2 for importer@patchew.org; Mon, 06 Feb 2017 21:39:18 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cavar-0003Yr-IM for qemu-devel@nongnu.org; Mon, 06 Feb 2017 21:33:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cavaq-0005Y0-N5 for qemu-devel@nongnu.org; Mon, 06 Feb 2017 21:33:21 -0500 Received: from mail-it0-x241.google.com ([2607:f8b0:4001:c0b::241]:34889) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cavaq-0005Xr-Je for qemu-devel@nongnu.org; Mon, 06 Feb 2017 21:33:20 -0500 Received: by mail-it0-x241.google.com with SMTP id 203so10997371ith.2 for ; Mon, 06 Feb 2017 18:33:20 -0800 (PST) Received: from bigtime.twiddle.net.twiddle.net (m865036d0.tmodns.net. [208.54.80.134]) by smtp.gmail.com with ESMTPSA id n67sm5316037ith.0.2017.02.06.18.33.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Feb 2017 18:33:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=fcermWxJwgKuXHtXtIkwAPb0ookZCVq0N8urVkUKPPQ=; b=FcNpGSitdLmR0z0R/aB1jErc0n2FwZnB9gU+EvPgjPhyeQwGFEdMLd2sJ6gYUkFN5U TqJJ3FkKq8i6dcbmTx1lEmvT2Ne2HdiWn3rnH+bETHGa5Ov3oQojcwceeFAP/eblyrNw 1f1J2FxgQ0emw/hlW9m5F/RO1GDv2hZ+Lwf5ATjhzBeMmv2jOoeyYZWH/vPOPJzFgmtI QGCA3CwFBFkVLn4mA+NYfilvxPzB3ribxeKw2TNrcXC1nyiNRovmDVleiygqWiTi9J7W em3awJeMhudW+vRhJ6hIRoKJTl6JtZG+l16fvfddS9oMMH5w5TZPzZRvXsRqUkWf2m+U 9lBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=fcermWxJwgKuXHtXtIkwAPb0ookZCVq0N8urVkUKPPQ=; b=tDCvviOCosIHC4KtMYmU/JWieJKDvotHmv6gbwHuuZ7ik3tkww3P46/XlCL48vi5vZ 53f6IS1geZEAmBiLqR5dEsQes/9c8+aD985Y5NgGVU97/RURjWBL5deyMCHPntHFvpLJ oBFLOquE2Nbx1li+CRrCaP3xBnkdaJAOxFNJz8+IcK9u+LwigJ2ZJiAJYioPgjxBgjru SBzt7/0gzWnlEwyIob/IL14zKdwfljTbeGZdxlNrchFqXN73seD9K+1GEG1EdadQFWli 2DsPdMV7nHroHB1ZG4CMY1Gp/aM/Oo2C0NgYeYFfAjqPza9X8erCWiipSSaKAyo6GcZY U4FQ== X-Gm-Message-State: AIkVDXKIoUpumgWBPQ4Xi0nnyTnpOvBYrLCTxq0prBxa/ymHXHcYuG2wq3B+5m2cMQ3leA== X-Received: by 10.36.5.67 with SMTP id 64mr10383694itl.97.1486434799967; Mon, 06 Feb 2017 18:33:19 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 6 Feb 2017 18:32:29 -0800 Message-Id: <20170207023229.29431-6-rth@twiddle.net> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170207023229.29431-1-rth@twiddle.net> References: <20170207023229.29431-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4001:c0b::241 Subject: [Qemu-devel] [PULL 5/5] target/hppa: Fix gdb_write_register X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Add a missing break, detected by Coverity. Reported-by: Peter Maydell Signed-off-by: Richard Henderson --- target/hppa/gdbstub.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/hppa/gdbstub.c b/target/hppa/gdbstub.c index 413a5e1..c37a56f 100644 --- a/target/hppa/gdbstub.c +++ b/target/hppa/gdbstub.c @@ -85,6 +85,7 @@ int hppa_cpu_gdb_write_register(CPUState *cs, uint8_t *me= m_buf, int n) break; case 35: env->iaoq_b =3D val; + break; case 59: env->cr26 =3D val; break; --=20 2.9.3