From nobody Mon Apr 29 10:54:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1486387780630757.8464416258466; Mon, 6 Feb 2017 05:29:40 -0800 (PST) Received: from localhost ([::1]:47540 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cajMR-0007ar-0t for importer@patchew.org; Mon, 06 Feb 2017 08:29:39 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cajLe-0007Jc-0h for qemu-devel@nongnu.org; Mon, 06 Feb 2017 08:28:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cajLa-0003L1-Ni for qemu-devel@nongnu.org; Mon, 06 Feb 2017 08:28:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44478) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cajLa-0003KY-J2 for qemu-devel@nongnu.org; Mon, 06 Feb 2017 08:28:46 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A5F57C057FAC for ; Mon, 6 Feb 2017 13:28:45 +0000 (UTC) Received: from localhost (ovpn-116-23.phx2.redhat.com [10.3.116.23]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v16DSgFh004414; Mon, 6 Feb 2017 08:28:44 -0500 From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= To: qemu-devel@nongnu.org Date: Mon, 6 Feb 2017 17:28:35 +0400 Message-Id: <20170206132835.9440-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 06 Feb 2017 13:28:45 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] qemu-option: reject empty number value X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" When no number is provided, return an invalid number error. (note: this may break some users relying on default 0 value) Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=3D1417864 Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Eric Blake --- util/qemu-option.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/qemu-option.c b/util/qemu-option.c index 3467dc2397..89afa4b2c3 100644 --- a/util/qemu-option.c +++ b/util/qemu-option.c @@ -150,7 +150,7 @@ static void parse_option_number(const char *name, const= char *value, =20 if (value !=3D NULL) { number =3D strtoull(value, &postfix, 0); - if (*postfix !=3D '\0') { + if (*postfix !=3D '\0' || postfix =3D=3D value) { error_setg(errp, QERR_INVALID_PARAMETER_VALUE, name, "a number= "); return; } --=20 2.11.0.295.gd7dffce1c.dirty