[Qemu-devel] [PATCH] qemu-option: reject empty number value

Marc-André Lureau posted 1 patch 7 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170206132835.9440-1-marcandre.lureau@redhat.com
Test checkpatch passed
Test docker passed
Test s390x passed
util/qemu-option.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[Qemu-devel] [PATCH] qemu-option: reject empty number value
Posted by Marc-André Lureau 7 years, 1 month ago
When no number is provided, return an invalid number error.
(note: this may break some users relying on default 0 value)

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1417864

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 util/qemu-option.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/qemu-option.c b/util/qemu-option.c
index 3467dc2397..89afa4b2c3 100644
--- a/util/qemu-option.c
+++ b/util/qemu-option.c
@@ -150,7 +150,7 @@ static void parse_option_number(const char *name, const char *value,
 
     if (value != NULL) {
         number = strtoull(value, &postfix, 0);
-        if (*postfix != '\0') {
+        if (*postfix != '\0' || postfix == value) {
             error_setg(errp, QERR_INVALID_PARAMETER_VALUE, name, "a number");
             return;
         }
-- 
2.11.0.295.gd7dffce1c.dirty


Re: [Qemu-devel] [PATCH] qemu-option: reject empty number value
Posted by Eric Blake 7 years, 1 month ago
On 02/06/2017 07:28 AM, Marc-André Lureau wrote:
> When no number is provided, return an invalid number error.
> (note: this may break some users relying on default 0 value)

Anyone that writes 'size=' instead of 'size=0' deserves the breakage.

> 
> Fixes:
> https://bugzilla.redhat.com/show_bug.cgi?id=1417864
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  util/qemu-option.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org