From nobody Mon Apr 29 09:33:11 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1486381443465704.2342058300658; Mon, 6 Feb 2017 03:44:03 -0800 (PST) Received: from localhost ([::1]:46833 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cahiE-00067T-7n for importer@patchew.org; Mon, 06 Feb 2017 06:44:02 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43632) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cahUj-0003TC-6D for qemu-devel@nongnu.org; Mon, 06 Feb 2017 06:30:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cahUf-0003NL-96 for qemu-devel@nongnu.org; Mon, 06 Feb 2017 06:30:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35836) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cahUf-0003N2-3w for qemu-devel@nongnu.org; Mon, 06 Feb 2017 06:30:01 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 494A8C04D2A8; Mon, 6 Feb 2017 11:30:01 +0000 (UTC) Received: from t460.redhat.com (ovpn-116-59.ams2.redhat.com [10.36.116.59]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v16BTuDM031284; Mon, 6 Feb 2017 06:29:57 -0500 From: "Daniel P. Berrange" To: qemu-devel@nongnu.org Date: Mon, 6 Feb 2017 11:29:53 +0000 Message-Id: <20170206112953.16993-1-berrange@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 06 Feb 2017 11:30:01 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] rules: don't try to create missing include dirs X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Alberto Garcia , Stefan Hajnoczi Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" In commit ba78db44f6532d66a1e704bd44613e841baa2fc5 Author: Daniel P. Berrange Date: Wed Jan 25 16:14:10 2017 +0000 make: move top level dir to end of include search path The dir $(BUILD_DIR)/$(@D) was added to the include path. This would sometimes point to a non-existant directory, if the sub-dir in question did not contain any target-independant files (eg tcg/). To deal with this the rules.mak attempted to create the directory. While this was succesful, it also caused accidental creation of files in the parent of the build dir. e.g. when building common source files into target specific output files. Rather than trying to workaround this, just revert the code that attempted to mkdir the missing include directories. Instead just turn off the compiler warning in question as the missing dir is expected & harmless in general. Signed-off-by: Daniel P. Berrange Reviewed-by: Stefan Hajnoczi Tested-by: Alberto Garcia --- configure | 2 +- rules.mak | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index 86fd833..6325339 100755 --- a/configure +++ b/configure @@ -1474,7 +1474,7 @@ fi =20 gcc_flags=3D"-Wold-style-declaration -Wold-style-definition -Wtype-limits" gcc_flags=3D"-Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifie= rs $gcc_flags" -gcc_flags=3D"-Wmissing-include-dirs -Wempty-body -Wnested-externs $gcc_fla= gs" +gcc_flags=3D"-Wno-missing-include-dirs -Wempty-body -Wnested-externs $gcc_= flags" gcc_flags=3D"-Wendif-labels -Wno-shift-negative-value $gcc_flags" gcc_flags=3D"-Wno-initializer-overrides $gcc_flags" gcc_flags=3D"-Wno-string-plus-int $gcc_flags" diff --git a/rules.mak b/rules.mak index 575a3af..83d6dd1 100644 --- a/rules.mak +++ b/rules.mak @@ -374,7 +374,6 @@ define unnest-vars $(eval $(o:%.mo=3D%$(DSOSUF)): module-common.o $($o-objs)), $(error $o added in $v but $o-objs is not set))) $(shell mkdir -p ./ $(sort $(dir $($v)))) - $(shell cd $(BUILD_DIR) && mkdir -p ./ $(sort $(dir $($v)))) # Include all the .d files $(eval -include $(patsubst %.o,%.d,$(patsubst %.mo,%.d,$($v)))) $(eval $v :=3D $(filter-out %/,$($v)))) --=20 2.9.3