The following changes since commit a951316b8a5c3c63254f20a826afeed940dd4cba:

  Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2017-02-03 14:41:49 +0000)

are available in the git repository at:

  git://github.com/dgibson/qemu.git tags/isa-cleanup-20170206

for you to fetch changes up to c124c4d13bcb19fc866e7f6de075f906fca6af4a:

  Split ISA and sysbus versions of m48t59 device (2017-02-06 12:33:21 +1100)

----------------------------------------------------------------
Allow ISA to be disabled on some platforms (v3)

This makes some cleanups that are a start on allowing ISA to be
compiled out for platforms which don't use it.

I posted this series last November, and it collected a number of R-bs
and no apparent objections.  So, I've now rebased it (trivially) and
am sending a pull request in the hopes of merge.  A lot of the pieces
here don't have a clear maintainer, so I'm sending it directly to
Peter.

Notes:
  * Patch 3/3 triggers a style warning, but that's just because I'm
    moving a C++ // comment verbatim from one file to another

Changes since v2:
  * Trivial rebase

Changes since v1:
  * Fixed some silly compile errors in 3/3 exposed by some
    changes in other headers

----------------------------------------------------------------
David Gibson (3):
      Split serial-isa into its own config option
      Allow ISA bus to be configured out
      Split ISA and sysbus versions of m48t59 device

 default-configs/alpha-softmmu.mak       |   1 +
 default-configs/arm-softmmu.mak         |   1 +
 default-configs/i386-softmmu.mak        |   1 +
 default-configs/mips-softmmu-common.mak |   1 +
 default-configs/moxie-softmmu.mak       |   2 +
 default-configs/pci.mak                 |   3 +
 default-configs/ppc-softmmu.mak         |   1 +
 default-configs/ppc64-softmmu.mak       |   1 +
 default-configs/ppcemb-softmmu.mak      |   1 +
 default-configs/sh4-softmmu.mak         |   1 +
 default-configs/sh4eb-softmmu.mak       |   1 +
 default-configs/sparc-softmmu.mak       |   1 +
 default-configs/sparc64-softmmu.mak     |   1 +
 default-configs/unicore32-softmmu.mak   |   1 +
 default-configs/x86_64-softmmu.mak      |   1 +
 hw/char/Makefile.objs                   |   3 +-
 hw/isa/Makefile.objs                    |   2 +-
 hw/timer/Makefile.objs                  |   3 +
 hw/timer/m48t59-internal.h              |  82 ++++++++++++
 hw/timer/m48t59-isa.c                   | 181 +++++++++++++++++++++++++
 hw/timer/m48t59.c                       | 228 +++-----------------------------
 21 files changed, 305 insertions(+), 212 deletions(-)
 create mode 100644 hw/timer/m48t59-internal.h
 create mode 100644 hw/timer/m48t59-isa.c

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PULL 0/3] isa-cleanup queue 20170206
Message-id: 20170206013927.13693-1-david@gibson.dropbear.id.au

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/1486110164-13797-1-git-send-email-peterx@redhat.com -> patchew/1486110164-13797-1-git-send-email-peterx@redhat.com
 - [tag update]      patchew/1486144722-6021-1-git-send-email-peter.maydell@linaro.org -> patchew/1486144722-6021-1-git-send-email-peter.maydell@linaro.org
 - [tag update]      patchew/1486148371-11692-1-git-send-email-peter.maydell@linaro.org -> patchew/1486148371-11692-1-git-send-email-peter.maydell@linaro.org
 - [tag update]      patchew/1486249533-5260-1-git-send-email-peter.maydell@linaro.org -> patchew/1486249533-5260-1-git-send-email-peter.maydell@linaro.org
 - [tag update]      patchew/20170123123056.30383-1-famz@redhat.com -> patchew/20170123123056.30383-1-famz@redhat.com
 - [tag update]      patchew/20170203170729.12399-1-pbonzini@redhat.com -> patchew/20170203170729.12399-1-pbonzini@redhat.com
 * [new tag]         patchew/20170206013927.13693-1-david@gibson.dropbear.id.au -> patchew/20170206013927.13693-1-david@gibson.dropbear.id.au
Switched to a new branch 'test'
55da952 Split ISA and sysbus versions of m48t59 device
b58cd33 Allow ISA bus to be configured out
0782c85 Split serial-isa into its own config option

=== OUTPUT BEGIN ===
Checking PATCH 1/3: Split serial-isa into its own config option...
Checking PATCH 2/3: Allow ISA bus to be configured out...
Checking PATCH 3/3: Split ISA and sysbus versions of m48t59 device...
ERROR: do not use C99 // comments
#67: FILE: hw/timer/m48t59-internal.h:28:
+//#define DEBUG_NVRAM

total: 1 errors, 0 warnings, 614 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org

On 6 February 2017 at 01:39, David Gibson <david@gibson.dropbear.id.au> wrote:
> The following changes since commit a951316b8a5c3c63254f20a826afeed940dd4cba:
>
>   Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2017-02-03 14:41:49 +0000)
>
> are available in the git repository at:
>
>   git://github.com/dgibson/qemu.git tags/isa-cleanup-20170206
>
> for you to fetch changes up to c124c4d13bcb19fc866e7f6de075f906fca6af4a:
>
>   Split ISA and sysbus versions of m48t59 device (2017-02-06 12:33:21 +1100)
>
> ----------------------------------------------------------------
> Allow ISA to be disabled on some platforms (v3)
>
> This makes some cleanups that are a start on allowing ISA to be
> compiled out for platforms which don't use it.
>
> I posted this series last November, and it collected a number of R-bs
> and no apparent objections.  So, I've now rebased it (trivially) and
> am sending a pull request in the hopes of merge.  A lot of the pieces
> here don't have a clear maintainer, so I'm sending it directly to
> Peter.
>
> Notes:
>   * Patch 3/3 triggers a style warning, but that's just because I'm
>     moving a C++ // comment verbatim from one file to another
>
> Changes since v2:
>   * Trivial rebase
>
> Changes since v1:
>   * Fixed some silly compile errors in 3/3 exposed by some
>     changes in other headers

I think one or two platforms have appeared since (notably
nios) but they don't need CONFIG_SERIAL_ISA so that's ok.

Applied, thanks.

-- PMM