virtio-net VMState conversion and new VMSTATE macros

[Qemu-devel] [PATCH 0/4] virtio-net VMState conversion and new VMSTATE macros

Dr. David Alan Gilbert (git) posted 4 patches 7 years, 2 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170203160651.19917-1-dgilbert@redhat.com

Test checkpatch passed

Test docker passed

Test s390x failed

hw/net/virtio-net.c            | 316 +++++++++++++++++++++++++++--------------
include/hw/virtio/virtio-net.h |   4 +-
include/migration/vmstate.h    |  30 ++++
migration/vmstate.c            |  40 ++++++
tests/test-vmstate.c           |  98 ++++++++++++-
5 files changed, 375 insertions(+), 113 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH 0/4] virtio-net VMState conversion and new VMSTATE macros

Posted by Dr. David Alan Gilbert (git) 7 years, 2 months ago

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

Hi,
  This set converts the virtio-net device to VMState;
it uses a couple of new VMSTATE macros I've added, of which
the VMSTATE_WITH_TMP is a bit unusual, but is intended for dealing
with migration data that doesn't quite look like the data structure
we have in memory.

Dave


Dr. David Alan Gilbert (4):
  migration: Add VMSTATE_UNUSED_VARRAY_UINT32
  migration: Add VMSTATE_WITH_TMP
  tests/migration: Add test for VMSTATE_WITH_TMP
  virtio/migration: Migrate virtio-net to VMState

 hw/net/virtio-net.c            | 316 +++++++++++++++++++++++++++--------------
 include/hw/virtio/virtio-net.h |   4 +-
 include/migration/vmstate.h    |  30 ++++
 migration/vmstate.c            |  40 ++++++
 tests/test-vmstate.c           |  98 ++++++++++++-
 5 files changed, 375 insertions(+), 113 deletions(-)

-- 
2.9.3

Re: [Qemu-devel] [PATCH 0/4] virtio-net VMState conversion and new VMSTATE macros

Posted by Michael S. Tsirkin 7 years, 2 months ago

On Fri, Feb 03, 2017 at 04:06:47PM +0000, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> 
> Hi,
>   This set converts the virtio-net device to VMState;
> it uses a couple of new VMSTATE macros I've added, of which
> the VMSTATE_WITH_TMP is a bit unusual, but is intended for dealing
> with migration data that doesn't quite look like the data structure
> we have in memory.
> 
> Dave


Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

> 
> Dr. David Alan Gilbert (4):
>   migration: Add VMSTATE_UNUSED_VARRAY_UINT32
>   migration: Add VMSTATE_WITH_TMP
>   tests/migration: Add test for VMSTATE_WITH_TMP
>   virtio/migration: Migrate virtio-net to VMState
> 
>  hw/net/virtio-net.c            | 316 +++++++++++++++++++++++++++--------------
>  include/hw/virtio/virtio-net.h |   4 +-
>  include/migration/vmstate.h    |  30 ++++
>  migration/vmstate.c            |  40 ++++++
>  tests/test-vmstate.c           |  98 ++++++++++++-
>  5 files changed, 375 insertions(+), 113 deletions(-)
> 
> -- 
> 2.9.3

Re: [Qemu-devel] [PATCH 0/4] virtio-net VMState conversion and new VMSTATE macros

Posted by Dr. David Alan Gilbert 7 years, 2 months ago

* Dr. David Alan Gilbert (git) (dgilbert@redhat.com) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> 
> Hi,
>   This set converts the virtio-net device to VMState;
> it uses a couple of new VMSTATE macros I've added, of which
> the VMSTATE_WITH_TMP is a bit unusual, but is intended for dealing
> with migration data that doesn't quite look like the data structure
> we have in memory.
> 
> Dave

Queued.


> 
> 
> Dr. David Alan Gilbert (4):
>   migration: Add VMSTATE_UNUSED_VARRAY_UINT32
>   migration: Add VMSTATE_WITH_TMP
>   tests/migration: Add test for VMSTATE_WITH_TMP
>   virtio/migration: Migrate virtio-net to VMState
> 
>  hw/net/virtio-net.c            | 316 +++++++++++++++++++++++++++--------------
>  include/hw/virtio/virtio-net.h |   4 +-
>  include/migration/vmstate.h    |  30 ++++
>  migration/vmstate.c            |  40 ++++++
>  tests/test-vmstate.c           |  98 ++++++++++++-
>  5 files changed, 375 insertions(+), 113 deletions(-)
> 
> -- 
> 2.9.3
> 
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK