[PATCH V4 00/11] fix migration of suspended runstate

Steve Sistare posted 11 patches 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1693333086-392798-1-git-send-email-steven.sistare@oracle.com
Maintainers: Stefan Berger <stefanb@linux.vnet.ibm.com>, "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Gerd Hoffmann <kraxel@redhat.com>, Stefano Stabellini <sstabellini@kernel.org>, Anthony Perard <anthony.perard@citrix.com>, Paul Durrant <paul@xen.org>, Paolo Bonzini <pbonzini@redhat.com>, Juan Quintela <quintela@redhat.com>, Peter Xu <peterx@redhat.com>, Leonardo Bras <leobras@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Thomas Huth <thuth@redhat.com>, Laurent Vivier <lvivier@redhat.com>
There is a newer version of this series
backends/tpm/tpm_emulator.c          |   2 +-
gdbstub/softmmu.c                    |   2 +-
hw/usb/hcd-ehci.c                    |   2 +-
hw/usb/redirect.c                    |   2 +-
hw/xen/xen-hvm-common.c              |   2 +-
include/sysemu/runstate.h            |   3 +-
migration/migration.c                |  49 +++++-----
migration/migration.h                |   1 +
migration/savevm.c                   |   9 +-
softmmu/cpu-timers.c                 |  36 ++++++-
softmmu/cpus.c                       |   8 +-
softmmu/runstate.c                   |   3 +
tests/migration/i386/Makefile        |   5 +-
tests/migration/i386/a-b-bootblock.S |  51 +++++++++-
tests/migration/i386/a-b-bootblock.h |  22 +++--
tests/qtest/migration-helpers.c      |  27 ++----
tests/qtest/migration-helpers.h      |   9 +-
tests/qtest/migration-test.c         | 178 +++++++++++++++++++++++++++--------
18 files changed, 299 insertions(+), 112 deletions(-)
[PATCH V4 00/11] fix migration of suspended runstate
Posted by Steve Sistare 8 months ago
Migration of a guest in the suspended runstate is broken.  The incoming
migration code automatically tries to wake the guest, which is wrong;
the guest should end migration in the same runstate it started.  Further,
for a restored snapshot, the automatic wakeup fails.  The runstate is
RUNNING, but the guest is not.  See the commit messages for the details.

Changes in V2:
  * simplify "start on wakeup request"
  * fix postcopy, snapshot, and background migration
  * refactor fixes for each type of migration
  * explicitly handled suspended events and runstate in tests
  * add test for postcopy and background migration

Changes in V3:
  * rebase to tip
  * fix hang in new function migrate_wait_for_dirty_mem

Changes in V4:
  * rebase to tip
  * add patch for vm_prepare_start (thanks Peter)
  * add patch to preserve cpu ticks

Steve Sistare (11):
  cpus: pass runstate to vm_prepare_start
  migration: preserve suspended runstate
  migration: add runstate function
  migration: preserve suspended for snapshot
  migration: preserve suspended for bg_migration
  migration: preserve cpu ticks if suspended
  tests/qtest: migration events
  tests/qtest: option to suspend during migration
  tests/qtest: precopy migration with suspend
  tests/qtest: postcopy migration with suspend
  tests/qtest: background migration with suspend

 backends/tpm/tpm_emulator.c          |   2 +-
 gdbstub/softmmu.c                    |   2 +-
 hw/usb/hcd-ehci.c                    |   2 +-
 hw/usb/redirect.c                    |   2 +-
 hw/xen/xen-hvm-common.c              |   2 +-
 include/sysemu/runstate.h            |   3 +-
 migration/migration.c                |  49 +++++-----
 migration/migration.h                |   1 +
 migration/savevm.c                   |   9 +-
 softmmu/cpu-timers.c                 |  36 ++++++-
 softmmu/cpus.c                       |   8 +-
 softmmu/runstate.c                   |   3 +
 tests/migration/i386/Makefile        |   5 +-
 tests/migration/i386/a-b-bootblock.S |  51 +++++++++-
 tests/migration/i386/a-b-bootblock.h |  22 +++--
 tests/qtest/migration-helpers.c      |  27 ++----
 tests/qtest/migration-helpers.h      |   9 +-
 tests/qtest/migration-test.c         | 178 +++++++++++++++++++++++++++--------
 18 files changed, 299 insertions(+), 112 deletions(-)

-- 
1.8.3.1