[v1] target/riscv/cpu.c: Fix elen check

[PATCH qemu] target/riscv/cpu.c: Fix elen check

~elta posted 1 patch 1 year, 4 months ago

Diff against v1 v1 v1 v1
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/167236721596.15277.2653405273227256289-0@git.sr.ht

Maintainers: Palmer Dabbelt <palmer@dabbelt.com>, Alistair Francis <alistair.francis@wdc.com>, Bin Meng <bin.meng@windriver.com>

There is a newer version of this series

target/riscv/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH qemu] target/riscv/cpu.c: Fix elen check

Posted by ~elta 1 year, 4 months ago

From: Dongxue Zhang <elta.era@gmail.com>

Should be cpu->cfg.elen in range [8, 64].

Signed-off-by: Dongxue Zhang <elta.era@gmail.com>
Reviewed-by: LIU Zhiwei <zhiwe_liu@linux.alibaba.com>
Message-ID: <bcdd7992-e3ff-de17-22c4-1319e3816e8b@linux.alibaba.com>
Reviewed-by: Frank Chang <frank.chang@sifive.com>
Message-ID: <CANzO1D0du4TSza=-bnqZ+N9cGVfZ6P4xwYaiJg6doTzo7_MdYg@mail.gmail.com>
---
 target/riscv/cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index 6fe176e483..5dc51f7912 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@ -872,7 +872,7 @@ static void riscv_cpu_realize(DeviceState *dev, Error **errp)
                         "Vector extension ELEN must be power of 2");
                 return;
             }
-            if (cpu->cfg.elen > 64 || cpu->cfg.vlen < 8) {
+            if (cpu->cfg.elen > 64 || cpu->cfg.elen < 8) {
                 error_setg(errp,
                         "Vector extension implementation only supports ELEN "
                         "in the range [8, 64]");
-- 
2.34.5

Re: [PATCH qemu] target/riscv/cpu.c: Fix elen check

Posted by Alistair Francis 1 year, 3 months ago

On Fri, Dec 30, 2022 at 12:26 PM ~elta <elta@git.sr.ht> wrote:
>
> From: Dongxue Zhang <elta.era@gmail.com>
>
> Should be cpu->cfg.elen in range [8, 64].
>
> Signed-off-by: Dongxue Zhang <elta.era@gmail.com>
> Reviewed-by: LIU Zhiwei <zhiwe_liu@linux.alibaba.com>
> Message-ID: <bcdd7992-e3ff-de17-22c4-1319e3816e8b@linux.alibaba.com>
> Reviewed-by: Frank Chang <frank.chang@sifive.com>
> Message-ID: <CANzO1D0du4TSza=-bnqZ+N9cGVfZ6P4xwYaiJg6doTzo7_MdYg@mail.gmail.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Thanks!

Applied to riscv-to-apply.next

Alistair

> ---
>  target/riscv/cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index 6fe176e483..5dc51f7912 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -872,7 +872,7 @@ static void riscv_cpu_realize(DeviceState *dev, Error **errp)
>                          "Vector extension ELEN must be power of 2");
>                  return;
>              }
> -            if (cpu->cfg.elen > 64 || cpu->cfg.vlen < 8) {
> +            if (cpu->cfg.elen > 64 || cpu->cfg.elen < 8) {
>                  error_setg(errp,
>                          "Vector extension implementation only supports ELEN "
>                          "in the range [8, 64]");
> --
> 2.34.5