From nobody Sat Apr 20 03:26:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1531190766053578.8716887744582; Mon, 9 Jul 2018 19:46:06 -0700 (PDT) Received: from localhost ([::1]:45499 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcifA-0004dR-D9 for importer@patchew.org; Mon, 09 Jul 2018 22:46:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60848) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcidu-000490-3f for qemu-devel@nongnu.org; Mon, 09 Jul 2018 22:44:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fcidq-0008Nk-5V for qemu-devel@nongnu.org; Mon, 09 Jul 2018 22:44:42 -0400 Received: from mail.loongson.cn ([114.242.206.163]:47205) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcidp-0008Fa-Ev for qemu-devel@nongnu.org; Mon, 09 Jul 2018 22:44:38 -0400 Received: from martinqiao.loongson.cn (unknown [10.50.122.95]) by mail (Coremail) with SMTP id QMiowPAx+OFpHERblDWRAA--.3945S2; Tue, 10 Jul 2018 10:39:44 +0800 (CST) From: QiaoChong To: qemu-devel@nongnu.org Date: Tue, 10 Jul 2018 10:44:21 +0800 Message-Id: <1531190661-19327-1-git-send-email-qiaochong@loongson.cn> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: QMiowPAx+OFpHERblDWRAA--.3945S2 X-Coremail-Antispam: 1UD129KBjvJXoWxZw1fuF1UGF4UJF18AF43ZFb_yoWrWr15pF 9Iq3Zakr4Yqw1UZr48K3sruF1rCa4DKrZI9rZFkr4v9r1Sqa42vrs2vFyUXw47CFWUJr1x uFyUKr4rtFn8XaUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkv14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr 1j6F4UJwAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv 7VC0I7IYx2IY67AKxVWUGVWUXwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r 1j6r4UM4x0Y48IcxkI7VAKI48JM4x0Y48IcxkI7VAKI48G6xCjnVAKz4kxM4x0x7Aq67II x4CEVc8vx2IErcIFxwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s 026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_ Jrv_JF1lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr 0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6Fyj6rWUJwCI42IY6I8E87Iv67AKxVWUJVW8JwCI 42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x0JUha93UUUUU= X-CM-SenderInfo: 5tld0upkrqwqxorr0wxvrqhubq/ X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 114.242.206.163 Subject: [Qemu-devel] [PATCH] make pci_bridge_region_cleanup to be done in rcu queue after flatview_destroy. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qiaochong@loongson.cn Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" pci_bridge_region_cleanup need to done after flatview_destroy, because memory_region_unref need access memory regions in PCIBridgeWindows = in flatview_destroy. here we delay pci_bridge_region_cleanup to be done in rcu queue work. bellow are gdb backtraces. oldcode mr->name will be freed in object_unparent, before flatview_destroy. mask=3D, attrs=3D...) at /work/work/loongson/qemu/qemu-l= atest/memory.c:559 access_size_min=3D, access_size_max=3D, a= ccess_fn=3D0x555555876850 , mr=3D0x5555569608c0, attrs=3D...) at /work/work/loongson/qemu/qemu-late= st/memory.c:626 at /work/work/loongson/qemu/qemu-latest/memory.c:1518 buf=3Dbuf@entry=3D0x7fffbff0ae40 "", len=3Dlen@entry=3D4, addr1=3D4, l= =3D4, mr=3D0x5555569608c0) at /work/work/loongson/qemu/qemu-latest/exec.c:3= 255 at /work/work/loongson/qemu/qemu-latest/exec.c:3294 at /work/work/loongson/qemu/qemu-latest/exec.c:2910 shift=3D, mask=3D, attrs=3D...) at /work/= work/loongson/qemu/qemu-latest/memory.c:585 access_size_min=3D, access_size_max=3D, a= ccess_fn=3D0x555555874700 , mr=3D0x555557338120, attrs=3D...) at /work/work/loongson/qemu/qemu-late= st/memory.c:626 size=3Dsize@entry=3D4, attrs=3D...) at /work/work/loongson/qemu/qemu-la= test/memory.c:1518 val=3Dval@entry=3D44040192, addr=3Daddr@entry=3D18446744072502722564, r= etaddr=3Dretaddr@entry=3D140736012783717, recheck=3Dfalse, size=3D4) at /work/work/loongson/qemu/qemu-latest/accel/tcg/cputlb.c:905 mmu_idx=3D, env=3D0x55555681d218) at /work/work/loongson= /qemu/qemu-latest/accel/tcg/softmmu_template.h:268 at /work/work/loongson/qemu/qemu-latest/accel/tcg/softmmu_template.h:304 at /work/work/loongson/qemu/qemu-latest/accel/tcg/cpu-exec.c:171 at /work/work/loongson/qemu/qemu-latest/accel/tcg/cpu-exec.c:612 here mr mr->owner, mr->name has been freed in object_unparent before. void memory_region_unref(MemoryRegion *mr) { if (mr && mr->owner) { object_unref(mr->owner); } } Signed-off-by: QiaoChong --- hw/pci/pci_bridge.c | 12 +++++++++++- include/hw/pci/pci_bridge.h | 1 + 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c index 40a39f5..a3c9501 100644 --- a/hw/pci/pci_bridge.c +++ b/hw/pci/pci_bridge.c @@ -233,6 +233,16 @@ static void pci_bridge_region_cleanup(PCIBridge *br, P= CIBridgeWindows *w) g_free(w); } =20 +/* +pci_bridge_region_cleanup need to done after flatview_destroy, +because memory_region_unref need access memory regions in PCIBridgeWindows= in flatview_destroy. +here we delay pci_bridge_region_cleanup to be done in rcu queue work. +*/ +static void pci_bridge_region_cleanup_schedule(PCIBridgeWindows *w) +{ + pci_bridge_region_cleanup(NULL, w); +} + void pci_bridge_update_mappings(PCIBridge *br) { PCIBridgeWindows *w =3D br->windows; @@ -243,7 +253,7 @@ void pci_bridge_update_mappings(PCIBridge *br) pci_bridge_region_del(br, br->windows); br->windows =3D pci_bridge_region_init(br); memory_region_transaction_commit(); - pci_bridge_region_cleanup(br, w); + call_rcu(w, pci_bridge_region_cleanup_schedule, rcu); } =20 /* default write_config function for PCI-to-PCI bridge */ diff --git a/include/hw/pci/pci_bridge.h b/include/hw/pci/pci_bridge.h index 0347da5..0e1fd82 100644 --- a/include/hw/pci/pci_bridge.h +++ b/include/hw/pci/pci_bridge.h @@ -37,6 +37,7 @@ typedef struct PCIBridgeWindows PCIBridgeWindows; * as subregions. */ struct PCIBridgeWindows { + struct rcu_head rcu; MemoryRegion alias_pref_mem; MemoryRegion alias_mem; MemoryRegion alias_io; --=20 2.7.4