[Qemu-devel] [PATCH 0/2] ARM virt: Silence dtc warnings

Eric Auger posted 2 patches 5 years, 10 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1528554193-27270-1-git-send-email-eric.auger@redhat.com
Test checkpatch passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 failed
Test s390x passed
There is a newer version of this series
hw/arm/boot.c | 20 ++++++++++++------
hw/arm/virt.c | 65 ++++++++++++++++++++++++++++++++++-------------------------
2 files changed, 51 insertions(+), 34 deletions(-)
[Qemu-devel] [PATCH 0/2] ARM virt: Silence dtc warnings
Posted by Eric Auger 5 years, 10 months ago
When running dtc on the guest /proc/device-tree, we get the
following warnings: "Warning (unit_address_vs_reg): Node <name>
has a reg or ranges property, but no unit name", with name:
/intc, /intc/its, /intc/v2m, /memory.

This series removes those warnings by adding the unit address to
the corresponding node names.

Best Regards

Eric

Eric Auger (2):
  hw/arm/virt: Silence dtc /intc warnings
  hw/arm/virt: Silence dtc /memory warning

 hw/arm/boot.c | 20 ++++++++++++------
 hw/arm/virt.c | 65 ++++++++++++++++++++++++++++++++++-------------------------
 2 files changed, 51 insertions(+), 34 deletions(-)

-- 
2.5.5


Re: [Qemu-devel] [PATCH 0/2] ARM virt: Silence dtc warnings
Posted by Peter Maydell 5 years, 10 months ago
On 9 June 2018 at 15:23, Eric Auger <eric.auger@redhat.com> wrote:
> When running dtc on the guest /proc/device-tree, we get the
> following warnings: "Warning (unit_address_vs_reg): Node <name>
> has a reg or ranges property, but no unit name", with name:
> /intc, /intc/its, /intc/v2m, /memory.
>
> This series removes those warnings by adding the unit address to
> the corresponding node names.

Thanks for this patchset -- Marc Z reported this ages ago
but I never got round to looking at it.

Patch 1 looks fine, but patch 2 changing the "/memory" node
handling I'm less happy with. Currently we're consistent: we
assume that the memory node must always be called "/memory",
and we look for an existing node that way and create our own
with that name. If in fact memory nodes might not be named
"/memory" then we need to look for any preexisting "/memory@*" node,
not just "/memory", don't we?

thanks
-- PMM