[Qemu-devel] [PATCH v3 0/2] fix -nodefaults and -daemonize regressions caused by --preconfig introduction

Igor Mammedov posted 2 patches 5 years, 9 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1528207243-268226-1-git-send-email-imammedo@redhat.com
Test checkpatch failed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test s390x passed
os-posix.c | 6 ++++++
vl.c       | 6 +++---
2 files changed, 9 insertions(+), 3 deletions(-)
[Qemu-devel] [PATCH v3 0/2] fix -nodefaults and -daemonize regressions caused by --preconfig introduction
Posted by Igor Mammedov 5 years, 9 months ago
Commit 047f7038f586d2150f16c6d9ba9cfd0479f0f6ac broke iotests that were using
 -nodefault option, which lead to hang in the early main_loop_wait().
1/2 fixes it by not calling main_loop_wait() unless --preconfig option was on CLI.
1/2 also fixes issue where libvirt starting qemu as daemon waits on qemu parent
process to exit which doens't happen at the early main_loop().
2/2 fixes the same deamon issue but with --preconfig option on CLI

With this QEMU passes make check, make check-block and manual testing with
-daemonize

CC: berrange@redhat.com
CC: mreitz@redhat.com
CC: pbonzini@redhat.com
CC: ehabkost@redhat.com
CC: ldoktor@redhat.com

Igor Mammedov (2):
  cli: Don't run early event loop if no  --preconfig was specified
  vl: fix use of --daemonize with --preconfig

 os-posix.c | 6 ++++++
 vl.c       | 6 +++---
 2 files changed, 9 insertions(+), 3 deletions(-)

-- 
2.7.4


Re: [Qemu-devel] [PATCH v3 0/2] fix -nodefaults and -daemonize regressions caused by --preconfig introduction
Posted by no-reply@patchew.org 5 years, 9 months ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1528207243-268226-1-git-send-email-imammedo@redhat.com
Subject: [Qemu-devel] [PATCH v3 0/2] fix -nodefaults and -daemonize regressions caused by --preconfig introduction

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
01373291b2 vl: fix use of --daemonize with --preconfig
b6f325357d cli: Don't run early event loop if no --preconfig was specified

=== OUTPUT BEGIN ===
Checking PATCH 1/2: cli: Don't run early event loop if no --preconfig was specified...
Checking PATCH 2/2: vl: fix use of --daemonize with --preconfig...
ERROR: do not initialise statics to 0 or NULL
#44: FILE: os-posix.c:312:
+    static bool os_setup_post_done = false;

total: 1 errors, 0 warnings, 28 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com