Changeset
target/riscv/cpu.h | 1 -
1 file changed, 1 deletion(-)
Git apply log
Switched to a new branch '1526382973-49342-1-git-send-email-imammedo@redhat.com'
Applying: riscv: remove define cpu_init()
To https://github.com/patchew-project/qemu
 + 4479148...cdc498e patchew/1526382973-49342-1-git-send-email-imammedo@redhat.com -> patchew/1526382973-49342-1-git-send-email-imammedo@redhat.com (forced update)
Test passed: checkpatch

loading

Test passed: docker-mingw@fedora

loading

Test passed: docker-quick@centos7

loading

Test passed: s390x

loading

[Qemu-devel] [PATCH] riscv: remove define cpu_init()
Posted by Igor Mammedov, 1 week ago
cpu_init() was removed since 2.12, so drop define that now isn't used
nad point to nowhere.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
 target/riscv/cpu.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
index 34abc38..0562a02 100644
--- a/target/riscv/cpu.h
+++ b/target/riscv/cpu.h
@@ -251,7 +251,6 @@ int riscv_cpu_handle_mmu_fault(CPUState *cpu, vaddr address, int size,
 char *riscv_isa_string(RISCVCPU *cpu);
 void riscv_cpu_list(FILE *f, fprintf_function cpu_fprintf);
 
-#define cpu_init(cpu_model) cpu_generic_init(TYPE_RISCV_CPU, cpu_model)
 #define cpu_signal_handler cpu_riscv_signal_handler
 #define cpu_list riscv_cpu_list
 #define cpu_mmu_index riscv_cpu_mmu_index
-- 
2.7.4


Re: [Qemu-devel] [PATCH] riscv: remove define cpu_init()
Posted by Philippe Mathieu-Daudé, 1 week ago
On 05/15/2018 08:16 AM, Igor Mammedov wrote:
> cpu_init() was removed since 2.12, so drop define that now isn't used
> nad point to nowhere.
> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  target/riscv/cpu.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
> index 34abc38..0562a02 100644
> --- a/target/riscv/cpu.h
> +++ b/target/riscv/cpu.h
> @@ -251,7 +251,6 @@ int riscv_cpu_handle_mmu_fault(CPUState *cpu, vaddr address, int size,
>  char *riscv_isa_string(RISCVCPU *cpu);
>  void riscv_cpu_list(FILE *f, fprintf_function cpu_fprintf);
>  
> -#define cpu_init(cpu_model) cpu_generic_init(TYPE_RISCV_CPU, cpu_model)
>  #define cpu_signal_handler cpu_riscv_signal_handler
>  #define cpu_list riscv_cpu_list
>  #define cpu_mmu_index riscv_cpu_mmu_index
> 

Re: [Qemu-devel] [PATCH] riscv: remove define cpu_init()
Posted by Eric Blake, 1 week ago
On 05/15/2018 06:16 AM, Igor Mammedov wrote:
> cpu_init() was removed since 2.12, so drop define that now isn't used
> nad point to nowhere.

Reads better as:

so drop the define that is now unused

or maybe

so drop the unused define rather than letting it point to nowhere

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

[Qemu-devel] [PATCH v2] riscv: remove define cpu_init()
Posted by Igor Mammedov, 1 week ago
cpu_init() was removed since 2.12, so drop the define that is now unused.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
v2:
  * refine commit message (Eric Blake <eblake@redhat.com>)
---
 target/riscv/cpu.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
index 34abc38..0562a02 100644
--- a/target/riscv/cpu.h
+++ b/target/riscv/cpu.h
@@ -251,7 +251,6 @@ int riscv_cpu_handle_mmu_fault(CPUState *cpu, vaddr address, int size,
 char *riscv_isa_string(RISCVCPU *cpu);
 void riscv_cpu_list(FILE *f, fprintf_function cpu_fprintf);
 
-#define cpu_init(cpu_model) cpu_generic_init(TYPE_RISCV_CPU, cpu_model)
 #define cpu_signal_handler cpu_riscv_signal_handler
 #define cpu_list riscv_cpu_list
 #define cpu_mmu_index riscv_cpu_mmu_index
-- 
2.7.4


Re: [Qemu-devel] [PATCH v2] riscv: remove define cpu_init()
Posted by Michael Clark, 5 days ago
On Wed, May 16, 2018 at 4:00 AM, Igor Mammedov <imammedo@redhat.com> wrote:

> cpu_init() was removed since 2.12, so drop the define that is now unused.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>

Reviewed-by: Michael Clark <mjc@sifive.com>

---
> v2:
>   * refine commit message (Eric Blake <eblake@redhat.com>)
> ---
>  target/riscv/cpu.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
> index 34abc38..0562a02 100644
> --- a/target/riscv/cpu.h
> +++ b/target/riscv/cpu.h
> @@ -251,7 +251,6 @@ int riscv_cpu_handle_mmu_fault(CPUState *cpu, vaddr
> address, int size,
>  char *riscv_isa_string(RISCVCPU *cpu);
>  void riscv_cpu_list(FILE *f, fprintf_function cpu_fprintf);
>
> -#define cpu_init(cpu_model) cpu_generic_init(TYPE_RISCV_CPU, cpu_model)
>  #define cpu_signal_handler cpu_riscv_signal_handler
>  #define cpu_list riscv_cpu_list
>  #define cpu_mmu_index riscv_cpu_mmu_index
> --
> 2.7.4
>
>
Re: [Qemu-devel] [PATCH v2] riscv: remove define cpu_init()
Posted by Igor Mammedov, 4 days ago
On Fri, 18 May 2018 14:10:24 +1200
Michael Clark <mjc@sifive.com> wrote:

> On Wed, May 16, 2018 at 4:00 AM, Igor Mammedov <imammedo@redhat.com> wrote:
> 
> > cpu_init() was removed since 2.12, so drop the define that is now unused.
> >
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> >  
> 
> Reviewed-by: Michael Clark <mjc@sifive.com>
Michael,

could you merge it through RISCV queue?

> 
> ---
> > v2:
> >   * refine commit message (Eric Blake <eblake@redhat.com>)
> > ---
> >  target/riscv/cpu.h | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
> > index 34abc38..0562a02 100644
> > --- a/target/riscv/cpu.h
> > +++ b/target/riscv/cpu.h
> > @@ -251,7 +251,6 @@ int riscv_cpu_handle_mmu_fault(CPUState *cpu, vaddr
> > address, int size,
> >  char *riscv_isa_string(RISCVCPU *cpu);
> >  void riscv_cpu_list(FILE *f, fprintf_function cpu_fprintf);
> >
> > -#define cpu_init(cpu_model) cpu_generic_init(TYPE_RISCV_CPU, cpu_model)
> >  #define cpu_signal_handler cpu_riscv_signal_handler
> >  #define cpu_list riscv_cpu_list
> >  #define cpu_mmu_index riscv_cpu_mmu_index
> > --
> > 2.7.4
> >
> >