[v1] xilinx_spips dummy bytes fix

[Qemu-devel] [PATCH v1 0/1] xilinx_spips dummy bytes fix

Sai Pavan Boddu posted 1 patch 6 years ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1523974696-1965-1-git-send-email-saipava@xilinx.com

Test checkpatch passed

Test docker-build@min-glib passed

Test docker-mingw@fedora passed

Test s390x passed

There is a newer version of this series

hw/ssi/xilinx_spips.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v1 0/1] xilinx_spips dummy bytes fix

Posted by Sai Pavan Boddu 6 years ago

For zynq-7000 boards, we saw issues when u-boot/linux accessing the qspi.
Issue is due to wrong dummy byte transfers for few of un-handled commands ex: 0x9F, 0x6, 0xe9, 0x4, 0x18, etc
There are many unhandled commands which do not require dummy bytes but they can be followed by address cycles.

To fix this issue for above commands, the next upcoming tx bytes are not considered dummies rather sent to slave directly.

Sai Pavan Boddu (1):
  xilinx_spips: send dummy only if cmd requires it

 hw/ssi/xilinx_spips.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

-- 
2.7.4

Re: [Qemu-devel] [PATCH v1 0/1] xilinx_spips dummy bytes fix

Posted by Alistair Francis 6 years ago

On Tue, Apr 17, 2018 at 7:18 AM, Sai Pavan Boddu
<sai.pavan.boddu@xilinx.com> wrote:
> For zynq-7000 boards, we saw issues when u-boot/linux accessing the qspi.
> Issue is due to wrong dummy byte transfers for few of un-handled commands ex: 0x9F, 0x6, 0xe9, 0x4, 0x18, etc
> There are many unhandled commands which do not require dummy bytes but they can be followed by address cycles.
>
> To fix this issue for above commands, the next upcoming tx bytes are not considered dummies rather sent to slave directly.
>
> Sai Pavan Boddu (1):
>   xilinx_spips: send dummy only if cmd requires it

I don't see this patch on the list, I only see the cover letter.

Do other see it?

Alistair

>
>  hw/ssi/xilinx_spips.c | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
>
> --
> 2.7.4
>
>

Re: [Qemu-devel] [PATCH v1 0/1] xilinx_spips dummy bytes fix

Posted by Alistair Francis 6 years ago

On Tue, Apr 17, 2018 at 8:47 AM, Alistair Francis <alistair23@gmail.com> wrote:
> On Tue, Apr 17, 2018 at 7:18 AM, Sai Pavan Boddu
> <sai.pavan.boddu@xilinx.com> wrote:
>> For zynq-7000 boards, we saw issues when u-boot/linux accessing the qspi.
>> Issue is due to wrong dummy byte transfers for few of un-handled commands ex: 0x9F, 0x6, 0xe9, 0x4, 0x18, etc
>> There are many unhandled commands which do not require dummy bytes but they can be followed by address cycles.
>>
>> To fix this issue for above commands, the next upcoming tx bytes are not considered dummies rather sent to slave directly.
>>
>> Sai Pavan Boddu (1):
>>   xilinx_spips: send dummy only if cmd requires it
>
> I don't see this patch on the list, I only see the cover letter.
>
> Do other see it?

Never mind, it just came through.

Alistair

>
> Alistair
>
>>
>>  hw/ssi/xilinx_spips.c | 13 ++++++++++---
>>  1 file changed, 10 insertions(+), 3 deletions(-)
>>
>> --
>> 2.7.4
>>
>>