[Qemu-devel] [PATCH v4 0/5] s390x: vfio-ap: guest dedicated crypto adapters

Tony Krowiak posted 5 patches 6 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1523819244-29954-1-git-send-email-akrowiak@linux.vnet.ibm.com
Test checkpatch failed
Test docker-build@min-glib passed
Test docker-mingw@fedora passed
Test s390x passed
There is a newer version of this series
default-configs/s390x-softmmu.mak |    1 +
docs/vfio-ap.txt                  |  649 +++++++++++++++++++++++++++++++++++++
hw/s390x/Makefile.objs            |    1 +
hw/s390x/ap-device.c              |   39 +++
hw/vfio/Makefile.objs             |    1 +
hw/vfio/ap.c                      |  191 +++++++++++
include/hw/s390x/ap-device.h      |   38 +++
include/hw/vfio/vfio-common.h     |    1 +
linux-headers/asm-s390/kvm.h      |    2 +
linux-headers/linux/vfio.h        |    2 +
target/s390x/cpu_features.c       |    3 +
target/s390x/cpu_features_def.h   |    3 +
target/s390x/cpu_models.c         |    2 +
target/s390x/gen-features.c       |    3 +
target/s390x/kvm.c                |    1 +
ui/keycodemapdb                   |    2 +-
16 files changed, 938 insertions(+), 1 deletions(-)
create mode 100644 docs/vfio-ap.txt
create mode 100644 hw/s390x/ap-device.c
create mode 100644 hw/vfio/ap.c
create mode 100644 include/hw/s390x/ap-device.h
[Qemu-devel] [PATCH v4 0/5] s390x: vfio-ap: guest dedicated crypto adapters
Posted by Tony Krowiak 6 years ago
This patch series is the QEMU counterpart to the KVM/kernel support for 
guest dedicated crypto adapters. The KVM/kernel model is built on the 
VFIO mediated device framework and provides the infrastructure for 
granting exclusive guest access to crypto devices installed on the linux 
host. This patch series introduces a new QEMU command line option, QEMU 
object model and CPU model features to exploit the KVM/kernel model.

See the detailed specifications for AP virtualization provided by this 
patch set in docs/vfio-ap.txt for a more complete discussion of the 
design introduced by this patch series.

Note: This series implements the minimal viable product (MVP) and does not
      provide support for hot plug/unplug, migration, or VSIE. The goal
      of the MVP model is to solidify a base upon which these additional 
      features will be built.

v3 => v4 Change log:
===================
* Made vfio-ap device unpluggable for now
* Renamed command line CPU model feature for QCI: qci=on -> apqci=on
* Removed call to KVM_S390_VM_CRYPTO_INTERPRET_AP ioctl - ioctl was 
  removed from kernel and AP instruction interpretation is set from the
  VFIO device driver
* Added check to ensure only one vfio-ap device can be configured per 
  guest
* Removed AP instruction interception handlers: AP instructions will be 
  interpreted by default if AP facilities are installed to handle the case
  where feature ap=on and no vfio-ap device is configured for the guest.

Tony Krowiak (5):
  linux-headers: linux header updates for AP support
  s390x/ap: base Adjunct Processor (AP) object
  s390x/cpumodel: Set up CPU model for AP device support
  s390x/vfio: ap: Introduce VFIO AP device
  s390: doc: detailed specifications for AP virtualization

 default-configs/s390x-softmmu.mak |    1 +
 docs/vfio-ap.txt                  |  649 +++++++++++++++++++++++++++++++++++++
 hw/s390x/Makefile.objs            |    1 +
 hw/s390x/ap-device.c              |   39 +++
 hw/vfio/Makefile.objs             |    1 +
 hw/vfio/ap.c                      |  191 +++++++++++
 include/hw/s390x/ap-device.h      |   38 +++
 include/hw/vfio/vfio-common.h     |    1 +
 linux-headers/asm-s390/kvm.h      |    2 +
 linux-headers/linux/vfio.h        |    2 +
 target/s390x/cpu_features.c       |    3 +
 target/s390x/cpu_features_def.h   |    3 +
 target/s390x/cpu_models.c         |    2 +
 target/s390x/gen-features.c       |    3 +
 target/s390x/kvm.c                |    1 +
 ui/keycodemapdb                   |    2 +-
 16 files changed, 938 insertions(+), 1 deletions(-)
 create mode 100644 docs/vfio-ap.txt
 create mode 100644 hw/s390x/ap-device.c
 create mode 100644 hw/vfio/ap.c
 create mode 100644 include/hw/s390x/ap-device.h


Re: [Qemu-devel] [PATCH v4 0/5] s390x: vfio-ap: guest dedicated crypto adapters
Posted by no-reply@patchew.org 6 years ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1523819244-29954-1-git-send-email-akrowiak@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH v4 0/5] s390x: vfio-ap: guest dedicated crypto adapters

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/1523819244-29954-1-git-send-email-akrowiak@linux.vnet.ibm.com -> patchew/1523819244-29954-1-git-send-email-akrowiak@linux.vnet.ibm.com
Switched to a new branch 'test'
05c25cd0f2 s390: doc: detailed specifications for AP virtualization
543e5cbc46 s390x/vfio: ap: Introduce VFIO AP device
994913441f s390x/cpumodel: Set up CPU model for AP device support
e7f90b1258 s390x/ap: base Adjunct Processor (AP) object
13602d236e linux-headers: linux header updates for AP support

=== OUTPUT BEGIN ===
Checking PATCH 1/5: linux-headers: linux header updates for AP support...
Checking PATCH 2/5: s390x/ap: base Adjunct Processor (AP) object...
Checking PATCH 3/5: s390x/cpumodel: Set up CPU model for AP device support...
WARNING: line over 80 characters
#43: FILE: target/s390x/cpu_features.c:43:
+    FEAT_INIT("apqci", S390_FEAT_TYPE_STFL, 12, "Query AP Configuration facility"),

ERROR: line over 90 characters
#46: FILE: target/s390x/cpu_features.c:46:
+    FEAT_INIT("apft", S390_FEAT_TYPE_STFL, 15, "Adjunct Processor Facilities Test facility"),

total: 1 errors, 1 warnings, 58 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/5: s390x/vfio: ap: Introduce VFIO AP device...
Checking PATCH 5/5: s390: doc: detailed specifications for AP virtualization...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PATCH v4 0/5] s390x: vfio-ap: guest dedicated crypto adapters
Posted by Cornelia Huck 5 years, 12 months ago
On Sun, 15 Apr 2018 15:07:19 -0400
Tony Krowiak <akrowiak@linux.vnet.ibm.com> wrote:

>  default-configs/s390x-softmmu.mak |    1 +
>  docs/vfio-ap.txt                  |  649 +++++++++++++++++++++++++++++++++++++
>  hw/s390x/Makefile.objs            |    1 +
>  hw/s390x/ap-device.c              |   39 +++
>  hw/vfio/Makefile.objs             |    1 +
>  hw/vfio/ap.c                      |  191 +++++++++++
>  include/hw/s390x/ap-device.h      |   38 +++
>  include/hw/vfio/vfio-common.h     |    1 +
>  linux-headers/asm-s390/kvm.h      |    2 +
>  linux-headers/linux/vfio.h        |    2 +
>  target/s390x/cpu_features.c       |    3 +
>  target/s390x/cpu_features_def.h   |    3 +
>  target/s390x/cpu_models.c         |    2 +
>  target/s390x/gen-features.c       |    3 +
>  target/s390x/kvm.c                |    1 +
>  ui/keycodemapdb                   |    2 +-
>  16 files changed, 938 insertions(+), 1 deletions(-)
>  create mode 100644 docs/vfio-ap.txt
>  create mode 100644 hw/s390x/ap-device.c
>  create mode 100644 hw/vfio/ap.c
>  create mode 100644 include/hw/s390x/ap-device.h

Can we please get a MAINTAINERS entry for ap? While I'm obviously happy
to take things through the s390x tree, ap is not something I can easily
review (or even test), so I'd like to see an entry with dedicated (IBM)
maintainers.

Also, hw/vfio/ap.c and docs/vfio-ap.c should be added to the generic
s390 section.

Re: [Qemu-devel] [PATCH v4 0/5] s390x: vfio-ap: guest dedicated crypto adapters
Posted by Tony Krowiak 5 years, 12 months ago
On 04/19/2018 07:51 AM, Cornelia Huck wrote:
> On Sun, 15 Apr 2018 15:07:19 -0400
> Tony Krowiak <akrowiak@linux.vnet.ibm.com> wrote:
>
>>   default-configs/s390x-softmmu.mak |    1 +
>>   docs/vfio-ap.txt                  |  649 +++++++++++++++++++++++++++++++++++++
>>   hw/s390x/Makefile.objs            |    1 +
>>   hw/s390x/ap-device.c              |   39 +++
>>   hw/vfio/Makefile.objs             |    1 +
>>   hw/vfio/ap.c                      |  191 +++++++++++
>>   include/hw/s390x/ap-device.h      |   38 +++
>>   include/hw/vfio/vfio-common.h     |    1 +
>>   linux-headers/asm-s390/kvm.h      |    2 +
>>   linux-headers/linux/vfio.h        |    2 +
>>   target/s390x/cpu_features.c       |    3 +
>>   target/s390x/cpu_features_def.h   |    3 +
>>   target/s390x/cpu_models.c         |    2 +
>>   target/s390x/gen-features.c       |    3 +
>>   target/s390x/kvm.c                |    1 +
>>   ui/keycodemapdb                   |    2 +-
>>   16 files changed, 938 insertions(+), 1 deletions(-)
>>   create mode 100644 docs/vfio-ap.txt
>>   create mode 100644 hw/s390x/ap-device.c
>>   create mode 100644 hw/vfio/ap.c
>>   create mode 100644 include/hw/s390x/ap-device.h
> Can we please get a MAINTAINERS entry for ap? While I'm obviously happy
> to take things through the s390x tree, ap is not something I can easily
> review (or even test), so I'd like to see an entry with dedicated (IBM)
> maintainers.

Will do .... who would you like to see in this list?

>
> Also, hw/vfio/ap.c and docs/vfio-ap.c should be added to the generic
> s390 section.

Okay.

>


Re: [Qemu-devel] [PATCH v4 0/5] s390x: vfio-ap: guest dedicated crypto adapters
Posted by Cornelia Huck 5 years, 12 months ago
On Sun, 22 Apr 2018 12:17:22 -0400
Tony Krowiak <akrowiak@linux.vnet.ibm.com> wrote:

> On 04/19/2018 07:51 AM, Cornelia Huck wrote:
> > On Sun, 15 Apr 2018 15:07:19 -0400
> > Tony Krowiak <akrowiak@linux.vnet.ibm.com> wrote:
> >  
> >>   default-configs/s390x-softmmu.mak |    1 +
> >>   docs/vfio-ap.txt                  |  649 +++++++++++++++++++++++++++++++++++++
> >>   hw/s390x/Makefile.objs            |    1 +
> >>   hw/s390x/ap-device.c              |   39 +++
> >>   hw/vfio/Makefile.objs             |    1 +
> >>   hw/vfio/ap.c                      |  191 +++++++++++
> >>   include/hw/s390x/ap-device.h      |   38 +++
> >>   include/hw/vfio/vfio-common.h     |    1 +
> >>   linux-headers/asm-s390/kvm.h      |    2 +
> >>   linux-headers/linux/vfio.h        |    2 +
> >>   target/s390x/cpu_features.c       |    3 +
> >>   target/s390x/cpu_features_def.h   |    3 +
> >>   target/s390x/cpu_models.c         |    2 +
> >>   target/s390x/gen-features.c       |    3 +
> >>   target/s390x/kvm.c                |    1 +
> >>   ui/keycodemapdb                   |    2 +-
> >>   16 files changed, 938 insertions(+), 1 deletions(-)
> >>   create mode 100644 docs/vfio-ap.txt
> >>   create mode 100644 hw/s390x/ap-device.c
> >>   create mode 100644 hw/vfio/ap.c
> >>   create mode 100644 include/hw/s390x/ap-device.h  
> > Can we please get a MAINTAINERS entry for ap? While I'm obviously happy
> > to take things through the s390x tree, ap is not something I can easily
> > review (or even test), so I'd like to see an entry with dedicated (IBM)
> > maintainers.  
> 
> Will do .... who would you like to see in this list?

Whoever feels up to the task and has access to the documentation :)

> 
> >
> > Also, hw/vfio/ap.c and docs/vfio-ap.c should be added to the generic
> > s390 section.  
> 
> Okay.
> 
> >  
>