[Qemu-devel] [PATCH for-2.13 0/2] net: Get rid of 'vlan' terminology and use 'hub' instead

Thomas Huth posted 2 patches 6 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1522856003-26861-1-git-send-email-thuth@redhat.com
Test checkpatch passed
Test docker-build@min-glib passed
Test docker-mingw@fedora passed
Test s390x passed
docs/qdev-device-use.txt         |  4 ++--
hw/core/qdev-properties-system.c | 18 +++++++++---------
include/hw/qdev-properties.h     |  6 +++---
include/net/net.h                |  2 +-
net/hub.c                        |  4 ++--
net/net.c                        |  2 +-
net/slirp.c                      |  8 ++++----
net/tap.c                        |  4 ++--
qapi/net.json                    | 10 +++++-----
qemu-doc.texi                    | 41 +++++++++++++++++++++-------------------
qemu-options.hx                  |  6 +++---
11 files changed, 54 insertions(+), 51 deletions(-)
[Qemu-devel] [PATCH for-2.13 0/2] net: Get rid of 'vlan' terminology and use 'hub' instead
Posted by Thomas Huth 6 years ago
The 'vlan' term caused a lot of confusion in the past, so let's try
to switch to the better word "hub" everywhere where it is appropriate.
(Note: The CLI parameter "vlan=xxx" still remains as is to not break the
compatibility with older versions)

Thomas Huth (2):
  net: Get rid of 'vlan' terminology and use 'hub' instead in the source
    files
  net: Get rid of 'vlan' terminology and use 'hub' instead in the doc
    files

 docs/qdev-device-use.txt         |  4 ++--
 hw/core/qdev-properties-system.c | 18 +++++++++---------
 include/hw/qdev-properties.h     |  6 +++---
 include/net/net.h                |  2 +-
 net/hub.c                        |  4 ++--
 net/net.c                        |  2 +-
 net/slirp.c                      |  8 ++++----
 net/tap.c                        |  4 ++--
 qapi/net.json                    | 10 +++++-----
 qemu-doc.texi                    | 41 +++++++++++++++++++++-------------------
 qemu-options.hx                  |  6 +++---
 11 files changed, 54 insertions(+), 51 deletions(-)

-- 
1.8.3.1


Re: [Qemu-devel] [PATCH for-2.13 0/2] net: Get rid of 'vlan' terminology and use 'hub' instead
Posted by Paolo Bonzini 6 years ago
On 04/04/2018 17:33, Thomas Huth wrote:
> The 'vlan' term caused a lot of confusion in the past, so let's try
> to switch to the better word "hub" everywhere where it is appropriate.
> (Note: The CLI parameter "vlan=xxx" still remains as is to not break the
> compatibility with older versions)
> 
> Thomas Huth (2):
>   net: Get rid of 'vlan' terminology and use 'hub' instead in the source
>     files
>   net: Get rid of 'vlan' terminology and use 'hub' instead in the doc
>     files

Bold proposal: remove 'vlan' property/suboption in 2.13, so that we can
remove the "aka"s altogether.  Yes, it's early, but even though I've
occasionally used vlans I've never used more than one...

Paolo

Re: [Qemu-devel] [PATCH for-2.13 0/2] net: Get rid of 'vlan' terminology and use 'hub' instead
Posted by Thomas Huth 6 years ago
On 04.04.2018 17:49, Paolo Bonzini wrote:
> On 04/04/2018 17:33, Thomas Huth wrote:
>> The 'vlan' term caused a lot of confusion in the past, so let's try
>> to switch to the better word "hub" everywhere where it is appropriate.
>> (Note: The CLI parameter "vlan=xxx" still remains as is to not break the
>> compatibility with older versions)
>>
>> Thomas Huth (2):
>>   net: Get rid of 'vlan' terminology and use 'hub' instead in the source
>>     files
>>   net: Get rid of 'vlan' terminology and use 'hub' instead in the doc
>>     files
> 
> Bold proposal: remove 'vlan' property/suboption in 2.13, so that we can
> remove the "aka"s altogether.  Yes, it's early, but even though I've
> occasionally used vlans I've never used more than one...

Fine for me, too - if we all feel confident enough already for that. The
"vlan=..." parameter of "-net" has been declared as deprecated since
QEMU v2.9, so unless somebody sees an urgent need to still keep it, I
can add another patch to this series to remove it ("-net" will then only
work with the default hub #0).

 Thomas

Re: [Qemu-devel] [PATCH for-2.13 0/2] net: Get rid of 'vlan' terminology and use 'hub' instead
Posted by Stefan Hajnoczi 6 years ago
On Wed, Apr 04, 2018 at 05:55:57PM +0200, Thomas Huth wrote:
> On 04.04.2018 17:49, Paolo Bonzini wrote:
> > On 04/04/2018 17:33, Thomas Huth wrote:
> >> The 'vlan' term caused a lot of confusion in the past, so let's try
> >> to switch to the better word "hub" everywhere where it is appropriate.
> >> (Note: The CLI parameter "vlan=xxx" still remains as is to not break the
> >> compatibility with older versions)
> >>
> >> Thomas Huth (2):
> >>   net: Get rid of 'vlan' terminology and use 'hub' instead in the source
> >>     files
> >>   net: Get rid of 'vlan' terminology and use 'hub' instead in the doc
> >>     files
> > 
> > Bold proposal: remove 'vlan' property/suboption in 2.13, so that we can
> > remove the "aka"s altogether.  Yes, it's early, but even though I've
> > occasionally used vlans I've never used more than one...
> 
> Fine for me, too - if we all feel confident enough already for that. The
> "vlan=..." parameter of "-net" has been declared as deprecated since
> QEMU v2.9, so unless somebody sees an urgent need to still keep it, I
> can add another patch to this series to remove it ("-net" will then only
> work with the default hub #0).

Sound good to me.

Stefan