[Qemu-devel] [PATCH 0/2 RFC] Implement Hex file loader and add test case

Su Hang posted 2 patches 6 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1522768634-5548-1-git-send-email-suhang16@mails.ucas.ac.cn
Test checkpatch failed
Test docker-build@min-glib passed
Test docker-mingw@fedora passed
Test s390x passed
There is a newer version of this series
hw/arm/boot.c          |   9 +-
hw/core/loader.c       | 280 +++++++++++++++++++++++++++++++++++++++++++++++++
include/hw/loader.h    |  17 +++
tests/Makefile.include |   2 +
tests/hexloader-test.c |  56 ++++++++++
tests/test.hex         |  11 ++
6 files changed, 374 insertions(+), 1 deletion(-)
create mode 100644 tests/hexloader-test.c
create mode 100644 tests/test.hex
[Qemu-devel] [PATCH 0/2 RFC] Implement Hex file loader and add test case
Posted by Su Hang 6 years ago
These series of patchs implement Intel Hexadecimal File loader and
add QTest testcase to verify the correctness of Loader.  

Su Hang (2):
  Implement .hex file loader
  Add QTest testcase for the Intel Hexadecimal Object File Loader.

 hw/arm/boot.c          |   9 +-
 hw/core/loader.c       | 280 +++++++++++++++++++++++++++++++++++++++++++++++++
 include/hw/loader.h    |  17 +++
 tests/Makefile.include |   2 +
 tests/hexloader-test.c |  56 ++++++++++
 tests/test.hex         |  11 ++
 6 files changed, 374 insertions(+), 1 deletion(-)
 create mode 100644 tests/hexloader-test.c
 create mode 100644 tests/test.hex

-- 
2.7.4


Re: [Qemu-devel] [PATCH 0/2 RFC] Implement Hex file loader and add test case
Posted by no-reply@patchew.org 6 years ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1522768634-5548-1-git-send-email-suhang16@mails.ucas.ac.cn
Subject: [Qemu-devel] [PATCH 0/2 RFC] Implement Hex file loader and add test case

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/1522768634-5548-1-git-send-email-suhang16@mails.ucas.ac.cn -> patchew/1522768634-5548-1-git-send-email-suhang16@mails.ucas.ac.cn
Switched to a new branch 'test'
ae6e4ea631 Add QTest testcase for the Hex File Loader
3392bbf17c Implement .hex file loader

=== OUTPUT BEGIN ===
Checking PATCH 1/2: Implement .hex file loader...
ERROR: braces {} are necessary for all arms of this statement
#220: FILE: hw/core/loader.c:1463:
+    } while (++hex_blob != end);
[...]

total: 1 errors, 0 warnings, 328 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/2: Add QTest testcase for the Hex File Loader...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com