accel/stubs/Makefile.objs | 9 +- accel/stubs/whpx-stub.c | 48 ++ configure | 48 +- cpus.c | 66 ++- include/sysemu/hw_accel.h | 13 + include/sysemu/whpx.h | 40 ++ qemu-options.hx | 8 +- target/i386/Makefile.objs | 1 + target/i386/helper.c | 2 +- target/i386/whpx-all.c | 1366 +++++++++++++++++++++++++++++++++++++++++++++ 10 files changed, 1590 insertions(+), 11 deletions(-) create mode 100644 accel/stubs/whpx-stub.c create mode 100644 include/sysemu/whpx.h create mode 100644 target/i386/whpx-all.c
Updates based on review feedback. 1. Fixes style issues and properly ran the scripts/checkpatch pre submission. 2. Added migration blockers for CPUID, dirty memory tracking, and XSAVE/XRSTOR. 3. Fixed some bugs around register states when using bios vs efi. Justin Terry (VM) (4): Add the Windows Hypervisor Platform accelerator. Add the WHPX vcpu API Introduce the WHPX impl Add the WHPX acceleration enlightenments accel/stubs/Makefile.objs | 9 +- accel/stubs/whpx-stub.c | 48 ++ configure | 48 +- cpus.c | 66 ++- include/sysemu/hw_accel.h | 13 + include/sysemu/whpx.h | 40 ++ qemu-options.hx | 8 +- target/i386/Makefile.objs | 1 + target/i386/helper.c | 2 +- target/i386/whpx-all.c | 1366 +++++++++++++++++++++++++++++++++++++++++++++ 10 files changed, 1590 insertions(+), 11 deletions(-) create mode 100644 accel/stubs/whpx-stub.c create mode 100644 include/sysemu/whpx.h create mode 100644 target/i386/whpx-all.c -- 2.7.4
Hi All, Is there any additional feedback I can address here to help out the process? Please let me know. Thanks again, Justin > -----Original Message----- > From: Justin Terry (VM) > Sent: Monday, January 22, 2018 1:08 PM > To: qemu-devel@nongnu.org > Cc: pbonzini@redhat.com; crosthwaite.peter@gmail.com; rth@twiddle.net; > ehabkost@redhat.com; Justin Terry (VM) <juterry@microsoft.com> > Subject: [PATCH v2 0/4] Updates based on feedback. > > Updates based on review feedback. > > 1. Fixes style issues and properly ran the scripts/checkpatch pre submission. > 2. Added migration blockers for CPUID, dirty memory tracking, and > XSAVE/XRSTOR. > 3. Fixed some bugs around register states when using bios vs efi. > > Justin Terry (VM) (4): > Add the Windows Hypervisor Platform accelerator. > Add the WHPX vcpu API > Introduce the WHPX impl > Add the WHPX acceleration enlightenments > > accel/stubs/Makefile.objs | 9 +- > accel/stubs/whpx-stub.c | 48 ++ > configure | 48 +- > cpus.c | 66 ++- > include/sysemu/hw_accel.h | 13 + > include/sysemu/whpx.h | 40 ++ > qemu-options.hx | 8 +- > target/i386/Makefile.objs | 1 + > target/i386/helper.c | 2 +- > target/i386/whpx-all.c | 1366 > +++++++++++++++++++++++++++++++++++++++++++++ > 10 files changed, 1590 insertions(+), 11 deletions(-) create mode 100644 > accel/stubs/whpx-stub.c create mode 100644 include/sysemu/whpx.h > create mode 100644 target/i386/whpx-all.c > > -- > 2.7.4
On 29/01/2018 14:58, Justin Terry (VM) wrote: > Hi All, > > Is there any additional feedback I can address here to help out the process? Please let me know. Nothing specifically (it didn't help that most of last week I was sick!). From my point of view, I just need to review the changes you made and include these patches in a pull request. Thanks, Paolo > Thanks again, > Justin > >> -----Original Message----- >> From: Justin Terry (VM) >> Sent: Monday, January 22, 2018 1:08 PM >> To: qemu-devel@nongnu.org >> Cc: pbonzini@redhat.com; crosthwaite.peter@gmail.com; rth@twiddle.net; >> ehabkost@redhat.com; Justin Terry (VM) <juterry@microsoft.com> >> Subject: [PATCH v2 0/4] Updates based on feedback. >> >> Updates based on review feedback. >> >> 1. Fixes style issues and properly ran the scripts/checkpatch pre submission. >> 2. Added migration blockers for CPUID, dirty memory tracking, and >> XSAVE/XRSTOR. >> 3. Fixed some bugs around register states when using bios vs efi. >> >> Justin Terry (VM) (4): >> Add the Windows Hypervisor Platform accelerator. >> Add the WHPX vcpu API >> Introduce the WHPX impl >> Add the WHPX acceleration enlightenments >> >> accel/stubs/Makefile.objs | 9 +- >> accel/stubs/whpx-stub.c | 48 ++ >> configure | 48 +- >> cpus.c | 66 ++- >> include/sysemu/hw_accel.h | 13 + >> include/sysemu/whpx.h | 40 ++ >> qemu-options.hx | 8 +- >> target/i386/Makefile.objs | 1 + >> target/i386/helper.c | 2 +- >> target/i386/whpx-all.c | 1366 >> +++++++++++++++++++++++++++++++++++++++++++++ >> 10 files changed, 1590 insertions(+), 11 deletions(-) create mode 100644 >> accel/stubs/whpx-stub.c create mode 100644 include/sysemu/whpx.h >> create mode 100644 target/i386/whpx-all.c >> >> -- >> 2.7.4 >
No worries at all Paolo. I was just making sure I didn’t miss something. We have been working on some minor fixups/perf improvements on our end and I will submit those patches after this merges. I figured it would be easier because they will be very small and isolated so easier to review moving forward. Thanks, Justin > -----Original Message----- > From: Paolo Bonzini [mailto:pbonzini@redhat.com] > Sent: Tuesday, January 30, 2018 11:34 AM > To: Justin Terry (VM) <juterry@microsoft.com>; qemu-devel@nongnu.org > Cc: crosthwaite.peter@gmail.com; rth@twiddle.net; ehabkost@redhat.com > Subject: Re: [PATCH v2 0/4] Updates based on feedback. > > On 29/01/2018 14:58, Justin Terry (VM) wrote: > > Hi All, > > > > Is there any additional feedback I can address here to help out the > process? Please let me know. > > Nothing specifically (it didn't help that most of last week I was sick!). From > my point of view, I just need to review the changes you made and include > these patches in a pull request. > > Thanks, > > Paolo > > > Thanks again, > > Justin > > > >> -----Original Message----- > >> From: Justin Terry (VM) > >> Sent: Monday, January 22, 2018 1:08 PM > >> To: qemu-devel@nongnu.org > >> Cc: pbonzini@redhat.com; crosthwaite.peter@gmail.com; > >> rth@twiddle.net; ehabkost@redhat.com; Justin Terry (VM) > >> <juterry@microsoft.com> > >> Subject: [PATCH v2 0/4] Updates based on feedback. > >> > >> Updates based on review feedback. > >> > >> 1. Fixes style issues and properly ran the scripts/checkpatch pre > submission. > >> 2. Added migration blockers for CPUID, dirty memory tracking, and > >> XSAVE/XRSTOR. > >> 3. Fixed some bugs around register states when using bios vs efi. > >> > >> Justin Terry (VM) (4): > >> Add the Windows Hypervisor Platform accelerator. > >> Add the WHPX vcpu API > >> Introduce the WHPX impl > >> Add the WHPX acceleration enlightenments > >> > >> accel/stubs/Makefile.objs | 9 +- > >> accel/stubs/whpx-stub.c | 48 ++ > >> configure | 48 +- > >> cpus.c | 66 ++- > >> include/sysemu/hw_accel.h | 13 + > >> include/sysemu/whpx.h | 40 ++ > >> qemu-options.hx | 8 +- > >> target/i386/Makefile.objs | 1 + > >> target/i386/helper.c | 2 +- > >> target/i386/whpx-all.c | 1366 > >> +++++++++++++++++++++++++++++++++++++++++++++ > >> 10 files changed, 1590 insertions(+), 11 deletions(-) create mode > >> 100644 accel/stubs/whpx-stub.c create mode 100644 > >> include/sysemu/whpx.h create mode 100644 target/i386/whpx-all.c > >> > >> -- > >> 2.7.4 > >
On Mon, Jan 22, 2018 at 01:07:45PM -0800, Justin Terry (VM) wrote: > Updates based on review feedback. > > 1. Fixes style issues and properly ran the scripts/checkpatch pre submission. > 2. Added migration blockers for CPUID, dirty memory tracking, and XSAVE/XRSTOR. > 3. Fixed some bugs around register states when using bios vs efi. For reference to others, v1 seems to be: Subject: [PATCH 0/4] Implements the Windows Hypervisor Platform accelerator https://www.mail-archive.com/qemu-devel@nongnu.org/msg505710.html > > Justin Terry (VM) (4): > Add the Windows Hypervisor Platform accelerator. > Add the WHPX vcpu API > Introduce the WHPX impl > Add the WHPX acceleration enlightenments > > accel/stubs/Makefile.objs | 9 +- > accel/stubs/whpx-stub.c | 48 ++ > configure | 48 +- > cpus.c | 66 ++- > include/sysemu/hw_accel.h | 13 + > include/sysemu/whpx.h | 40 ++ > qemu-options.hx | 8 +- > target/i386/Makefile.objs | 1 + > target/i386/helper.c | 2 +- > target/i386/whpx-all.c | 1366 +++++++++++++++++++++++++++++++++++++++++++++ > 10 files changed, 1590 insertions(+), 11 deletions(-) > create mode 100644 accel/stubs/whpx-stub.c > create mode 100644 include/sysemu/whpx.h > create mode 100644 target/i386/whpx-all.c > > -- > 2.7.4 > -- Eduardo
On Mon, Jan 22, 2018 at 01:07:45PM -0800, Justin Terry (VM) via Qemu-devel wrote: > Updates based on review feedback. > > 1. Fixes style issues and properly ran the scripts/checkpatch pre submission. > 2. Added migration blockers for CPUID, dirty memory tracking, and XSAVE/XRSTOR. > 3. Fixed some bugs around register states when using bios vs efi. > > Justin Terry (VM) (4): > Add the Windows Hypervisor Platform accelerator. > Add the WHPX vcpu API > Introduce the WHPX impl > Add the WHPX acceleration enlightenments This could be huge for QEMU on Windows users. Thanks for doing this! Which guest OSes have you tested? What are the known limitations (after all, the code is quite small and maybe not everything is implemented yet in this patch series)? Stefan
Hey Stefan, Your welcome! Excited to help. I have only tried Ubuntu and Windows guests. Is there a set you would recommend to try out? As for limitations, this set of patches allows for both bios and efi based boots (we have been using TianoCore). We will continue to submit patches around performance tuning on the platform but basic functionality is up and running in this set. The VGA interrupt path can be improved and we are looking at options here to make this a smoother experience. And as mentioned in the update we don't have CPUID support fully implemented yet for migration scenarios. Was there a specific set of things you were wondering that I could investigate or provide clarity on? Thanks, Justin > -----Original Message----- > From: Stefan Hajnoczi [mailto:stefanha@gmail.com] > Sent: Thursday, January 25, 2018 3:02 AM > To: Justin Terry (VM) <juterry@microsoft.com> > Cc: qemu-devel@nongnu.org; pbonzini@redhat.com; rth@twiddle.net; > ehabkost@redhat.com; crosthwaite.peter@gmail.com > Subject: Re: [Qemu-devel] [PATCH v2 0/4] Updates based on feedback. > > On Mon, Jan 22, 2018 at 01:07:45PM -0800, Justin Terry (VM) via Qemu-devel > wrote: > > Updates based on review feedback. > > > > 1. Fixes style issues and properly ran the scripts/checkpatch pre submission. > > 2. Added migration blockers for CPUID, dirty memory tracking, and > XSAVE/XRSTOR. > > 3. Fixed some bugs around register states when using bios vs efi. > > > > Justin Terry (VM) (4): > > Add the Windows Hypervisor Platform accelerator. > > Add the WHPX vcpu API > > Introduce the WHPX impl > > Add the WHPX acceleration enlightenments > > This could be huge for QEMU on Windows users. Thanks for doing this! > > Which guest OSes have you tested? > > What are the known limitations (after all, the code is quite small and maybe not > everything is implemented yet in this patch series)? > > Stefan
On Thu, Jan 25, 2018 at 08:12:57PM +0000, Justin Terry (VM) via Qemu-devel wrote: > I have only tried Ubuntu and Windows guests. Is there a set you would recommend to try out? > > As for limitations, this set of patches allows for both bios and efi based boots (we have been using TianoCore). We will continue to submit patches around performance tuning on the platform but basic functionality is up and running in this set. The VGA interrupt path can be improved and we are looking at options here to make this a smoother experience. And as mentioned in the update we don't have CPUID support fully implemented yet for migration scenarios. Was there a specific set of things you were wondering that I could investigate or provide clarity on? That sounds good. I was just wondering what the general status was. There is no particular set of tests I had in mind. The KVM kernel module has a test suite called kvm-unit-tests for low-level guest code tests (http://www.linux-kvm.org/page/KVM-unit-tests). There are also high-level tests written using the Avocado framework (https://www.linux-kvm.org/page/Avocado). Neither of these is immediately useful or necessary for WHPX though. Stefan
© 2016 - 2024 Red Hat, Inc.