qemu-doc: Get rid of "vlan=X" example in the documentation

[Qemu-devel] [PATCH] qemu-doc: Get rid of "vlan=X" example in the documentation

Thomas Huth posted 1 patch 6 years, 3 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1516002017-4981-1-git-send-email-thuth@redhat.com

Test checkpatch passed

Test docker passed

Test ppc passed

Test s390x passed

qemu-options.hx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH] qemu-doc: Get rid of "vlan=X" example in the documentation

Posted by Thomas Huth 6 years, 3 months ago

The vlan concept is marked as deprecated, so we should not use
this for examples in the documentation anymore.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 qemu-options.hx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index 130016c..d0c8b06 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -2257,8 +2257,8 @@ qemu-system-i386 linux.img -net nic -net tap
 #launch a QEMU instance with two NICs, each one connected
 #to a TAP device
 qemu-system-i386 linux.img \
-                 -net nic,vlan=0 -net tap,vlan=0,ifname=tap0 \
-                 -net nic,vlan=1 -net tap,vlan=1,ifname=tap1
+        -netdev tap,id=nd0,ifname=tap0 -device e1000,netdev=nd0 \
+        -netdev tap,id=nd1,ifname=tap1 -device rtl8139,netdev=nd1
 @end example
 
 @example
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH] qemu-doc: Get rid of "vlan=X" example in the documentation

Posted by Jason Wang 6 years, 3 months ago


On 2018年01月15日 15:40, Thomas Huth wrote:
> The vlan concept is marked as deprecated, so we should not use
> this for examples in the documentation anymore.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   qemu-options.hx | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 130016c..d0c8b06 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2257,8 +2257,8 @@ qemu-system-i386 linux.img -net nic -net tap
>   #launch a QEMU instance with two NICs, each one connected
>   #to a TAP device
>   qemu-system-i386 linux.img \
> -                 -net nic,vlan=0 -net tap,vlan=0,ifname=tap0 \
> -                 -net nic,vlan=1 -net tap,vlan=1,ifname=tap1
> +        -netdev tap,id=nd0,ifname=tap0 -device e1000,netdev=nd0 \
> +        -netdev tap,id=nd1,ifname=tap1 -device rtl8139,netdev=nd1
>   @end example
>   
>   @example

Applied.

Thanks