target/xtensa: Remove duplicate typedef of DisasContext

[Qemu-devel] [PATCH] target/xtensa: Remove duplicate typedef of DisasContext

Peter Maydell posted 1 patch 6 years, 3 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1515762528-22818-1-git-send-email-peter.maydell@linaro.org

Test checkpatch passed

Test docker passed

Test ppc passed

Test s390x passed

target/xtensa/translate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH] target/xtensa: Remove duplicate typedef of DisasContext

Posted by Peter Maydell 6 years, 3 months ago

Some older versions of gcc complain if a typedef is defined twice:

target/xtensa/translate.c:81: error: redefinition of typedef 'DisasContext'
target/xtensa/cpu.h:339: note: previous declaration of 'DisasContext' was here

Remove the now-redundant typedef from the definition of the struct in
translate.c.

Reported-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target/xtensa/translate.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c
index 4bdfcd2..bec9efc 100644
--- a/target/xtensa/translate.c
+++ b/target/xtensa/translate.c
@@ -50,7 +50,7 @@
 /* is_jmp field values */
 #define DISAS_UPDATE  DISAS_TARGET_0 /* cpu state was modified dynamically */
 
-typedef struct DisasContext {
+struct DisasContext {
     const XtensaConfig *config;
     TranslationBlock *tb;
     uint32_t pc;
@@ -78,7 +78,7 @@ typedef struct DisasContext {
     uint32_t *raw_arg;
     xtensa_insnbuf insnbuf;
     xtensa_insnbuf slotbuf;
-} DisasContext;
+};
 
 static TCGv_i32 cpu_pc;
 static TCGv_i32 cpu_R[16];
-- 
2.7.4

Re: [Qemu-devel] [PATCH] target/xtensa: Remove duplicate typedef of DisasContext

Posted by Peter Maydell 6 years, 3 months ago

On 12 January 2018 at 13:08, Peter Maydell <peter.maydell@linaro.org> wrote:
> Some older versions of gcc complain if a typedef is defined twice:
>
> target/xtensa/translate.c:81: error: redefinition of typedef 'DisasContext'
> target/xtensa/cpu.h:339: note: previous declaration of 'DisasContext' was here
>
> Remove the now-redundant typedef from the definition of the struct in
> translate.c.
>
> Reported-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---

...applied to master as a buildfix.

-- PMM