Changeset
tests/docker/dockerfiles/fedora.docker | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Git apply log
Switched to a new branch '1515755504-21341-1-git-send-email-pbonzini@redhat.com'
Applying: docker: change Fedora base image to fedora:27
To https://github.com/patchew-project/qemu
 + 3dbfd569b2...61cd50d4d4 patchew/1515755504-21341-1-git-send-email-pbonzini@redhat.com -> patchew/1515755504-21341-1-git-send-email-pbonzini@redhat.com (forced update)
Test passed: s390x

loading

Test passed: docker

loading

Test passed: checkpatch

loading

Test passed: ppc

loading

[Qemu-devel] [PATCH] docker: change Fedora base image to fedora:27
Posted by Paolo Bonzini, 6 days ago
Using "fedora:latest" makes behavior different depending on when you
actually pulled the image from the docker repository.  In my case,
the supposedly "latest" image was a Fedora 25 download from 8 months
ago, and the new "test-debug" test was failing.

Use "27" to improve reproducibility and make it clear when the image
is obsolete.

Cc: Fam Zheng <famz@redhat.com>
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 tests/docker/dockerfiles/fedora.docker | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
index 32de731..714adad 100644
--- a/tests/docker/dockerfiles/fedora.docker
+++ b/tests/docker/dockerfiles/fedora.docker
@@ -1,4 +1,4 @@
-FROM fedora:latest
+FROM fedora:27
 ENV PACKAGES \
     ccache gettext git tar PyYAML sparse flex bison python2 bzip2 hostname \
     glib2-devel pixman-devel zlib-devel SDL-devel libfdt-devel \
-- 
1.8.3.1


Re: [Qemu-devel] [PATCH] docker: change Fedora base image to fedora:27
Posted by Marc-André Lureau, 6 days ago
Hi

On Fri, Jan 12, 2018 at 12:11 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Using "fedora:latest" makes behavior different depending on when you
> actually pulled the image from the docker repository.  In my case,
> the supposedly "latest" image was a Fedora 25 download from 8 months
> ago, and the new "test-debug" test was failing.
>
> Use "27" to improve reproducibility and make it clear when the image
> is obsolete.

Use rawhide instead? :)

>
> Cc: Fam Zheng <famz@redhat.com>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>


> ---
>  tests/docker/dockerfiles/fedora.docker | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
> index 32de731..714adad 100644
> --- a/tests/docker/dockerfiles/fedora.docker
> +++ b/tests/docker/dockerfiles/fedora.docker
> @@ -1,4 +1,4 @@
> -FROM fedora:latest
> +FROM fedora:27
>  ENV PACKAGES \
>      ccache gettext git tar PyYAML sparse flex bison python2 bzip2 hostname \
>      glib2-devel pixman-devel zlib-devel SDL-devel libfdt-devel \
> --
> 1.8.3.1
>
>



-- 
Marc-André Lureau

Re: [Qemu-devel] [PATCH] docker: change Fedora base image to fedora:27
Posted by Philippe Mathieu-Daudé, 6 days ago
Hi Paolo,

On 01/12/2018 08:11 AM, Paolo Bonzini wrote:
> Using "fedora:latest" makes behavior different depending on when you
> actually pulled the image from the docker repository.  In my case,
> the supposedly "latest" image was a Fedora 25 download from 8 months
> ago, and the new "test-debug" test was failing.
> 
> Use "27" to improve reproducibility and make it clear when the image
> is obsolete.
> 
> Cc: Fam Zheng <famz@redhat.com>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>

I wonder what script you are using, and if the R: tag in MAINTAINERS is
that useful, since I saw few docker patches I'm interestd in but I was
not CC'd:

$ ./scripts/get_maintainer.pl -f tests/docker/dockerfiles/fedora.docker
"Alex Bennée" <alex.bennee@linaro.org> (maintainer:Build and test au...)
Fam Zheng <famz@redhat.com> (maintainer:Build and test au...)
"Philippe Mathieu-Daudé" <f4bug@amsat.org> (reviewer:Build and test au...)

> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  tests/docker/dockerfiles/fedora.docker | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
> index 32de731..714adad 100644
> --- a/tests/docker/dockerfiles/fedora.docker
> +++ b/tests/docker/dockerfiles/fedora.docker
> @@ -1,4 +1,4 @@
> -FROM fedora:latest
> +FROM fedora:27

I'd rather use the deprecation approach like we use for Debian,
see tests/docker/dockerfiles/debian.docker.

That said, you remind me of a series doing the same for Ubuntu I forgot
to send, if you want I can add fedora25 and fedora27 before sending.

Regards,

Phil.

>  ENV PACKAGES \
>      ccache gettext git tar PyYAML sparse flex bison python2 bzip2 hostname \
>      glib2-devel pixman-devel zlib-devel SDL-devel libfdt-devel \
> 

Re: [Qemu-devel] [PATCH] docker: change Fedora base image to fedora:27
Posted by Paolo Bonzini, 6 days ago
On 12/01/2018 12:28, Philippe Mathieu-Daudé wrote:
> Hi Paolo,
> 
> On 01/12/2018 08:11 AM, Paolo Bonzini wrote:
>> Using "fedora:latest" makes behavior different depending on when you
>> actually pulled the image from the docker repository.  In my case,
>> the supposedly "latest" image was a Fedora 25 download from 8 months
>> ago, and the new "test-debug" test was failing.
>>
>> Use "27" to improve reproducibility and make it clear when the image
>> is obsolete.
>>
>> Cc: Fam Zheng <famz@redhat.com>
>> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> I wonder what script you are using, and if the R: tag in MAINTAINERS is
> that useful, since I saw few docker patches I'm interestd in but I was
> not CC'd:

No, it's my fault

> $ ./scripts/get_maintainer.pl -f tests/docker/dockerfiles/fedora.docker
> "Alex Bennée" <alex.bennee@linaro.org> (maintainer:Build and test au...)
> Fam Zheng <famz@redhat.com> (maintainer:Build and test au...)
> "Philippe Mathieu-Daudé" <f4bug@amsat.org> (reviewer:Build and test au...)
> 
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>  tests/docker/dockerfiles/fedora.docker | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
>> index 32de731..714adad 100644
>> --- a/tests/docker/dockerfiles/fedora.docker
>> +++ b/tests/docker/dockerfiles/fedora.docker
>> @@ -1,4 +1,4 @@
>> -FROM fedora:latest
>> +FROM fedora:27
> 
> I'd rather use the deprecation approach like we use for Debian,
> see tests/docker/dockerfiles/debian.docker.
> 
> That said, you remind me of a series doing the same for Ubuntu I forgot
> to send, if you want I can add fedora25 and fedora27 before sending.

That's fine by me (but use "fedora" instead of fedora25).

Paolo

Re: [Qemu-devel] [PATCH] docker: change Fedora base image to fedora:27
Posted by Philippe Mathieu-Daudé, 6 days ago
>>> --- a/tests/docker/dockerfiles/fedora.docker
>>> +++ b/tests/docker/dockerfiles/fedora.docker
>>> @@ -1,4 +1,4 @@
>>> -FROM fedora:latest
>>> +FROM fedora:27
>>
>> I'd rather use the deprecation approach like we use for Debian,
>> see tests/docker/dockerfiles/debian.docker.
>>
>> That said, you remind me of a series doing the same for Ubuntu I forgot
>> to send, if you want I can add fedora25 and fedora27 before sending.
> 
> That's fine by me (but use "fedora" instead of fedora25).

Plan is:

rename fedora -> fedora25
add fedora27
fedora: display a warning and use fedora25 for backward compatibility


Re: [Qemu-devel] [PATCH] docker: change Fedora base image to fedora:27
Posted by Philippe Mathieu-Daudé, 6 days ago
On 01/12/2018 08:11 AM, Paolo Bonzini wrote:
> Using "fedora:latest" makes behavior different depending on when you
> actually pulled the image from the docker repository.  In my case,
> the supposedly "latest" image was a Fedora 25 download from 8 months
> ago, and the new "test-debug" test was failing.

Checking git log, this file was updated in a2bd7252fe8b to support
Fedora 24, not even 25 :)

I suppose a8f159d45bcb was to have Fedora 25 working.

> 
> Use "27" to improve reproducibility and make it clear when the image
> is obsolete.