[v6] virtio: introduce `info virtio' hmp command

[Qemu-devel] [RFC v6 0/2] virtio: introduce `info virtio' hmp command

Jan Dakinevich posted 2 patches 6 years, 4 months ago

Diff against v1 v2 v3 v4 v5
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1513542355-28203-1-git-send-email-jan.dakinevich@virtuozzo.com

Test checkpatch passed

Test docker passed

Test ppc passed

Test s390x passed

hmp-commands-info.hx        |  14 +++++
hmp.c                       |  74 ++++++++++++++++++++++++
hmp.h                       |   1 +
hw/block/virtio-blk.c       |  20 +++++++
hw/char/virtio-serial-bus.c |  14 +++++
hw/display/virtio-gpu.c     |  12 ++++
hw/net/virtio-net.c         |  34 +++++++++++
hw/scsi/virtio-scsi.c       |  15 +++++
hw/virtio/Makefile.objs     |   3 +
hw/virtio/virtio-balloon.c  |  14 +++++
hw/virtio/virtio-qmp.c      | 134 ++++++++++++++++++++++++++++++++++++++++++++
hw/virtio/virtio-stub.c     |   9 +++
hw/virtio/virtio.c          |  41 ++++++++++++++
include/hw/virtio/virtio.h  |   6 ++
qapi-schema.json            |  70 +++++++++++++++++++++++
15 files changed, 461 insertions(+)
create mode 100644 hw/virtio/virtio-qmp.c
create mode 100644 hw/virtio/virtio-stub.c

Expand all Fold all

[Qemu-devel] [RFC v6 0/2] virtio: introduce `info virtio' hmp command

Posted by Jan Dakinevich 6 years, 4 months ago

From: Jan Dakinevich <jan.dakinevich@gmail.com>

After some discussion, I am going to suggest reworked QMP/HMP for
gathering virtio info. It would provide the following monitor output.

(qemu) info virtio
virtio-blk-device at 0000:00:02.0
  QOM path: /machine/peripheral-anon/device[0]/virtio-backend
  status: 0x0f
    VIRTIO_CONFIG_S_ACKNOWLEDGE
    VIRTIO_CONFIG_S_DRIVER
    VIRTIO_CONFIG_S_DRIVER_OK
    VIRTIO_CONFIG_S_FEATURES_OK
  host features:  0x0000000179000e54
  guest features: 0x0000000130000e54
  common features:
    VIRTIO_F_NOTIFY_ON_EMPTY
    VIRTIO_F_ANY_LAYOUT
    VIRTIO_RING_F_INDIRECT_DESC              acked
    VIRTIO_RING_F_EVENT_IDX                  acked
    VIRTIO_F_BAD_FEATURE
    VIRTIO_F_VERSION_1                       acked
  device features:
    VIRTIO_BLK_F_SEG_MAX                     acked
    VIRTIO_BLK_F_BLK_SIZE                    acked
    VIRTIO_BLK_F_FLUSH                       acked
    VIRTIO_BLK_F_TOPOLOGY                    acked

v5: http://lists.nongnu.org/archive/html/qemu-devel/2017-10/msg05667.html
v4: http://lists.nongnu.org/archive/html/qemu-devel/2017-10/msg00393.html
v3: http://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg07565.html
v2: http://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg07527.html
v1: http://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg07247.html

Jan Dakinevich (2):
  virtio: introduce `query-virtio' QMP command
  virtio: add `info virtio' HMP command

 hmp-commands-info.hx        |  14 +++++
 hmp.c                       |  74 ++++++++++++++++++++++++
 hmp.h                       |   1 +
 hw/block/virtio-blk.c       |  20 +++++++
 hw/char/virtio-serial-bus.c |  14 +++++
 hw/display/virtio-gpu.c     |  12 ++++
 hw/net/virtio-net.c         |  34 +++++++++++
 hw/scsi/virtio-scsi.c       |  15 +++++
 hw/virtio/Makefile.objs     |   3 +
 hw/virtio/virtio-balloon.c  |  14 +++++
 hw/virtio/virtio-qmp.c      | 134 ++++++++++++++++++++++++++++++++++++++++++++
 hw/virtio/virtio-stub.c     |   9 +++
 hw/virtio/virtio.c          |  41 ++++++++++++++
 include/hw/virtio/virtio.h  |   6 ++
 qapi-schema.json            |  70 +++++++++++++++++++++++
 15 files changed, 461 insertions(+)
 create mode 100644 hw/virtio/virtio-qmp.c
 create mode 100644 hw/virtio/virtio-stub.c

--
2.1.4