ide: abort TRIM operation for invalid range

[Qemu-devel] [PATCH 0/3] ide: abort TRIM operation for invalid range

Anton Nefedov posted 3 patches 6 years, 4 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1512735034-35327-1-git-send-email-anton.nefedov@virtuozzo.com

Test checkpatch passed

Test docker passed

Test ppc passed

Test s390x passed

hw/ide/core.c | 53 +++++++++++++++++++++++++++++++++--------------------
1 file changed, 33 insertions(+), 20 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH 0/3] ide: abort TRIM operation for invalid range

Posted by Anton Nefedov 6 years, 4 months ago

Started from the separate series discussion (trim statistics) , see
http://lists.nongnu.org/archive/html/qemu-devel/2017-12/msg01059.html

There is no range check for IDE trim requests now.
Such request will likely be rejected by the block layer and count as
failed and not an invalid/aborted operation.

Anton Nefedov (3):
  ide: pass IDEState to trim AIO callback
  ide: move ide_sect_range_ok() up
  ide: abort TRIM operation for invalid range

 hw/ide/core.c | 53 +++++++++++++++++++++++++++++++++--------------------
 1 file changed, 33 insertions(+), 20 deletions(-)

-- 
2.7.4

Re: [Qemu-devel] [PATCH 0/3] ide: abort TRIM operation for invalid range

Posted by John Snow 6 years, 4 months ago


On 12/08/2017 07:10 AM, Anton Nefedov wrote:
> Started from the separate series discussion (trim statistics) , see
> http://lists.nongnu.org/archive/html/qemu-devel/2017-12/msg01059.html
> 
> There is no range check for IDE trim requests now.
> Such request will likely be rejected by the block layer and count as
> failed and not an invalid/aborted operation.
> 
> Anton Nefedov (3):
>   ide: pass IDEState to trim AIO callback
>   ide: move ide_sect_range_ok() up
>   ide: abort TRIM operation for invalid range
> 
>  hw/ide/core.c | 53 +++++++++++++++++++++++++++++++++--------------------
>  1 file changed, 33 insertions(+), 20 deletions(-)
> 

Thanks, applied to my IDE tree:

https://github.com/jnsnow/qemu/commits/ide
https://github.com/jnsnow/qemu.git

--js

(PR won't be sent until after the 2.12 tree opens.)

Re: [Qemu-devel] [PATCH 0/3] ide: abort TRIM operation for invalid range

Posted by John Snow 6 years, 2 months ago


On 12/08/2017 07:10 AM, Anton Nefedov wrote:
> Started from the separate series discussion (trim statistics) , see
> http://lists.nongnu.org/archive/html/qemu-devel/2017-12/msg01059.html
> 
> There is no range check for IDE trim requests now.
> Such request will likely be rejected by the block layer and count as
> failed and not an invalid/aborted operation.
> 
> Anton Nefedov (3):
>   ide: pass IDEState to trim AIO callback
>   ide: move ide_sect_range_ok() up
>   ide: abort TRIM operation for invalid range
> 
>  hw/ide/core.c | 53 +++++++++++++++++++++++++++++++++--------------------
>  1 file changed, 33 insertions(+), 20 deletions(-)
> 

I forgot about this series due to the 2.11 freeze and winter break. It
appears to still apply, so I'll send it along.