From nobody Sat May 4 02:33:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1511912238253676.7784809422651; Tue, 28 Nov 2017 15:37:18 -0800 (PST) Received: from localhost ([::1]:40547 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJpR7-0006NA-2M for importer@patchew.org; Tue, 28 Nov 2017 18:37:09 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJncQ-0002yI-Bk for qemu-devel@nongnu.org; Tue, 28 Nov 2017 16:40:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJncL-0001Jx-GC for qemu-devel@nongnu.org; Tue, 28 Nov 2017 16:40:42 -0500 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:33040) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eJncL-0001JH-8W for qemu-devel@nongnu.org; Tue, 28 Nov 2017 16:40:37 -0500 Received: by mail-lf0-x244.google.com with SMTP id 74so1531048lfs.0 for ; Tue, 28 Nov 2017 13:40:36 -0800 (PST) Received: from localhost.localdomain ([195.254.138.66]) by smtp.gmail.com with ESMTPSA id p73sm26658lfp.9.2017.11.28.13.40.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 28 Nov 2017 13:40:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=yaUm+m8jnCq59DQO6P4/xz2noC/VnNM9Fs2YcCm3T1Y=; b=WLtA1RZV8wIJfHTuJkjstMa3eSeh/bt5VPgUKzOqQeENnSxWDQBgQh/ZKLM1zFbht7 iG6Y98vq38MuOKpTjT7JZXluo+aMTWzgYty9y3mb09rWJPUNBvj6TkZpN0wV3lAJW35z mCEye3y4HatEXJmRwwwI+kLnKE2q/w12kKpXmJgBJ4PqpAQOdbnFk3xwgPfporR8VSDr X8PuoWNbCH5gFipbYLY7/h3zxklcWYI45ius7JxD58y+uBQgpgkOWvsqoN7L0eUwAoO8 gAAzA4E3E52DW+3z2SyB8uvwtVVwQ2vho67g0/aVPPZI4IRyD0X9q2K38xUBuaw7yWzD 63hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=yaUm+m8jnCq59DQO6P4/xz2noC/VnNM9Fs2YcCm3T1Y=; b=LLf4fK9Z+5+4V1XAGTN8T78gutTm54OSlwtJReCy9Gnb4HVVHblh8dQ0vdTTcol4+Q +2cUvBzxq54A2kqFPVEsadPHSjxsuKo/cRVpVUepH8ifwRZ1AfiLhHfNDkUEF0U1jZe8 MfuD8NMS9qGlwm7WcZEJIYWf406EG1WrL9Fgme+iziLh8AdI1AQowPYosae4ZWjaGloC 4XIP1Y2Of/B7O4/ARjREysZ7Pw9emTcIfUz9PZDIpRbJrIB7C23wx8ft0jZ792kN0UuO 8YupN4fZVD/gz+NB/M2zN05R9y06mc+UjJ9y2rwaTTk2NNK9XxYfw9V6Fb3hbl9/oLZz w7zA== X-Gm-Message-State: AJaThX7TPj3yGET/f/wqMHvTTqqXok91gQrEeDesG40E7ysA6ozY8YTS LlVub1K/Wm/mPTHQ+047j5Q= X-Google-Smtp-Source: AGs4zMZ3r4TaF0K8HXjxHTn4ujxldP17bH35+jaxE01uxDtyuOdpyxXRRqbLdPf2KDXaAtS0upepjw== X-Received: by 10.46.48.6 with SMTP id w6mr253195ljw.10.1511905235763; Tue, 28 Nov 2017 13:40:35 -0800 (PST) From: Vasyl Gomonovych To: somlo@cmu.edu, mst@redhat.com, qemu-devel@nongnu.org Date: Tue, 28 Nov 2017 22:40:27 +0100 Message-Id: <1511905227-30292-1-git-send-email-gomonovych@gmail.com> X-Mailer: git-send-email 1.9.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::244 X-Mailman-Approved-At: Tue, 28 Nov 2017 18:35:38 -0500 Subject: [Qemu-devel] [PATCH] firmware: Use PTR_ERR_OR_ZERO() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gomonovych@gmail.com, linux-kernel@vger.kernel.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Fix ptr_ret.cocci warnings: drivers/firmware/efi/efi.c:610:8-14: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Signed-off-by: Vasyl Gomonovych Acked-by: Gabriel Somlo Reviewed-by: Stefan Hajnoczi --- drivers/firmware/qemu_fw_cfg.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index 5cfe39f7a45f..18489b6a696d 100644 --- a/drivers/firmware/qemu_fw_cfg.c +++ b/drivers/firmware/qemu_fw_cfg.c @@ -693,10 +693,8 @@ static int fw_cfg_cmdline_set(const char *arg, const s= truct kernel_param *kp) */ fw_cfg_cmdline_dev =3D platform_device_register_simple("fw_cfg", PLATFORM_DEVID_NONE, res, processed); - if (IS_ERR(fw_cfg_cmdline_dev)) - return PTR_ERR(fw_cfg_cmdline_dev); =20 - return 0; + return PTR_ERR_OR_ZERO(fw_cfg_cmdline_dev); } =20 static int fw_cfg_cmdline_get(char *buf, const struct kernel_param *kp) --=20 1.9.1