From nobody Thu May 2 09:50:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1511505178754437.4069044244379; Thu, 23 Nov 2017 22:32:58 -0800 (PST) Received: from localhost ([::1]:47443 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eI7Xi-00033q-Vz for importer@patchew.org; Fri, 24 Nov 2017 01:32:55 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40542) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eI7WP-00028J-P1 for qemu-devel@nongnu.org; Fri, 24 Nov 2017 01:31:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eI7WM-00066P-8W for qemu-devel@nongnu.org; Fri, 24 Nov 2017 01:31:33 -0500 Received: from mga07.intel.com ([134.134.136.100]:59862) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eI7WM-00065g-1T for qemu-devel@nongnu.org; Fri, 24 Nov 2017 01:31:30 -0500 Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Nov 2017 22:31:28 -0800 Received: from yangzhon-virtual.bj.intel.com ([10.238.145.49]) by fmsmga006.fm.intel.com with ESMTP; 23 Nov 2017 22:31:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,445,1505804400"; d="scan'208";a="179944439" From: Yang Zhong To: qemu-devel@nongnu.org Date: Fri, 24 Nov 2017 14:30:30 +0800 Message-Id: <1511505030-3669-1-git-send-email-yang.zhong@intel.com> X-Mailer: git-send-email 1.9.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.100 Subject: [Qemu-devel] [PATCH v3] rcu: reduce more than 7MB heap memory by malloc_trim() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yang.zhong@intel.com, zhang.zhanghailiang@huawei.com, liujunjie23@huawei.com, wangxinxin.wang@huawei.com, stone.xulei@huawei.com, arei.gonglei@huawei.com, stefanha@redhat.com, pbonzini@redhat.com, weidong.huang@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Since there are some issues in memory alloc/free machenism in glibc for little chunk memory, if Qemu frequently alloc/free little chunk memory, the glibc doesn't alloc little chunk memory from free list of glibc and still allocate from OS, which make the heap size bigger and bigger. This patch introduce malloc_trim(), which will free heap memory. Below are test results from smaps file. (1)without patch 55f0783e1000-55f07992a000 rw-p 00000000 00:00 0 [heap] Size: 21796 kB Rss: 14260 kB Pss: 14260 kB (2)with patch 55cc5fadf000-55cc61008000 rw-p 00000000 00:00 0 [heap] Size: 21668 kB Rss: 6940 kB Pss: 6940 kB Signed-off-by: Yang Zhong --- configure | 29 +++++++++++++++++++++++++++++ util/rcu.c | 6 ++++++ 2 files changed, 35 insertions(+) diff --git a/configure b/configure index 0c6e757..6292ab0 100755 --- a/configure +++ b/configure @@ -426,6 +426,7 @@ vxhs=3D"" supported_cpu=3D"no" supported_os=3D"no" bogus_os=3D"no" +malloc_trim=3D"yes" =20 # parse CC options first for opt do @@ -3857,6 +3858,30 @@ if test "$tcmalloc" =3D "yes" && test "$jemalloc" = =3D "yes" ; then exit 1 fi =20 +# Even if malloc_trim() is available, these non-libc memory allocators +# do not support it. +if test "$tcmalloc" =3D "yes" || test "$jemalloc" =3D "yes" ; then + if test "$malloc_trim" =3D "yes" ; then + echo "Disabling malloc_trim with non-libc memory allocator" + fi + malloc_trim=3D"no" +fi + +####################################### +# malloc_trim + +if test "$malloc_trim" !=3D "no" ; then + cat > $TMPC << EOF +#include +int main(void) { malloc_trim(0); return 0; } +EOF + if compile_prog "" "" ; then + malloc_trim=3D"yes" + else + malloc_trim=3D"no" + fi +fi + ########################################## # tcmalloc probe =20 @@ -6012,6 +6037,10 @@ if test "$opengl" =3D "yes" ; then fi fi =20 +if test "$malloc_trim" =3D "yes" ; then + echo "CONFIG_MALLOC_TRIM=3Dy" >> $config_host_mak +fi + if test "$avx2_opt" =3D "yes" ; then echo "CONFIG_AVX2_OPT=3Dy" >> $config_host_mak fi diff --git a/util/rcu.c b/util/rcu.c index ca5a63e..f403b77 100644 --- a/util/rcu.c +++ b/util/rcu.c @@ -32,6 +32,9 @@ #include "qemu/atomic.h" #include "qemu/thread.h" #include "qemu/main-loop.h" +#if defined(CONFIG_MALLOC_TRIM) +#include +#endif =20 /* * Global grace period counter. Bit 0 is always one in rcu_gp_ctr. @@ -272,6 +275,9 @@ static void *call_rcu_thread(void *opaque) node->func(node); } qemu_mutex_unlock_iothread(); +#if defined(CONFIG_MALLOC_TRIM) + malloc_trim(4 * 1024 * 1024); +#endif } abort(); } --=20 1.9.1