From nobody Sat May 4 02:31:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1511419399959214.7842105312278; Wed, 22 Nov 2017 22:43:19 -0800 (PST) Received: from localhost ([::1]:42731 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eHlE3-00017F-5c for importer@patchew.org; Thu, 23 Nov 2017 01:43:07 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53349) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eHlDJ-0000qV-W4 for qemu-devel@nongnu.org; Thu, 23 Nov 2017 01:42:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eHlDF-00052e-8h for qemu-devel@nongnu.org; Thu, 23 Nov 2017 01:42:22 -0500 Received: from mga01.intel.com ([192.55.52.88]:52827) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eHlDE-00051t-WE for qemu-devel@nongnu.org; Thu, 23 Nov 2017 01:42:17 -0500 Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Nov 2017 22:42:15 -0800 Received: from yangzhon-virtual.bj.intel.com ([10.238.145.49]) by fmsmga005.fm.intel.com with ESMTP; 22 Nov 2017 22:42:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,440,1505804400"; d="scan'208";a="179153329" From: Yang Zhong To: qemu-devel@nongnu.org Date: Thu, 23 Nov 2017 14:41:16 +0800 Message-Id: <1511419276-31212-1-git-send-email-yang.zhong@intel.com> X-Mailer: git-send-email 1.9.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.88 Subject: [Qemu-devel] [PATCH v2] rcu: reduce more than 7MB heap memory by malloc_trim() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yang.zhong@intel.com, zhang.zhanghailiang@huawei.com, liujunjie23@huawei.com, wangxinxin.wang@huawei.com, stone.xulei@huawei.com, arei.gonglei@huawei.com, stefanha@redhat.com, pbonzini@redhat.com, weidong.huang@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Since there are some issues in memory alloc/free machenism in glibc for little chunk memory, if Qemu frequently alloc/free little chunk memory, the glibc doesn't alloc little chunk memory from free list of glibc and still allocate from OS, which make the heap size bigger and bigger. This patch introduce malloc_trim(), which will free heap memory. Below are test results from smaps file. (1)without patch 55f0783e1000-55f07992a000 rw-p 00000000 00:00 0 [heap] Size: 21796 kB Rss: 14260 kB Pss: 14260 kB (2)with patch 55cc5fadf000-55cc61008000 rw-p 00000000 00:00 0 [heap] Size: 21668 kB Rss: 6940 kB Pss: 6940 kB Signed-off-by: Yang Zhong --- configure | 4 ++++ util/rcu.c | 6 ++++++ 2 files changed, 10 insertions(+) diff --git a/configure b/configure index 0e856bb..5b463d4 100755 --- a/configure +++ b/configure @@ -6012,6 +6012,10 @@ if test "$opengl" =3D "yes" ; then fi fi =20 +if test "$tcmalloc" =3D "yes" || test "$jemalloc" =3D "yes" ; then + echo "CONFIG_NONGLIBMALLOC=3Dy" >> $config_host_mak +fi + if test "$avx2_opt" =3D "yes" ; then echo "CONFIG_AVX2_OPT=3Dy" >> $config_host_mak fi diff --git a/util/rcu.c b/util/rcu.c index ca5a63e..f3e96a8 100644 --- a/util/rcu.c +++ b/util/rcu.c @@ -32,6 +32,9 @@ #include "qemu/atomic.h" #include "qemu/thread.h" #include "qemu/main-loop.h" +#if defined(CONFIG_LINUX) +#include +#endif =20 /* * Global grace period counter. Bit 0 is always one in rcu_gp_ctr. @@ -272,6 +275,9 @@ static void *call_rcu_thread(void *opaque) node->func(node); } qemu_mutex_unlock_iothread(); +#if defined(CONFIG_LINUX) && !defined(CONFIG_NONGLIBMALLOC) + malloc_trim(4 * 1024 * 1024); +#endif } abort(); } --=20 1.9.1