accel/tcg/cpu-exec-common.c: Remove unnecessary include of memory-internal.h

[Qemu-devel] [PATCH] accel/tcg/cpu-exec-common.c: Remove unnecessary include of memory-internal.h

Peter Maydell posted 1 patch 6 years, 4 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1511276851-17680-1-git-send-email-peter.maydell@linaro.org

Test checkpatch passed

Test docker passed

Test ppc passed

Test s390x passed

accel/tcg/cpu-exec-common.c | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] accel/tcg/cpu-exec-common.c: Remove unnecessary include of memory-internal.h

Posted by Peter Maydell 6 years, 4 months ago

The cpu-exec-common.c file includes memory-internal.h, but it doesn't
actually use anything from that header. Remove the unnecessary include.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 accel/tcg/cpu-exec-common.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/accel/tcg/cpu-exec-common.c b/accel/tcg/cpu-exec-common.c
index 5b4ae54..dac5aac 100644
--- a/accel/tcg/cpu-exec-common.c
+++ b/accel/tcg/cpu-exec-common.c
@@ -21,7 +21,6 @@
 #include "cpu.h"
 #include "sysemu/cpus.h"
 #include "exec/exec-all.h"
-#include "exec/memory-internal.h"
 
 bool tcg_allowed;
 
-- 
2.7.4

Re: [Qemu-devel] [PATCH] accel/tcg/cpu-exec-common.c: Remove unnecessary include of memory-internal.h

Posted by Philippe Mathieu-Daudé 6 years, 4 months ago

On 11/21/2017 12:07 PM, Peter Maydell wrote:
> The cpu-exec-common.c file includes memory-internal.h, but it doesn't
> actually use anything from that header. Remove the unnecessary include.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  accel/tcg/cpu-exec-common.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/accel/tcg/cpu-exec-common.c b/accel/tcg/cpu-exec-common.c
> index 5b4ae54..dac5aac 100644
> --- a/accel/tcg/cpu-exec-common.c
> +++ b/accel/tcg/cpu-exec-common.c
> @@ -21,7 +21,6 @@
>  #include "cpu.h"
>  #include "sysemu/cpus.h"
>  #include "exec/exec-all.h"
> -#include "exec/memory-internal.h"
>  
>  bool tcg_allowed;
>  
>

Re: [Qemu-devel] [PATCH] accel/tcg/cpu-exec-common.c: Remove unnecessary include of memory-internal.h

Posted by Richard Henderson 6 years, 4 months ago

On 11/21/2017 04:07 PM, Peter Maydell wrote:
> The cpu-exec-common.c file includes memory-internal.h, but it doesn't
> actually use anything from that header. Remove the unnecessary include.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  accel/tcg/cpu-exec-common.c | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~