[Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1

Michael S. Tsirkin posted 10 patches 6 years, 5 months ago
Only 9 patches received!
default-configs/arm-softmmu.mak      |   2 ++
default-configs/i386-softmmu.mak     |   1 +
default-configs/x86_64-softmmu.mak   |   1 +
include/hw/boards.h                  |   1 +
include/hw/i386/pc.h                 |  10 ++++++++-
include/hw/pci-host/q35.h            |   1 +
hw/i386/pc.c                         |  23 +++++++++++++++++++
hw/i386/pc_piix.c                    |   1 +
hw/i386/pc_q35.c                     |   1 +
hw/misc/vmcoreinfo.c                 |   1 +
hw/pci-host/piix.c                   |  32 ++++++++++++++++++++++++--
hw/pci-host/q35.c                    |  42 ++++++++++++++++++++++++++++++++---
hw/pci/pci.c                         |   2 +-
hw/virtio/virtio.c                   |   1 +
numa.c                               |  21 +++++++++++++++++-
tests/bios-tables-test.c             |  26 ++++++++++++++++------
vl.c                                 |   3 +--
hw/misc/Makefile.objs                |   2 +-
hw/pci-bridge/Makefile.objs          |   4 ++--
tests/acpi-test-data/pc/DSDT         | Bin 5098 -> 5144 bytes
tests/acpi-test-data/pc/DSDT.bridge  | Bin 6957 -> 7003 bytes
tests/acpi-test-data/pc/DSDT.cphp    | Bin 5561 -> 5607 bytes
tests/acpi-test-data/pc/DSDT.ipmikcs | Bin 5170 -> 5216 bytes
tests/acpi-test-data/pc/DSDT.memhp   | Bin 6463 -> 6509 bytes
tests/acpi-test-data/q35/DSDT        | Bin 7782 -> 7828 bytes
tests/acpi-test-data/q35/DSDT.bridge | Bin 7799 -> 7845 bytes
tests/acpi-test-data/q35/DSDT.cphp   | Bin 8245 -> 8291 bytes
tests/acpi-test-data/q35/DSDT.ipmibt | Bin 7857 -> 7903 bytes
tests/acpi-test-data/q35/DSDT.memhp  | Bin 9147 -> 9193 bytes
29 files changed, 155 insertions(+), 20 deletions(-)
[Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1
Posted by Michael S. Tsirkin 6 years, 5 months ago
The following changes since commit 1fa0f627d03cd0d0755924247cafeb42969016bf:

  Update version for v2.11.0-rc1 release (2017-11-14 18:37:49 +0000)

are available in the git repository at:

  git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream

for you to fetch changes up to 6ed0c1c3ab0925009d15cffb944d9ccb04718846:

  build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets (2017-11-15 20:13:13 +0200)

----------------------------------------------------------------
pc, pci, virtio: fixes for rc1

A bunch of fixes all over the place.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

----------------------------------------------------------------
Alexey Kardashevskiy (1):
      pci: Initialize pci_dev->name before use

Daniel P. Berrange (2):
      tests: report errors when iasl exits with non-zero status
      test: fix detection of errors from iasl

Dou Liyang (1):
      NUMA: Enable adding NUMA node implicitly

Marc-André Lureau (2):
      vmcoreinfo: put it in the 'misc' device category
      build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets

Marcel Apfelbaum (2):
      hw/pci-host: Fix x86 Host Bridges 64bit PCI hole
      hw/pcie-pci-bridge: restrict to X86 and ARM

Michael S. Tsirkin (1):
      tests/acpi-test-data: update _CRS in DSDT

linzhecheng (1):
      fix: unrealize virtio device if we fail to hotplug it

 default-configs/arm-softmmu.mak      |   2 ++
 default-configs/i386-softmmu.mak     |   1 +
 default-configs/x86_64-softmmu.mak   |   1 +
 include/hw/boards.h                  |   1 +
 include/hw/i386/pc.h                 |  10 ++++++++-
 include/hw/pci-host/q35.h            |   1 +
 hw/i386/pc.c                         |  23 +++++++++++++++++++
 hw/i386/pc_piix.c                    |   1 +
 hw/i386/pc_q35.c                     |   1 +
 hw/misc/vmcoreinfo.c                 |   1 +
 hw/pci-host/piix.c                   |  32 ++++++++++++++++++++++++--
 hw/pci-host/q35.c                    |  42 ++++++++++++++++++++++++++++++++---
 hw/pci/pci.c                         |   2 +-
 hw/virtio/virtio.c                   |   1 +
 numa.c                               |  21 +++++++++++++++++-
 tests/bios-tables-test.c             |  26 ++++++++++++++++------
 vl.c                                 |   3 +--
 hw/misc/Makefile.objs                |   2 +-
 hw/pci-bridge/Makefile.objs          |   4 ++--
 tests/acpi-test-data/pc/DSDT         | Bin 5098 -> 5144 bytes
 tests/acpi-test-data/pc/DSDT.bridge  | Bin 6957 -> 7003 bytes
 tests/acpi-test-data/pc/DSDT.cphp    | Bin 5561 -> 5607 bytes
 tests/acpi-test-data/pc/DSDT.ipmikcs | Bin 5170 -> 5216 bytes
 tests/acpi-test-data/pc/DSDT.memhp   | Bin 6463 -> 6509 bytes
 tests/acpi-test-data/q35/DSDT        | Bin 7782 -> 7828 bytes
 tests/acpi-test-data/q35/DSDT.bridge | Bin 7799 -> 7845 bytes
 tests/acpi-test-data/q35/DSDT.cphp   | Bin 8245 -> 8291 bytes
 tests/acpi-test-data/q35/DSDT.ipmibt | Bin 7857 -> 7903 bytes
 tests/acpi-test-data/q35/DSDT.memhp  | Bin 9147 -> 9193 bytes
 29 files changed, 155 insertions(+), 20 deletions(-)


Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1
Posted by Peter Maydell 6 years, 5 months ago
On 15 November 2017 at 18:17, Michael S. Tsirkin <mst@redhat.com> wrote:
> The following changes since commit 1fa0f627d03cd0d0755924247cafeb42969016bf:
>
>   Update version for v2.11.0-rc1 release (2017-11-14 18:37:49 +0000)
>
> are available in the git repository at:
>
>   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
>
> for you to fetch changes up to 6ed0c1c3ab0925009d15cffb944d9ccb04718846:
>
>   build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets (2017-11-15 20:13:13 +0200)
>
> ----------------------------------------------------------------
> pc, pci, virtio: fixes for rc1
>
> A bunch of fixes all over the place.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Hi. This failed tests on a couple of machines:

s390x:

TEST: tests/bios-tables-test... (pid=58925)
  /i386/acpi/piix4:
Looking for expected file 'tests/acpi-test-data/pc/DSDT'

Using expected file 'tests/acpi-test-data/pc/DSDT'

Looking for expected file 'tests/acpi-test-data/pc/APIC'

Using expected file 'tests/acpi-test-data/pc/APIC'

Looking for expected file 'tests/acpi-test-data/pc/HPET'

Using expected file 'tests/acpi-test-data/pc/HPET'
'iasl -p /tmp/asl-CHIM9Y.dsl -d tests/acpi-test-data/pc/DSDT' exited
with status 65280
Intel ACPI Component Architecture
ASL+ Optimizing Compiler version 20160108-64
Copyright (c) 2000 - 2016 Intel Corporation

Could not get ACPI tables from tests/acpi-test-data/pc/DSDT, AE_BAD_HEADER
Input file tests/acpi-test-data/pc/DSDT, Length 0x1418 (5144) bytes
Table [DSDT] is too long for file - needs: 0x18140000, remaining in file: 0x1418
**
ERROR:/home/linux1/qemu/tests/bios-tables-test.c:461:test_acpi_asl:
assertion failed: (!err && !exp_err)
FAIL
GTester: last random seed: R02S7430f83941b25a926c586492b2745d2c
(pid=58933)
  /i386/acpi/q35:
Looking for expected file 'tests/acpi-test-data/q35/DSDT'

Using expected file 'tests/acpi-test-data/q35/DSDT'

Looking for expected file 'tests/acpi-test-data/q35/APIC'

Using expected file 'tests/acpi-test-data/q35/APIC'

Looking for expected file 'tests/acpi-test-data/q35/HPET'

Using expected file 'tests/acpi-test-data/q35/HPET'

Looking for expected file 'tests/acpi-test-data/q35/MCFG'

Using expected file 'tests/acpi-test-data/q35/MCFG'
'iasl -p /tmp/asl-NRWT9Y.dsl -d tests/acpi-test-data/q35/DSDT' exited
with status 65280
Intel ACPI Component Architecture
ASL+ Optimizing Compiler version 20160108-64
Copyright (c) 2000 - 2016 Intel Corporation

Could not get ACPI tables from tests/acpi-test-data/q35/DSDT, AE_BAD_HEADER
Input file tests/acpi-test-data/q35/DSDT, Length 0x1E94 (7828) bytes
Table [DSDT] is too long for file - needs: 0x941E0000, remaining in file: 0x1E94
**
ERROR:/home/linux1/qemu/tests/bios-tables-test.c:461:test_acpi_asl:
assertion failed: (!err && !exp_err)
FAIL

& similarly for a bunch of other tests. Looks like an
endianness issue.

and on 32-bit arm:

TEST: tests/bios-tables-test... (pid=30809)
  /i386/acpi/piix4:
Looking for expected file 'tests/acpi-test-data/pc/DSDT'

Using expected file 'tests/acpi-test-data/pc/DSDT'

Looking for expected file 'tests/acpi-test-data/pc/APIC'

Using expected file 'tests/acpi-test-data/pc/APIC'

Looking for expected file 'tests/acpi-test-data/pc/HPET'

Using expected file 'tests/acpi-test-data/pc/HPET'
'iasl -p /tmp/asl-6T2N9Y.dsl -e /tmp/aml-TV2N9Y -d /tmp/aml-TV2N9Y'
exited with status 11Input file /tmp/aml-TV2N9Y, Length 0x1418 (5144)
bytes
ACPI: DSDT 0x0000000000000000 001418 (v01 BOCHS  BXPCDSDT 00000001
BXPC 00000001)
Pass 1 parse of [DSDT]
Pass 2 parse of [DSDT]
Parsing Deferred Opcodes (Methods/Buffers/Packages/Regions)

Parsing completed
'iasl -p /tmp/asl-PKDO9Y.dsl -e tests/acpi-test-data/pc/DSDT -d
tests/acpi-test-data/pc/DSDT' exited with status 11Input file
tests/acpi-test-data/pc/DSDT, Length 0x1418 (5144) bytes
ACPI: DSDT 0x0000000000000000 001418 (v01 BOCHS  BXPCDSDT 00000001
BXPC 00000001)
Pass 1 parse of [DSDT]
Pass 2 parse of [DSDT]
Parsing Deferred Opcodes (Methods/Buffers/Packages/Regions)

Parsing completed
**
ERROR:/home/peter.maydell/qemu/tests/bios-tables-test.c:461:test_acpi_asl:
assertion failed: (!err && !exp_err)
FAIL
GTester: last random seed: R02S5d06952865b5a6ffb8443ae4d324e880
(pid=30816)
  /i386/acpi/q35:
Looking for expected file 'tests/acpi-test-data/q35/DSDT'

Using expected file 'tests/acpi-test-data/q35/DSDT'

Looking for expected file 'tests/acpi-test-data/q35/APIC'

Using expected file 'tests/acpi-test-data/q35/APIC'

Looking for expected file 'tests/acpi-test-data/q35/HPET'

Using expected file 'tests/acpi-test-data/q35/HPET'

Looking for expected file 'tests/acpi-test-data/q35/MCFG'

Using expected file 'tests/acpi-test-data/q35/MCFG'
OK

(and similar fails in other tests)


thanks
-- PMM

Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1
Posted by Thomas Huth 6 years, 5 months ago
On 16.11.2017 15:41, Peter Maydell wrote:
> On 15 November 2017 at 18:17, Michael S. Tsirkin <mst@redhat.com> wrote:
>> The following changes since commit 1fa0f627d03cd0d0755924247cafeb42969016bf:
>>
>>   Update version for v2.11.0-rc1 release (2017-11-14 18:37:49 +0000)
>>
>> are available in the git repository at:
>>
>>   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
>>
>> for you to fetch changes up to 6ed0c1c3ab0925009d15cffb944d9ccb04718846:
>>
>>   build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets (2017-11-15 20:13:13 +0200)
>>
>> ----------------------------------------------------------------
>> pc, pci, virtio: fixes for rc1
>>
>> A bunch of fixes all over the place.
>>
>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> 
> Hi. This failed tests on a couple of machines:
> 
> s390x:
> 
> TEST: tests/bios-tables-test... (pid=58925)
>   /i386/acpi/piix4:
> Looking for expected file 'tests/acpi-test-data/pc/DSDT'
> 
> Using expected file 'tests/acpi-test-data/pc/DSDT'
> 
> Looking for expected file 'tests/acpi-test-data/pc/APIC'
> 
> Using expected file 'tests/acpi-test-data/pc/APIC'
> 
> Looking for expected file 'tests/acpi-test-data/pc/HPET'
> 
> Using expected file 'tests/acpi-test-data/pc/HPET'
> 'iasl -p /tmp/asl-CHIM9Y.dsl -d tests/acpi-test-data/pc/DSDT' exited
> with status 65280
> Intel ACPI Component Architecture
> ASL+ Optimizing Compiler version 20160108-64
> Copyright (c) 2000 - 2016 Intel Corporation
> 
> Could not get ACPI tables from tests/acpi-test-data/pc/DSDT, AE_BAD_HEADER
> Input file tests/acpi-test-data/pc/DSDT, Length 0x1418 (5144) bytes
> Table [DSDT] is too long for file - needs: 0x18140000, remaining in file: 0x1418
> **
> ERROR:/home/linux1/qemu/tests/bios-tables-test.c:461:test_acpi_asl:
> assertion failed: (!err && !exp_err)

That likely means that either iasl does not contain the right endianess
fixes yet (which OS are you using there?), or you need my patch here:

 https://lists.gnu.org/archive/html/qemu-devel/2017-11/msg03007.html

No clue about the arm issue, though.

 Thomas

Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1
Posted by Michael S. Tsirkin 6 years, 5 months ago
On Thu, Nov 16, 2017 at 02:41:09PM +0000, Peter Maydell wrote:
> On 15 November 2017 at 18:17, Michael S. Tsirkin <mst@redhat.com> wrote:
> > The following changes since commit 1fa0f627d03cd0d0755924247cafeb42969016bf:
> >
> >   Update version for v2.11.0-rc1 release (2017-11-14 18:37:49 +0000)
> >
> > are available in the git repository at:
> >
> >   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
> >
> > for you to fetch changes up to 6ed0c1c3ab0925009d15cffb944d9ccb04718846:
> >
> >   build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets (2017-11-15 20:13:13 +0200)
> >
> > ----------------------------------------------------------------
> > pc, pci, virtio: fixes for rc1
> >
> > A bunch of fixes all over the place.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> 
> Hi. This failed tests on a couple of machines:
> 
> s390x:
> 
> TEST: tests/bios-tables-test... (pid=58925)
>   /i386/acpi/piix4:
> Looking for expected file 'tests/acpi-test-data/pc/DSDT'
> 
> Using expected file 'tests/acpi-test-data/pc/DSDT'
> 
> Looking for expected file 'tests/acpi-test-data/pc/APIC'
> 
> Using expected file 'tests/acpi-test-data/pc/APIC'
> 
> Looking for expected file 'tests/acpi-test-data/pc/HPET'
> 
> Using expected file 'tests/acpi-test-data/pc/HPET'
> 'iasl -p /tmp/asl-CHIM9Y.dsl -d tests/acpi-test-data/pc/DSDT' exited
> with status 65280
> Intel ACPI Component Architecture
> ASL+ Optimizing Compiler version 20160108-64
> Copyright (c) 2000 - 2016 Intel Corporation
> 
> Could not get ACPI tables from tests/acpi-test-data/pc/DSDT, AE_BAD_HEADER
> Input file tests/acpi-test-data/pc/DSDT, Length 0x1418 (5144) bytes
> Table [DSDT] is too long for file - needs: 0x18140000, remaining in file: 0x1418
> **
> ERROR:/home/linux1/qemu/tests/bios-tables-test.c:461:test_acpi_asl:
> assertion failed: (!err && !exp_err)
> FAIL
> GTester: last random seed: R02S7430f83941b25a926c586492b2745d2c
> (pid=58933)
>   /i386/acpi/q35:



> Looking for expected file 'tests/acpi-test-data/q35/DSDT'
> 
> Using expected file 'tests/acpi-test-data/q35/DSDT'
> 
> Looking for expected file 'tests/acpi-test-data/q35/APIC'
> 
> Using expected file 'tests/acpi-test-data/q35/APIC'
> 
> Looking for expected file 'tests/acpi-test-data/q35/HPET'
> 
> Using expected file 'tests/acpi-test-data/q35/HPET'
> 
> Looking for expected file 'tests/acpi-test-data/q35/MCFG'
> 
> Using expected file 'tests/acpi-test-data/q35/MCFG'
> 'iasl -p /tmp/asl-NRWT9Y.dsl -d tests/acpi-test-data/q35/DSDT' exited
> with status 65280
> Intel ACPI Component Architecture
> ASL+ Optimizing Compiler version 20160108-64
> Copyright (c) 2000 - 2016 Intel Corporation
> 
> Could not get ACPI tables from tests/acpi-test-data/q35/DSDT, AE_BAD_HEADER
> Input file tests/acpi-test-data/q35/DSDT, Length 0x1E94 (7828) bytes
> Table [DSDT] is too long for file - needs: 0x941E0000, remaining in file: 0x1E94
> **
> ERROR:/home/linux1/qemu/tests/bios-tables-test.c:461:test_acpi_asl:
> assertion failed: (!err && !exp_err)
> FAIL
> 
> & similarly for a bunch of other tests. Looks like an
> endianness issue.
> 
> and on 32-bit arm:
> 
> TEST: tests/bios-tables-test... (pid=30809)
>   /i386/acpi/piix4:
> Looking for expected file 'tests/acpi-test-data/pc/DSDT'
> 
> Using expected file 'tests/acpi-test-data/pc/DSDT'
> 
> Looking for expected file 'tests/acpi-test-data/pc/APIC'
> 
> Using expected file 'tests/acpi-test-data/pc/APIC'
> 
> Looking for expected file 'tests/acpi-test-data/pc/HPET'
> 
> Using expected file 'tests/acpi-test-data/pc/HPET'
> 'iasl -p /tmp/asl-6T2N9Y.dsl -e /tmp/aml-TV2N9Y -d /tmp/aml-TV2N9Y'
> exited with status 11Input file /tmp/aml-TV2N9Y, Length 0x1418 (5144)
> bytes
> ACPI: DSDT 0x0000000000000000 001418 (v01 BOCHS  BXPCDSDT 00000001
> BXPC 00000001)
> Pass 1 parse of [DSDT]
> Pass 2 parse of [DSDT]
> Parsing Deferred Opcodes (Methods/Buffers/Packages/Regions)
> 
> Parsing completed
> 'iasl -p /tmp/asl-PKDO9Y.dsl -e tests/acpi-test-data/pc/DSDT -d
> tests/acpi-test-data/pc/DSDT' exited with status 11Input file
> tests/acpi-test-data/pc/DSDT, Length 0x1418 (5144) bytes
> ACPI: DSDT 0x0000000000000000 001418 (v01 BOCHS  BXPCDSDT 00000001
> BXPC 00000001)
> Pass 1 parse of [DSDT]
> Pass 2 parse of [DSDT]
> Parsing Deferred Opcodes (Methods/Buffers/Packages/Regions)
> 
> Parsing completed
> **
> ERROR:/home/peter.maydell/qemu/tests/bios-tables-test.c:461:test_acpi_asl:
> assertion failed: (!err && !exp_err)
> FAIL
> GTester: last random seed: R02S5d06952865b5a6ffb8443ae4d324e880
> (pid=30816)
>   /i386/acpi/q35:
> Looking for expected file 'tests/acpi-test-data/q35/DSDT'
> 
> Using expected file 'tests/acpi-test-data/q35/DSDT'
> 
> Looking for expected file 'tests/acpi-test-data/q35/APIC'
> 
> Using expected file 'tests/acpi-test-data/q35/APIC'
> 
> Looking for expected file 'tests/acpi-test-data/q35/HPET'
> 
> Using expected file 'tests/acpi-test-data/q35/HPET'
> 
> Looking for expected file 'tests/acpi-test-data/q35/MCFG'
> 
> Using expected file 'tests/acpi-test-data/q35/MCFG'
> OK
> 
> (and similar fails in other tests)
> 
> 
> thanks
> -- PMM

I think it's     test: fix detection of errors from iasl
I'll drop it for now.


Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1
Posted by Daniel P. Berrange 6 years, 5 months ago
On Thu, Nov 16, 2017 at 05:38:18PM +0200, Michael S. Tsirkin wrote:
> On Thu, Nov 16, 2017 at 02:41:09PM +0000, Peter Maydell wrote:
> > On 15 November 2017 at 18:17, Michael S. Tsirkin <mst@redhat.com> wrote:
> > > The following changes since commit 1fa0f627d03cd0d0755924247cafeb42969016bf:
> > >
> > >   Update version for v2.11.0-rc1 release (2017-11-14 18:37:49 +0000)
> > >
> > > are available in the git repository at:
> > >
> > >   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
> > >
> > > for you to fetch changes up to 6ed0c1c3ab0925009d15cffb944d9ccb04718846:
> > >
> > >   build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets (2017-11-15 20:13:13 +0200)
> > >
> > > ----------------------------------------------------------------
> > > pc, pci, virtio: fixes for rc1
> > >
> > > A bunch of fixes all over the place.
> > >
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > 
> > Hi. This failed tests on a couple of machines:
> > 
> > s390x:
> > 
> > TEST: tests/bios-tables-test... (pid=58925)
> >   /i386/acpi/piix4:
> > Looking for expected file 'tests/acpi-test-data/pc/DSDT'
> > 
> > Using expected file 'tests/acpi-test-data/pc/DSDT'
> > 
> > Looking for expected file 'tests/acpi-test-data/pc/APIC'
> > 
> > Using expected file 'tests/acpi-test-data/pc/APIC'
> > 
> > Looking for expected file 'tests/acpi-test-data/pc/HPET'
> > 
> > Using expected file 'tests/acpi-test-data/pc/HPET'
> > 'iasl -p /tmp/asl-CHIM9Y.dsl -d tests/acpi-test-data/pc/DSDT' exited
> > with status 65280
> > Intel ACPI Component Architecture
> > ASL+ Optimizing Compiler version 20160108-64
> > Copyright (c) 2000 - 2016 Intel Corporation
> > 
> > Could not get ACPI tables from tests/acpi-test-data/pc/DSDT, AE_BAD_HEADER
> > Input file tests/acpi-test-data/pc/DSDT, Length 0x1418 (5144) bytes
> > Table [DSDT] is too long for file - needs: 0x18140000, remaining in file: 0x1418
> > **
> > ERROR:/home/linux1/qemu/tests/bios-tables-test.c:461:test_acpi_asl:
> > assertion failed: (!err && !exp_err)
> > FAIL
> > GTester: last random seed: R02S7430f83941b25a926c586492b2745d2c
> > (pid=58933)
> >   /i386/acpi/q35:
> 
> 
> 
> > Looking for expected file 'tests/acpi-test-data/q35/DSDT'
> > 
> > Using expected file 'tests/acpi-test-data/q35/DSDT'
> > 
> > Looking for expected file 'tests/acpi-test-data/q35/APIC'
> > 
> > Using expected file 'tests/acpi-test-data/q35/APIC'
> > 
> > Looking for expected file 'tests/acpi-test-data/q35/HPET'
> > 
> > Using expected file 'tests/acpi-test-data/q35/HPET'
> > 
> > Looking for expected file 'tests/acpi-test-data/q35/MCFG'
> > 
> > Using expected file 'tests/acpi-test-data/q35/MCFG'
> > 'iasl -p /tmp/asl-NRWT9Y.dsl -d tests/acpi-test-data/q35/DSDT' exited
> > with status 65280
> > Intel ACPI Component Architecture
> > ASL+ Optimizing Compiler version 20160108-64
> > Copyright (c) 2000 - 2016 Intel Corporation
> > 
> > Could not get ACPI tables from tests/acpi-test-data/q35/DSDT, AE_BAD_HEADER
> > Input file tests/acpi-test-data/q35/DSDT, Length 0x1E94 (7828) bytes
> > Table [DSDT] is too long for file - needs: 0x941E0000, remaining in file: 0x1E94
> > **
> > ERROR:/home/linux1/qemu/tests/bios-tables-test.c:461:test_acpi_asl:
> > assertion failed: (!err && !exp_err)
> > FAIL
> > 
> > & similarly for a bunch of other tests. Looks like an
> > endianness issue.
> > 
> > and on 32-bit arm:
> > 
> > TEST: tests/bios-tables-test... (pid=30809)
> >   /i386/acpi/piix4:
> > Looking for expected file 'tests/acpi-test-data/pc/DSDT'
> > 
> > Using expected file 'tests/acpi-test-data/pc/DSDT'
> > 
> > Looking for expected file 'tests/acpi-test-data/pc/APIC'
> > 
> > Using expected file 'tests/acpi-test-data/pc/APIC'
> > 
> > Looking for expected file 'tests/acpi-test-data/pc/HPET'
> > 
> > Using expected file 'tests/acpi-test-data/pc/HPET'
> > 'iasl -p /tmp/asl-6T2N9Y.dsl -e /tmp/aml-TV2N9Y -d /tmp/aml-TV2N9Y'
> > exited with status 11Input file /tmp/aml-TV2N9Y, Length 0x1418 (5144)
> > bytes
> > ACPI: DSDT 0x0000000000000000 001418 (v01 BOCHS  BXPCDSDT 00000001
> > BXPC 00000001)
> > Pass 1 parse of [DSDT]
> > Pass 2 parse of [DSDT]
> > Parsing Deferred Opcodes (Methods/Buffers/Packages/Regions)
> > 
> > Parsing completed
> > 'iasl -p /tmp/asl-PKDO9Y.dsl -e tests/acpi-test-data/pc/DSDT -d
> > tests/acpi-test-data/pc/DSDT' exited with status 11Input file
> > tests/acpi-test-data/pc/DSDT, Length 0x1418 (5144) bytes
> > ACPI: DSDT 0x0000000000000000 001418 (v01 BOCHS  BXPCDSDT 00000001
> > BXPC 00000001)
> > Pass 1 parse of [DSDT]
> > Pass 2 parse of [DSDT]
> > Parsing Deferred Opcodes (Methods/Buffers/Packages/Regions)
> > 
> > Parsing completed
> > **
> > ERROR:/home/peter.maydell/qemu/tests/bios-tables-test.c:461:test_acpi_asl:
> > assertion failed: (!err && !exp_err)
> > FAIL
> > GTester: last random seed: R02S5d06952865b5a6ffb8443ae4d324e880
> > (pid=30816)
> >   /i386/acpi/q35:
> > Looking for expected file 'tests/acpi-test-data/q35/DSDT'
> > 
> > Using expected file 'tests/acpi-test-data/q35/DSDT'
> > 
> > Looking for expected file 'tests/acpi-test-data/q35/APIC'
> > 
> > Using expected file 'tests/acpi-test-data/q35/APIC'
> > 
> > Looking for expected file 'tests/acpi-test-data/q35/HPET'
> > 
> > Using expected file 'tests/acpi-test-data/q35/HPET'
> > 
> > Looking for expected file 'tests/acpi-test-data/q35/MCFG'
> > 
> > Using expected file 'tests/acpi-test-data/q35/MCFG'
> > OK
> > 
> > (and similar fails in other tests)
> > 
> > 
> > thanks
> > -- PMM
> 
> I think it's     test: fix detection of errors from iasl
> I'll drop it for now.

I think that patch is merely exposing a failure that has always
happened, but which we've never noticed before. So dropping that
patch just hides the error again, doesn't fix the error.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1
Posted by Michael S. Tsirkin 6 years, 5 months ago
On Thu, Nov 16, 2017 at 03:45:34PM +0000, Daniel P. Berrange wrote:
> On Thu, Nov 16, 2017 at 05:38:18PM +0200, Michael S. Tsirkin wrote:
> > On Thu, Nov 16, 2017 at 02:41:09PM +0000, Peter Maydell wrote:
> > > On 15 November 2017 at 18:17, Michael S. Tsirkin <mst@redhat.com> wrote:
> > > > The following changes since commit 1fa0f627d03cd0d0755924247cafeb42969016bf:
> > > >
> > > >   Update version for v2.11.0-rc1 release (2017-11-14 18:37:49 +0000)
> > > >
> > > > are available in the git repository at:
> > > >
> > > >   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
> > > >
> > > > for you to fetch changes up to 6ed0c1c3ab0925009d15cffb944d9ccb04718846:
> > > >
> > > >   build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets (2017-11-15 20:13:13 +0200)
> > > >
> > > > ----------------------------------------------------------------
> > > > pc, pci, virtio: fixes for rc1
> > > >
> > > > A bunch of fixes all over the place.
> > > >
> > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > > 
> > > Hi. This failed tests on a couple of machines:
> > > 
> > > s390x:
> > > 
> > > TEST: tests/bios-tables-test... (pid=58925)
> > >   /i386/acpi/piix4:
> > > Looking for expected file 'tests/acpi-test-data/pc/DSDT'
> > > 
> > > Using expected file 'tests/acpi-test-data/pc/DSDT'
> > > 
> > > Looking for expected file 'tests/acpi-test-data/pc/APIC'
> > > 
> > > Using expected file 'tests/acpi-test-data/pc/APIC'
> > > 
> > > Looking for expected file 'tests/acpi-test-data/pc/HPET'
> > > 
> > > Using expected file 'tests/acpi-test-data/pc/HPET'
> > > 'iasl -p /tmp/asl-CHIM9Y.dsl -d tests/acpi-test-data/pc/DSDT' exited
> > > with status 65280
> > > Intel ACPI Component Architecture
> > > ASL+ Optimizing Compiler version 20160108-64
> > > Copyright (c) 2000 - 2016 Intel Corporation
> > > 
> > > Could not get ACPI tables from tests/acpi-test-data/pc/DSDT, AE_BAD_HEADER
> > > Input file tests/acpi-test-data/pc/DSDT, Length 0x1418 (5144) bytes
> > > Table [DSDT] is too long for file - needs: 0x18140000, remaining in file: 0x1418
> > > **
> > > ERROR:/home/linux1/qemu/tests/bios-tables-test.c:461:test_acpi_asl:
> > > assertion failed: (!err && !exp_err)
> > > FAIL
> > > GTester: last random seed: R02S7430f83941b25a926c586492b2745d2c
> > > (pid=58933)
> > >   /i386/acpi/q35:
> > 
> > 
> > 
> > > Looking for expected file 'tests/acpi-test-data/q35/DSDT'
> > > 
> > > Using expected file 'tests/acpi-test-data/q35/DSDT'
> > > 
> > > Looking for expected file 'tests/acpi-test-data/q35/APIC'
> > > 
> > > Using expected file 'tests/acpi-test-data/q35/APIC'
> > > 
> > > Looking for expected file 'tests/acpi-test-data/q35/HPET'
> > > 
> > > Using expected file 'tests/acpi-test-data/q35/HPET'
> > > 
> > > Looking for expected file 'tests/acpi-test-data/q35/MCFG'
> > > 
> > > Using expected file 'tests/acpi-test-data/q35/MCFG'
> > > 'iasl -p /tmp/asl-NRWT9Y.dsl -d tests/acpi-test-data/q35/DSDT' exited
> > > with status 65280
> > > Intel ACPI Component Architecture
> > > ASL+ Optimizing Compiler version 20160108-64
> > > Copyright (c) 2000 - 2016 Intel Corporation
> > > 
> > > Could not get ACPI tables from tests/acpi-test-data/q35/DSDT, AE_BAD_HEADER
> > > Input file tests/acpi-test-data/q35/DSDT, Length 0x1E94 (7828) bytes
> > > Table [DSDT] is too long for file - needs: 0x941E0000, remaining in file: 0x1E94
> > > **
> > > ERROR:/home/linux1/qemu/tests/bios-tables-test.c:461:test_acpi_asl:
> > > assertion failed: (!err && !exp_err)
> > > FAIL
> > > 
> > > & similarly for a bunch of other tests. Looks like an
> > > endianness issue.
> > > 
> > > and on 32-bit arm:
> > > 
> > > TEST: tests/bios-tables-test... (pid=30809)
> > >   /i386/acpi/piix4:
> > > Looking for expected file 'tests/acpi-test-data/pc/DSDT'
> > > 
> > > Using expected file 'tests/acpi-test-data/pc/DSDT'
> > > 
> > > Looking for expected file 'tests/acpi-test-data/pc/APIC'
> > > 
> > > Using expected file 'tests/acpi-test-data/pc/APIC'
> > > 
> > > Looking for expected file 'tests/acpi-test-data/pc/HPET'
> > > 
> > > Using expected file 'tests/acpi-test-data/pc/HPET'
> > > 'iasl -p /tmp/asl-6T2N9Y.dsl -e /tmp/aml-TV2N9Y -d /tmp/aml-TV2N9Y'
> > > exited with status 11Input file /tmp/aml-TV2N9Y, Length 0x1418 (5144)
> > > bytes
> > > ACPI: DSDT 0x0000000000000000 001418 (v01 BOCHS  BXPCDSDT 00000001
> > > BXPC 00000001)
> > > Pass 1 parse of [DSDT]
> > > Pass 2 parse of [DSDT]
> > > Parsing Deferred Opcodes (Methods/Buffers/Packages/Regions)
> > > 
> > > Parsing completed
> > > 'iasl -p /tmp/asl-PKDO9Y.dsl -e tests/acpi-test-data/pc/DSDT -d
> > > tests/acpi-test-data/pc/DSDT' exited with status 11Input file
> > > tests/acpi-test-data/pc/DSDT, Length 0x1418 (5144) bytes
> > > ACPI: DSDT 0x0000000000000000 001418 (v01 BOCHS  BXPCDSDT 00000001
> > > BXPC 00000001)
> > > Pass 1 parse of [DSDT]
> > > Pass 2 parse of [DSDT]
> > > Parsing Deferred Opcodes (Methods/Buffers/Packages/Regions)
> > > 
> > > Parsing completed
> > > **
> > > ERROR:/home/peter.maydell/qemu/tests/bios-tables-test.c:461:test_acpi_asl:
> > > assertion failed: (!err && !exp_err)
> > > FAIL
> > > GTester: last random seed: R02S5d06952865b5a6ffb8443ae4d324e880
> > > (pid=30816)
> > >   /i386/acpi/q35:
> > > Looking for expected file 'tests/acpi-test-data/q35/DSDT'
> > > 
> > > Using expected file 'tests/acpi-test-data/q35/DSDT'
> > > 
> > > Looking for expected file 'tests/acpi-test-data/q35/APIC'
> > > 
> > > Using expected file 'tests/acpi-test-data/q35/APIC'
> > > 
> > > Looking for expected file 'tests/acpi-test-data/q35/HPET'
> > > 
> > > Using expected file 'tests/acpi-test-data/q35/HPET'
> > > 
> > > Looking for expected file 'tests/acpi-test-data/q35/MCFG'
> > > 
> > > Using expected file 'tests/acpi-test-data/q35/MCFG'
> > > OK
> > > 
> > > (and similar fails in other tests)
> > > 
> > > 
> > > thanks
> > > -- PMM
> > 
> > I think it's     test: fix detection of errors from iasl
> > I'll drop it for now.
> 
> I think that patch is merely exposing a failure that has always
> happened, but which we've never noticed before. So dropping that
> patch just hides the error again, doesn't fix the error.
> 
> Regards,
> Daniel

We shouldn't fail test if system can't load expected files.
This just will trip up people trying to build qemu.

Maybe at this point we shouldn't run iasl unconditionally.

It used to be very important when we had parts of the tables
generated by iasl, so different versions would introduce
trivial changes.

Maybe now we should compare binaries first, run iasl to help debugging
only if they differ.

Will save writing out files too.

And maybe show the diff in rebuild-expected-aml too - add it to
.git/COMMIT_EDITMSG so people remember to include it in the commit log?




> -- 
> |: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-            https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1
Posted by Peter Maydell 6 years, 5 months ago
On 16 November 2017 at 15:56, Michael S. Tsirkin <mst@redhat.com> wrote:
> On Thu, Nov 16, 2017 at 03:45:34PM +0000, Daniel P. Berrange wrote:
>> On Thu, Nov 16, 2017 at 05:38:18PM +0200, Michael S. Tsirkin wrote:
>> > I think it's     test: fix detection of errors from iasl
>> > I'll drop it for now.
>>
>> I think that patch is merely exposing a failure that has always
>> happened, but which we've never noticed before. So dropping that
>> patch just hides the error again, doesn't fix the error.

> We shouldn't fail test if system can't load expected files.
> This just will trip up people trying to build qemu.

If there are known-buggy iasl versions in the wild we could
consider a configure test and treat buggy-iasl like no-iasl.

thanks
-- PMM

Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1
Posted by Daniel P. Berrange 6 years, 5 months ago
On Thu, Nov 16, 2017 at 04:10:22PM +0000, Peter Maydell wrote:
> On 16 November 2017 at 15:56, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Thu, Nov 16, 2017 at 03:45:34PM +0000, Daniel P. Berrange wrote:
> >> On Thu, Nov 16, 2017 at 05:38:18PM +0200, Michael S. Tsirkin wrote:
> >> > I think it's     test: fix detection of errors from iasl
> >> > I'll drop it for now.
> >>
> >> I think that patch is merely exposing a failure that has always
> >> happened, but which we've never noticed before. So dropping that
> >> patch just hides the error again, doesn't fix the error.
> 
> > We shouldn't fail test if system can't load expected files.
> > This just will trip up people trying to build qemu.
> 
> If there are known-buggy iasl versions in the wild we could
> consider a configure test and treat buggy-iasl like no-iasl.

iasl has long been broken on big-endian, but it has also long contained
code that simply makes it exit immediately in that case, and qemu copes
with that. So if there's buggy iasl it would be a distro which removed
this big-endian check and tried to make it work on big-endian but failed.
Fedora tried the latter, but at least in rawhide it works properly now.
I'm unclear if we shipped broken iasl with the BE check removed in stable
versions though

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1
Posted by Peter Maydell 6 years, 5 months ago
On 16 November 2017 at 16:13, Daniel P. Berrange <berrange@redhat.com> wrote:
> On Thu, Nov 16, 2017 at 04:10:22PM +0000, Peter Maydell wrote:
>> If there are known-buggy iasl versions in the wild we could
>> consider a configure test and treat buggy-iasl like no-iasl.
>
> iasl has long been broken on big-endian, but it has also long contained
> code that simply makes it exit immediately in that case, and qemu copes
> with that. So if there's buggy iasl it would be a distro which removed
> this big-endian check and tried to make it work on big-endian but failed.
> Fedora tried the latter, but at least in rawhide it works properly now.
> I'm unclear if we shipped broken iasl with the BE check removed in stable
> versions though

In this case this is Ubuntu 16.04.2 LTS (xenial) on s390x, with

linux1@lxub05:~$ iasl -v

Intel ACPI Component Architecture
ASL+ Optimizing Compiler version 20160108-64
Copyright (c) 2000 - 2016 Intel Corporation

thanks
-- PMM

Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1
Posted by Thomas Huth 6 years, 5 months ago
On 16.11.2017 17:15, Peter Maydell wrote:
> On 16 November 2017 at 16:13, Daniel P. Berrange <berrange@redhat.com> wrote:
>> On Thu, Nov 16, 2017 at 04:10:22PM +0000, Peter Maydell wrote:
>>> If there are known-buggy iasl versions in the wild we could
>>> consider a configure test and treat buggy-iasl like no-iasl.
>>
>> iasl has long been broken on big-endian, but it has also long contained
>> code that simply makes it exit immediately in that case, and qemu copes
>> with that. So if there's buggy iasl it would be a distro which removed
>> this big-endian check and tried to make it work on big-endian but failed.
>> Fedora tried the latter, but at least in rawhide it works properly now.
>> I'm unclear if we shipped broken iasl with the BE check removed in stable
>> versions though
> 
> In this case this is Ubuntu 16.04.2 LTS (xenial) on s390x, with
> 
> linux1@lxub05:~$ iasl -v
> 
> Intel ACPI Component Architecture
> ASL+ Optimizing Compiler version 20160108-64
> Copyright (c) 2000 - 2016 Intel Corporation

That's likely a broken version, indeed. I've noticed that the iasl that
ships with the acpica-tools in RHEL7 is broken, too - it does not
contain the big-endian check (yet?), and fails to byte-swap on big
endian hosts.

If you compile the latest version from upstream, you get this instead:

$ iasl -v
iASL is not currently supported on big-endian machines.

But as Daniel already wrote: The version from Fedora contains some
patches that fix the endianess issue, so that iasl with these patches
also works fine on big endian hosts:

 https://src.fedoraproject.org/rpms/acpica-tools/blob/master/f/big-endian.patch
 https://src.fedoraproject.org/rpms/acpica-tools/blob/master/f/big-endian-v2.patch

 Thomas

Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1
Posted by Michael S. Tsirkin 6 years, 5 months ago
On Thu, Nov 16, 2017 at 05:43:52PM +0100, Thomas Huth wrote:
> On 16.11.2017 17:15, Peter Maydell wrote:
> > On 16 November 2017 at 16:13, Daniel P. Berrange <berrange@redhat.com> wrote:
> >> On Thu, Nov 16, 2017 at 04:10:22PM +0000, Peter Maydell wrote:
> >>> If there are known-buggy iasl versions in the wild we could
> >>> consider a configure test and treat buggy-iasl like no-iasl.
> >>
> >> iasl has long been broken on big-endian, but it has also long contained
> >> code that simply makes it exit immediately in that case, and qemu copes
> >> with that. So if there's buggy iasl it would be a distro which removed
> >> this big-endian check and tried to make it work on big-endian but failed.
> >> Fedora tried the latter, but at least in rawhide it works properly now.
> >> I'm unclear if we shipped broken iasl with the BE check removed in stable
> >> versions though
> > 
> > In this case this is Ubuntu 16.04.2 LTS (xenial) on s390x, with
> > 
> > linux1@lxub05:~$ iasl -v
> > 
> > Intel ACPI Component Architecture
> > ASL+ Optimizing Compiler version 20160108-64
> > Copyright (c) 2000 - 2016 Intel Corporation
> 
> That's likely a broken version, indeed. I've noticed that the iasl that
> ships with the acpica-tools in RHEL7 is broken, too - it does not
> contain the big-endian check (yet?), and fails to byte-swap on big
> endian hosts.
> 
> If you compile the latest version from upstream, you get this instead:
> 
> $ iasl -v
> iASL is not currently supported on big-endian machines.
> 
> But as Daniel already wrote: The version from Fedora contains some
> patches that fix the endianess issue, so that iasl with these patches
> also works fine on big endian hosts:
> 
>  https://src.fedoraproject.org/rpms/acpica-tools/blob/master/f/big-endian.patch
>  https://src.fedoraproject.org/rpms/acpica-tools/blob/master/f/big-endian-v2.patch
> 
>  Thomas

For the record, I think we should remove the dependency on iasl for
tests too. It is still a handy tool for debugging, so the following
would be a good plan IMHO:

- compare binary actual to expected in memory
- on match pass and skip iasl
- on mismatch, generate aml, run iasl, show
  output in existing format.
  then fail
- when generating expected files, print diff
  and make it easy to append to commit log


-- 
MST

Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1
Posted by Michael S. Tsirkin 6 years, 5 months ago
On Thu, Nov 16, 2017 at 04:10:22PM +0000, Peter Maydell wrote:
> On 16 November 2017 at 15:56, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Thu, Nov 16, 2017 at 03:45:34PM +0000, Daniel P. Berrange wrote:
> >> On Thu, Nov 16, 2017 at 05:38:18PM +0200, Michael S. Tsirkin wrote:
> >> > I think it's     test: fix detection of errors from iasl
> >> > I'll drop it for now.
> >>
> >> I think that patch is merely exposing a failure that has always
> >> happened, but which we've never noticed before. So dropping that
> >> patch just hides the error again, doesn't fix the error.
> 
> > We shouldn't fail test if system can't load expected files.
> > This just will trip up people trying to build qemu.
> 
> If there are known-buggy iasl versions in the wild we could
> consider a configure test and treat buggy-iasl like no-iasl.
> 
> thanks
> -- PMM

Right. All this is not 2.11 material though.

-- 
MST

[Qemu-devel] [PULL 07/10] tests/acpi-test-data: update _CRS in DSDT
Posted by Michael S. Tsirkin 6 years, 5 months ago
commit dadf988e81b15065ac1d6dbaf4b87b5b80c7b670
    hw/pci-host: Fix x86 Host Bridges 64bit PCI hole

Added a 64 bit hole to _CRS of PCI0.
Update the expected files accordingly.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 tests/acpi-test-data/pc/DSDT         | Bin 5098 -> 5144 bytes
 tests/acpi-test-data/pc/DSDT.bridge  | Bin 6957 -> 7003 bytes
 tests/acpi-test-data/pc/DSDT.cphp    | Bin 5561 -> 5607 bytes
 tests/acpi-test-data/pc/DSDT.ipmikcs | Bin 5170 -> 5216 bytes
 tests/acpi-test-data/pc/DSDT.memhp   | Bin 6463 -> 6509 bytes
 tests/acpi-test-data/q35/DSDT        | Bin 7782 -> 7828 bytes
 tests/acpi-test-data/q35/DSDT.bridge | Bin 7799 -> 7845 bytes
 tests/acpi-test-data/q35/DSDT.cphp   | Bin 8245 -> 8291 bytes
 tests/acpi-test-data/q35/DSDT.ipmibt | Bin 7857 -> 7903 bytes
 tests/acpi-test-data/q35/DSDT.memhp  | Bin 9147 -> 9193 bytes
 10 files changed, 0 insertions(+), 0 deletions(-)

diff --git a/tests/acpi-test-data/pc/DSDT b/tests/acpi-test-data/pc/DSDT
index 15c3135d65f168a91edfdc3471ea1d3f012a824f..99f05a502752d9dbac38fdd93f1ebb79b4564fb4 100644
GIT binary patch
delta 98
zcmaE*K0|}cCD<iILWF^VF?=IeJhzy$NQ_>5uv2`1v!?+^ymL^npaU1zoXPdvIeJ~%
d3=BNX3`l?x$o~KTe?5ps0u3Pc=GWZ+*#RA&6M_H$

delta 51
zcmbQC@k*V`CD<k8l`sPXW5q_Ucy2LQ!5F>xV5j&1XHNr;c;}#CK__;uyvg<4Ih!SU
H{<8xBdNvM&

diff --git a/tests/acpi-test-data/pc/DSDT.bridge b/tests/acpi-test-data/pc/DSDT.bridge
index d38586c95bf31f0212279a2505efd8e2fd321ccc..cf23343e6402421f09da5d09f72811108fbd2661 100644
GIT binary patch
delta 98
zcmZ2$cH4~0CD<h-TAG1@aluBecy2Lgkr=)BV5j&1XHNr;c;}#CK?g3bIg{(TbM(5j
d85nq&8IS-Ykp2Jv|9TLO1R6l>&9Awg_yJmb6N3N%

delta 51
zcmca@w$_ZxCD<iISDJx=@xVr|cy2LQ!5F>xV5j&1XHNr;c;}#CK__;uyvg<4Ih!SU
GocIB3sttqy

diff --git a/tests/acpi-test-data/pc/DSDT.cphp b/tests/acpi-test-data/pc/DSDT.cphp
index 2dd70bf9520406c36c3684714bb714e536a28d20..c99c49f43705e99d1e0a8ba19d44145dfa63d009 100644
GIT binary patch
delta 98
zcmdm~{al;NCD<k8xhMkz<He0!dc0!JA~AaL!A|i3&YlJw@y<cPf(~3<b0+)o=IC{4
eGcfQlGavy*Ap8IS|Megm2{eG%n|Ja4X9oa*yA)&q

delta 51
zcmaE^y;GaZCD<iorzish<HwC$dc0z;f-!pW!A|i3&YlJw@y<cPf==vQd6WHkb2h)=
H{m%{nhcXXj

diff --git a/tests/acpi-test-data/pc/DSDT.ipmikcs b/tests/acpi-test-data/pc/DSDT.ipmikcs
index 2796d96b0eec17fb68a79234cbccb70708ac2587..5e970fda7296f9ce44487e0a578a1dead982ba66 100644
GIT binary patch
delta 98
zcmdm_@j!#iCD<h-L4<*U@y<rB<=kS<A~AaL!A|i3&YlJw@y<cPf(~3<b0#0>&e7}A
eW?<l9W<UarK=%Lt|LZ|C5@-OiHyiW(X9oa_pA<O&

delta 51
zcmaE$u}Oo=CD<jzNQ8lb@y|xC<=kSff-!pW!A|i3&YlJw@y<cPf==vQd6SQG=WI^o
H`OgjjfCCRX

diff --git a/tests/acpi-test-data/pc/DSDT.memhp b/tests/acpi-test-data/pc/DSDT.memhp
index 53f6d5824359ff0ca20179b19b3b5cb79f017f82..1fe6871aa245277e0562ff0a1e93a9bf3bcf2295 100644
GIT binary patch
delta 98
zcmdmQ^wx;WCD<h-SCWB&F>)i<76CD5kr=)BV5j&1XHNr;c;}#CK?g3bIg_sl<mh#2
eGcfQlGavybAp8IS|Megm2{eG%n;iuIvjYHvJrphg

delta 51
zcmaEBwBLx!CD<jzUXp=<v3eud76CC=!5F>xV5j&1XHNr;c;}#CK__;uyvbJtayI7)
H{$~dOd}0qS

diff --git a/tests/acpi-test-data/q35/DSDT b/tests/acpi-test-data/q35/DSDT
index a080e2ace20ce9b88d5a61078d8caa0262617eed..aa402cca667f82ed0a2dc4969508d8f6e38ad910 100644
GIT binary patch
delta 97
zcmaE6GsTw6CD<ioiW~z2quNHUdop6~{4sj*!A|i3&YlJw@y<cPf(~3<b0+_j$<gc5
bW?<l9W<UarK=ywi;6M@sF+u#vS+aishSC&{

delta 50
zcmbPY`^<*RCD<h-O^$(qF?1u>JsB}io*2FOV5j&1XHNr;c;}#CK__;uyvhG$awgA^
G{R04T6c3I7

diff --git a/tests/acpi-test-data/q35/DSDT.bridge b/tests/acpi-test-data/q35/DSDT.bridge
index 31a76732e563dde32e6d976670baa732a6b91807..fc3e79c583ababf5615e76ba2f7bc3df1483abb4 100644
GIT binary patch
delta 98
zcmexvv(%Q$CD<iosT>0X<FSog_hiJ}`D66rgPr07oIMRV;+=zn1s%A!=1l%4lcU$A
c&A`CJ%zy+Kf$aZ4z=0$NVuJXavt)T00pV^GlK=n!

delta 51
zcmZ2#``w1iCD<jTT#kW(@#{vedop64JTZFl!A|i3&YlJw@y<cPf==vQd6WOi<ZPZH
H%gYD=pYsos

diff --git a/tests/acpi-test-data/q35/DSDT.cphp b/tests/acpi-test-data/q35/DSDT.cphp
index 3e23cb638f296644154100379584b30b644926bd..fd3cb3421814d0383863dc780d9a2a9077b727a3 100644
GIT binary patch
delta 97
zcmdn$@YsRNCD<h-S%HCpasEcGwQ^$a{4sj*!A|i3&YlJw@y<cPf(~3<b0(ja%hBu7
bW?<l9W<UarK=ywi;6M@sF+u#vmhyi9k`NSd

delta 50
zcmaFtu+@RfCD<jzRDpqk@!UqPwQ^#fJTZFl!A|i3&YlJw@y<cPf==vQd6Un|<xEbO
G{{sMeF%NJ6

diff --git a/tests/acpi-test-data/q35/DSDT.ipmibt b/tests/acpi-test-data/q35/DSDT.ipmibt
index 9c5e03fd2ffd3a99f3e5214ba187456a86410b22..332237529e114256384c051858fdac36b024c72e 100644
GIT binary patch
delta 97
zcmdmJd*7DJCD<k8z8nJsqxVKGO<6H_{usUZV5j&1XHNr;c;}#CK?g3bIg>qQbM(5j
b85nq&8IS-Yko_MBIFQ6ZOb~zaR@pxQS6~zP

delta 50
zcmca_yU~`*CD<ioqZ|VRW7S43O<6Hdo*2FOV5j&1XHNr;c;}#CK__;uyvd%jIg=mD
G{s91M?+*9?

diff --git a/tests/acpi-test-data/q35/DSDT.memhp b/tests/acpi-test-data/q35/DSDT.memhp
index 1b7c484a5e31ec456685bc246197252cb48a3adf..f0a27e1a3093ff7525f62b7509ea44dfe9eb8908 100644
GIT binary patch
delta 97
zcmdn({?eVxCD<k8r7{BpqsB%qV<j<n{usUZV5j&1XHNr;c;}#CK?g3bIg^8xa`d{i
c85nq&8IS-Iko_MBIFZCaOb#HPykF@L0BA-OI{*Lx

delta 50
zcmaFqzT2J4CD<iow=x3*W8_9IV<j<9o*2FOV5j&1XHNr;c;}#CK__;uyve~zIg{Ti
G{Q&@Tw+}l2

-- 
MST