Commit 5c0919d0 [1] introduced virtqueue_size parameter
for common virtio-scsi path, without updaing the vhost-user-scsi
code. vhost-user-scsi devices right now report size 0 for each vq.
This patch introduces virtqueue_size param to vhost-user-scsi,
that can now be set by the user. However, the most importantly, it
now has a default value of 128 (same as QEMU's virtio-scsi).
[1] 5c0919d0 ("virtio-scsi: Add virtqueue_size parameter
allowing virtqueue size to be set.")
Change-Id: I70e87eab702ebf1196c028dbf17d54fdc0c89a14
Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
---
hw/scsi/vhost-user-scsi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/scsi/vhost-user-scsi.c b/hw/scsi/vhost-user-scsi.c
index 500fa6a..f7561e2 100644
--- a/hw/scsi/vhost-user-scsi.c
+++ b/hw/scsi/vhost-user-scsi.c
@@ -135,6 +135,8 @@ static Property vhost_user_scsi_properties[] = {
DEFINE_PROP_CHR("chardev", VirtIOSCSICommon, conf.chardev),
DEFINE_PROP_UINT32("boot_tpgt", VirtIOSCSICommon, conf.boot_tpgt, 0),
DEFINE_PROP_UINT32("num_queues", VirtIOSCSICommon, conf.num_queues, 1),
+ DEFINE_PROP_UINT32("virtqueue_size", VirtIOSCSICommon, conf.virtqueue_size,
+ 128),
DEFINE_PROP_UINT32("max_sectors", VirtIOSCSICommon, conf.max_sectors,
0xFFFF),
DEFINE_PROP_UINT32("cmd_per_lun", VirtIOSCSICommon, conf.cmd_per_lun, 128),
--
2.7.4
On Tue, Nov 14, 2017 at 05:28:36PM +0100, Dariusz Stojaczyk wrote: > Commit 5c0919d0 [1] introduced virtqueue_size parameter > for common virtio-scsi path, without updaing the vhost-user-scsi > code. vhost-user-scsi devices right now report size 0 for each vq. > > This patch introduces virtqueue_size param to vhost-user-scsi, > that can now be set by the user. However, the most importantly, it > now has a default value of 128 (same as QEMU's virtio-scsi). > > [1] 5c0919d0 ("virtio-scsi: Add virtqueue_size parameter > allowing virtqueue size to be set.") > > Change-Id: I70e87eab702ebf1196c028dbf17d54fdc0c89a14 > Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com> > --- > hw/scsi/vhost-user-scsi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/scsi/vhost-user-scsi.c b/hw/scsi/vhost-user-scsi.c > index 500fa6a..f7561e2 100644 > --- a/hw/scsi/vhost-user-scsi.c > +++ b/hw/scsi/vhost-user-scsi.c > @@ -135,6 +135,8 @@ static Property vhost_user_scsi_properties[] = { > DEFINE_PROP_CHR("chardev", VirtIOSCSICommon, conf.chardev), > DEFINE_PROP_UINT32("boot_tpgt", VirtIOSCSICommon, conf.boot_tpgt, 0), > DEFINE_PROP_UINT32("num_queues", VirtIOSCSICommon, conf.num_queues, 1), > + DEFINE_PROP_UINT32("virtqueue_size", VirtIOSCSICommon, conf.virtqueue_size, > + 128), > DEFINE_PROP_UINT32("max_sectors", VirtIOSCSICommon, conf.max_sectors, > 0xFFFF), > DEFINE_PROP_UINT32("cmd_per_lun", VirtIOSCSICommon, conf.cmd_per_lun, 128), Looks good to me. However I don't really know the code well enough to say if there could be other problems. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW
On 14/11/2017 17:28, Dariusz Stojaczyk wrote: > Commit 5c0919d0 [1] introduced virtqueue_size parameter > for common virtio-scsi path, without updaing the vhost-user-scsi > code. vhost-user-scsi devices right now report size 0 for each vq. > > This patch introduces virtqueue_size param to vhost-user-scsi, > that can now be set by the user. However, the most importantly, it > now has a default value of 128 (same as QEMU's virtio-scsi). > > [1] 5c0919d0 ("virtio-scsi: Add virtqueue_size parameter > allowing virtqueue size to be set.") > > Change-Id: I70e87eab702ebf1196c028dbf17d54fdc0c89a14 > Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com> > --- > hw/scsi/vhost-user-scsi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/scsi/vhost-user-scsi.c b/hw/scsi/vhost-user-scsi.c > index 500fa6a..f7561e2 100644 > --- a/hw/scsi/vhost-user-scsi.c > +++ b/hw/scsi/vhost-user-scsi.c > @@ -135,6 +135,8 @@ static Property vhost_user_scsi_properties[] = { > DEFINE_PROP_CHR("chardev", VirtIOSCSICommon, conf.chardev), > DEFINE_PROP_UINT32("boot_tpgt", VirtIOSCSICommon, conf.boot_tpgt, 0), > DEFINE_PROP_UINT32("num_queues", VirtIOSCSICommon, conf.num_queues, 1), > + DEFINE_PROP_UINT32("virtqueue_size", VirtIOSCSICommon, conf.virtqueue_size, > + 128), > DEFINE_PROP_UINT32("max_sectors", VirtIOSCSICommon, conf.max_sectors, > 0xFFFF), > DEFINE_PROP_UINT32("cmd_per_lun", VirtIOSCSICommon, conf.cmd_per_lun, 128), > Thanks, will apply. Paolo
On Tue, Nov 14, 2017 at 05:28:36PM +0100, Dariusz Stojaczyk wrote: > Commit 5c0919d0 [1] introduced virtqueue_size parameter > for common virtio-scsi path, without updaing the vhost-user-scsi > code. vhost-user-scsi devices right now report size 0 for each vq. > > This patch introduces virtqueue_size param to vhost-user-scsi, > that can now be set by the user. However, the most importantly, it > now has a default value of 128 (same as QEMU's virtio-scsi). > > [1] 5c0919d0 ("virtio-scsi: Add virtqueue_size parameter > allowing virtqueue size to be set.") > > Change-Id: I70e87eab702ebf1196c028dbf17d54fdc0c89a14 > Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> > --- > hw/scsi/vhost-user-scsi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/scsi/vhost-user-scsi.c b/hw/scsi/vhost-user-scsi.c > index 500fa6a..f7561e2 100644 > --- a/hw/scsi/vhost-user-scsi.c > +++ b/hw/scsi/vhost-user-scsi.c > @@ -135,6 +135,8 @@ static Property vhost_user_scsi_properties[] = { > DEFINE_PROP_CHR("chardev", VirtIOSCSICommon, conf.chardev), > DEFINE_PROP_UINT32("boot_tpgt", VirtIOSCSICommon, conf.boot_tpgt, 0), > DEFINE_PROP_UINT32("num_queues", VirtIOSCSICommon, conf.num_queues, 1), > + DEFINE_PROP_UINT32("virtqueue_size", VirtIOSCSICommon, conf.virtqueue_size, > + 128), > DEFINE_PROP_UINT32("max_sectors", VirtIOSCSICommon, conf.max_sectors, > 0xFFFF), > DEFINE_PROP_UINT32("cmd_per_lun", VirtIOSCSICommon, conf.cmd_per_lun, 128), > -- > 2.7.4
© 2016 - 2024 Red Hat, Inc.