[Qemu-devel] [PATCH 0/2] Enable the simple virtio tests on s390x, too

Thomas Huth posted 2 patches 6 years, 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1508336428-20511-1-git-send-email-thuth@redhat.com
Test checkpatch passed
Test docker passed
Test s390x passed
tests/Makefile.include         |  9 ++++---
tests/boot-order-test.c        | 11 +++------
tests/boot-serial-test.c       | 12 +++------
tests/endianness-test.c        | 33 +++++++++----------------
tests/ipmi-bt-test.c           | 11 +++------
tests/libqtest.c               | 22 +++++++++++++++++
tests/libqtest.h               | 25 +++++++++++++++++++
tests/m25p80-test.c            |  9 +++----
tests/pnv-xscom-test.c         | 16 +++---------
tests/prom-env-test.c          | 13 ++++------
tests/tco-test.c               | 10 +++-----
tests/test-filter-mirror.c     | 14 +++++------
tests/test-filter-redirector.c | 56 ++++++++++++++++++++----------------------
tests/virtio-balloon-test.c    |  8 +++---
tests/virtio-blk-test.c        |  5 +---
tests/virtio-console-test.c    | 19 ++++++++------
tests/virtio-serial-test.c     | 10 +++++---
tests/vmgenid-test.c           | 29 ++++++----------------
18 files changed, 156 insertions(+), 156 deletions(-)
[Qemu-devel] [PATCH 0/2] Enable the simple virtio tests on s390x, too
Posted by Thomas Huth 6 years, 6 months ago
First patch introduces the qtest_startf() function that can be used
to start tests with a printf-like string. This patch was originally
part of Eric's bigger qtest refactoring series, and I originally wanted
to wait 'til it's included in the master branch. But since this did
not happen yet and QEMU soft-freeze is approaching soon, I decided
to rather included a slightly simplified version of that patch here
instead.

The second patch then finally enables some of the simple virtio tests
on s390x, too.

Eric Blake (1):
  libqtest: Add qtest_[v]startf()

Thomas Huth (1):
  tests: Enable the very simple virtio tests on s390x, too

 tests/Makefile.include         |  9 ++++---
 tests/boot-order-test.c        | 11 +++------
 tests/boot-serial-test.c       | 12 +++------
 tests/endianness-test.c        | 33 +++++++++----------------
 tests/ipmi-bt-test.c           | 11 +++------
 tests/libqtest.c               | 22 +++++++++++++++++
 tests/libqtest.h               | 25 +++++++++++++++++++
 tests/m25p80-test.c            |  9 +++----
 tests/pnv-xscom-test.c         | 16 +++---------
 tests/prom-env-test.c          | 13 ++++------
 tests/tco-test.c               | 10 +++-----
 tests/test-filter-mirror.c     | 14 +++++------
 tests/test-filter-redirector.c | 56 ++++++++++++++++++++----------------------
 tests/virtio-balloon-test.c    |  8 +++---
 tests/virtio-blk-test.c        |  5 +---
 tests/virtio-console-test.c    | 19 ++++++++------
 tests/virtio-serial-test.c     | 10 +++++---
 tests/vmgenid-test.c           | 29 ++++++----------------
 18 files changed, 156 insertions(+), 156 deletions(-)

-- 
1.8.3.1


Re: [Qemu-devel] [PATCH 0/2] Enable the simple virtio tests on s390x, too
Posted by Eric Blake 6 years, 6 months ago
On 10/18/2017 09:20 AM, Thomas Huth wrote:
> First patch introduces the qtest_startf() function that can be used
> to start tests with a printf-like string. This patch was originally
> part of Eric's bigger qtest refactoring series, and I originally wanted
> to wait 'til it's included in the master branch. But since this did
> not happen yet and QEMU soft-freeze is approaching soon, I decided
> to rather included a slightly simplified version of that patch here
> instead.

Fair enough.  I'm also trying to focus on getting features in before
soft freeze, hence my lack of rebasing the qtest refactoring series in
the meantime.  Arguably (although it is a bit weak) we can claim
testsuite fixes as material that is still relevant after soft freeze as
it does not affect the final installed binaries, as long as they still
go in before hard freeze, but it's hard to say at this point if any of
my qtest refactoring will make 2.11.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH 0/2] Enable the simple virtio tests on s390x, too
Posted by Cornelia Huck 6 years, 6 months ago
On Wed, 18 Oct 2017 10:01:57 -0500
Eric Blake <eblake@redhat.com> wrote:

> On 10/18/2017 09:20 AM, Thomas Huth wrote:
> > First patch introduces the qtest_startf() function that can be used
> > to start tests with a printf-like string. This patch was originally
> > part of Eric's bigger qtest refactoring series, and I originally wanted
> > to wait 'til it's included in the master branch. But since this did
> > not happen yet and QEMU soft-freeze is approaching soon, I decided
> > to rather included a slightly simplified version of that patch here
> > instead.  
> 
> Fair enough.  I'm also trying to focus on getting features in before
> soft freeze, hence my lack of rebasing the qtest refactoring series in
> the meantime.  Arguably (although it is a bit weak) we can claim
> testsuite fixes as material that is still relevant after soft freeze as
> it does not affect the final installed binaries, as long as they still
> go in before hard freeze, but it's hard to say at this point if any of
> my qtest refactoring will make 2.11.
> 

Hi Eric,

does Thomas' port of your patch look sane? If yes, I'll queue both
patches on s390-next for 2.11.

Re: [Qemu-devel] [PATCH 0/2] Enable the simple virtio tests on s390x, too
Posted by Eric Blake 6 years, 6 months ago
On 10/19/2017 04:43 AM, Cornelia Huck wrote:
> On Wed, 18 Oct 2017 10:01:57 -0500
> Eric Blake <eblake@redhat.com> wrote:
> 
>> On 10/18/2017 09:20 AM, Thomas Huth wrote:
>>> First patch introduces the qtest_startf() function that can be used
>>> to start tests with a printf-like string. This patch was originally
>>> part of Eric's bigger qtest refactoring series, and I originally wanted
>>> to wait 'til it's included in the master branch. But since this did
>>> not happen yet and QEMU soft-freeze is approaching soon, I decided
>>> to rather included a slightly simplified version of that patch here
>>> instead.  
>>
>> Fair enough.  I'm also trying to focus on getting features in before
>> soft freeze, hence my lack of rebasing the qtest refactoring series in
>> the meantime.  Arguably (although it is a bit weak) we can claim
>> testsuite fixes as material that is still relevant after soft freeze as
>> it does not affect the final installed binaries, as long as they still
>> go in before hard freeze, but it's hard to say at this point if any of
>> my qtest refactoring will make 2.11.
>>
> 
> Hi Eric,
> 
> does Thomas' port of your patch look sane? If yes, I'll queue both
> patches on s390-next for 2.11.

Yes, it's fine with me.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH 0/2] Enable the simple virtio tests on s390x, too
Posted by Michael S. Tsirkin 6 years, 6 months ago
On Wed, Oct 18, 2017 at 04:20:26PM +0200, Thomas Huth wrote:
> First patch introduces the qtest_startf() function that can be used
> to start tests with a printf-like string. This patch was originally
> part of Eric's bigger qtest refactoring series, and I originally wanted
> to wait 'til it's included in the master branch. But since this did
> not happen yet and QEMU soft-freeze is approaching soon, I decided
> to rather included a slightly simplified version of that patch here
> instead.
> 
> The second patch then finally enables some of the simple virtio tests
> on s390x, too.

From virtio POV:

Acked-by: Michael S. Tsirkin <mst@redhat.com>



> Eric Blake (1):
>   libqtest: Add qtest_[v]startf()
> 
> Thomas Huth (1):
>   tests: Enable the very simple virtio tests on s390x, too
> 
>  tests/Makefile.include         |  9 ++++---
>  tests/boot-order-test.c        | 11 +++------
>  tests/boot-serial-test.c       | 12 +++------
>  tests/endianness-test.c        | 33 +++++++++----------------
>  tests/ipmi-bt-test.c           | 11 +++------
>  tests/libqtest.c               | 22 +++++++++++++++++
>  tests/libqtest.h               | 25 +++++++++++++++++++
>  tests/m25p80-test.c            |  9 +++----
>  tests/pnv-xscom-test.c         | 16 +++---------
>  tests/prom-env-test.c          | 13 ++++------
>  tests/tco-test.c               | 10 +++-----
>  tests/test-filter-mirror.c     | 14 +++++------
>  tests/test-filter-redirector.c | 56 ++++++++++++++++++++----------------------
>  tests/virtio-balloon-test.c    |  8 +++---
>  tests/virtio-blk-test.c        |  5 +---
>  tests/virtio-console-test.c    | 19 ++++++++------
>  tests/virtio-serial-test.c     | 10 +++++---
>  tests/vmgenid-test.c           | 29 ++++++----------------
>  18 files changed, 156 insertions(+), 156 deletions(-)
> 
> -- 
> 1.8.3.1

Re: [Qemu-devel] [PATCH 0/2] Enable the simple virtio tests on s390x, too
Posted by Cornelia Huck 6 years, 6 months ago
On Wed, 18 Oct 2017 16:20:26 +0200
Thomas Huth <thuth@redhat.com> wrote:

> First patch introduces the qtest_startf() function that can be used
> to start tests with a printf-like string. This patch was originally
> part of Eric's bigger qtest refactoring series, and I originally wanted
> to wait 'til it's included in the master branch. But since this did
> not happen yet and QEMU soft-freeze is approaching soon, I decided
> to rather included a slightly simplified version of that patch here
> instead.
> 
> The second patch then finally enables some of the simple virtio tests
> on s390x, too.
> 
> Eric Blake (1):
>   libqtest: Add qtest_[v]startf()
> 
> Thomas Huth (1):
>   tests: Enable the very simple virtio tests on s390x, too
> 
>  tests/Makefile.include         |  9 ++++---
>  tests/boot-order-test.c        | 11 +++------
>  tests/boot-serial-test.c       | 12 +++------
>  tests/endianness-test.c        | 33 +++++++++----------------
>  tests/ipmi-bt-test.c           | 11 +++------
>  tests/libqtest.c               | 22 +++++++++++++++++
>  tests/libqtest.h               | 25 +++++++++++++++++++
>  tests/m25p80-test.c            |  9 +++----
>  tests/pnv-xscom-test.c         | 16 +++---------
>  tests/prom-env-test.c          | 13 ++++------
>  tests/tco-test.c               | 10 +++-----
>  tests/test-filter-mirror.c     | 14 +++++------
>  tests/test-filter-redirector.c | 56 ++++++++++++++++++++----------------------
>  tests/virtio-balloon-test.c    |  8 +++---
>  tests/virtio-blk-test.c        |  5 +---
>  tests/virtio-console-test.c    | 19 ++++++++------
>  tests/virtio-serial-test.c     | 10 +++++---
>  tests/vmgenid-test.c           | 29 ++++++----------------
>  18 files changed, 156 insertions(+), 156 deletions(-)
> 

Thanks, applied.