Changeset
include/hw/or-irq.h | 1 -
1 file changed, 1 deletion(-)
Git apply log
Switched to a new branch '1507814267-21400-1-git-send-email-peter.maydell@linaro.org'
Applying: include/hw/or-irq.h: Drop unused in_irqs field
To https://github.com/patchew-project/qemu
 + 1e740bbbed...3319abdf5c patchew/1507814267-21400-1-git-send-email-peter.maydell@linaro.org -> patchew/1507814267-21400-1-git-send-email-peter.maydell@linaro.org (forced update)
Test passed: s390x

loading

Test passed: docker

loading

Test passed: checkpatch

loading

[Qemu-devel] [PATCH] include/hw/or-irq.h: Drop unused in_irqs field
Posted by Peter Maydell, 8 weeks ago
The struct OrIRQState has an unused member field in_irqs.
This is a legacy of earlier versions of the patch; the
code that used it was dropped from the final version of
the code that went into master, but we forgot to delete
the no-longer-used struct field. Do so now.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 include/hw/or-irq.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/hw/or-irq.h b/include/hw/or-irq.h
index d400a81..fd900fc 100644
--- a/include/hw/or-irq.h
+++ b/include/hw/or-irq.h
@@ -38,7 +38,6 @@ struct OrIRQState {
     DeviceState parent_obj;
 
     qemu_irq out_irq;
-    qemu_irq *in_irqs;
     bool levels[MAX_OR_LINES];
     uint16_t num_lines;
 };
-- 
2.7.4


Re: [Qemu-devel] [PATCH] include/hw/or-irq.h: Drop unused in_irqs field
Posted by Alistair Francis, 8 weeks ago
On Thu, Oct 12, 2017 at 6:17 AM, Peter Maydell <peter.maydell@linaro.org> wrote:
> The struct OrIRQState has an unused member field in_irqs.
> This is a legacy of earlier versions of the patch; the
> code that used it was dropped from the final version of
> the code that went into master, but we forgot to delete
> the no-longer-used struct field. Do so now.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Good catch.

Reviewed-by: Alistair Francis <alistair.francis@xilinx.com>

Thanks,
Alistair

> ---
>  include/hw/or-irq.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/include/hw/or-irq.h b/include/hw/or-irq.h
> index d400a81..fd900fc 100644
> --- a/include/hw/or-irq.h
> +++ b/include/hw/or-irq.h
> @@ -38,7 +38,6 @@ struct OrIRQState {
>      DeviceState parent_obj;
>
>      qemu_irq out_irq;
> -    qemu_irq *in_irqs;
>      bool levels[MAX_OR_LINES];
>      uint16_t num_lines;
>  };
> --
> 2.7.4
>
>