From nobody Fri Mar 29 06:05:40 2024 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1507696618426737.6766407465425; Tue, 10 Oct 2017 21:36:58 -0700 (PDT) Received: from localhost ([::1]:38522 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e28lB-000272-IC for importer@patchew.org; Wed, 11 Oct 2017 00:36:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e28kK-0001lB-Q1 for qemu-devel@nongnu.org; Wed, 11 Oct 2017 00:35:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e28kH-0006Wx-Lu for qemu-devel@nongnu.org; Wed, 11 Oct 2017 00:35:52 -0400 Received: from out1.zte.com.cn ([202.103.147.172]:44046 helo=mxct.zte.com.cn) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e28kH-0006To-AK for qemu-devel@nongnu.org; Wed, 11 Oct 2017 00:35:49 -0400 Received: from mse01.zte.com.cn (unknown [10.30.3.20]) by Forcepoint Email with ESMTPS id 224E2133F0ECD2434963; Wed, 11 Oct 2017 12:35:43 +0800 (CST) Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse01.zte.com.cn with ESMTP id v9B4ZcUW022313; Wed, 11 Oct 2017 12:35:38 +0800 (GMT-8) (envelope-from jiang.biao2@zte.com.cn) Received: from localhost.localdomain ([10.75.10.200]) by szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6) with ESMTP id 2017101112354158-356887 ; Wed, 11 Oct 2017 12:35:41 +0800 From: Jiang Biao To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Wed, 11 Oct 2017 12:33:26 +0800 Message-Id: <1507696406-11168-1-git-send-email-jiang.biao2@zte.com.cn> X-Mailer: git-send-email 1.8.3.1 X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2017-10-11 12:35:41, Serialize by Router on notes_smtp/zte_ltd(Release 9.0.1FP7|August 17, 2016) at 2017-10-11 12:35:30, Serialize complete at 2017-10-11 12:35:30 X-MAIL: mse01.zte.com.cn v9B4ZcUW022313 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 202.103.147.172 Subject: [Qemu-devel] [PATCH] checkpatch: replace ERROR with WARN for extern checking. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jiang.biao2@zte.com.cn, zhong.weidong@zte.com.cn Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_6 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" There are some rare cases which need external declarations in .c files. patchew.org and checkpatch.pl will complain errors on patches for these declarations. Degrade ERROR to WARN to erase the error complaints taking checkpatch.pl in kernel as reference. Signed-off-by: Jiang Biao --- scripts/checkpatch.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 3c0a28e..9123788 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2546,7 +2546,7 @@ sub process { if ($s =3D~ /^\s*;/ && $function_name ne 'uninitialized_var') { - ERROR("externs should be avoided in .c files\n" . $herecurr); + WARN("externs should be avoided in .c files\n" . $herecurr); } =20 if ($paren_space =3D~ /\n/) { @@ -2556,7 +2556,7 @@ sub process { } elsif ($realfile =3D~ /\.c$/ && defined $stat && $stat =3D~ /^.\s*extern\s+/) { - ERROR("externs should be avoided in .c files\n" . $herecurr); + WARN("externs should be avoided in .c files\n" . $herecurr); } =20 # check for pointless casting of g_malloc return --=20 2.9.5