From nobody Wed May 1 11:04:40 2024 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1507622300044535.2855587938008; Tue, 10 Oct 2017 00:58:20 -0700 (PDT) Received: from localhost ([::1]:33336 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1pQF-00083d-OM for importer@patchew.org; Tue, 10 Oct 2017 03:57:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45307) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1pPP-0007l1-Oi for qemu-devel@nongnu.org; Tue, 10 Oct 2017 03:57:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1pPM-0006WY-ON for qemu-devel@nongnu.org; Tue, 10 Oct 2017 03:56:59 -0400 Received: from mxhk.zte.com.cn ([63.217.80.70]:48152) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e1pPM-0006R4-DI for qemu-devel@nongnu.org; Tue, 10 Oct 2017 03:56:56 -0400 Received: from mse01.zte.com.cn (unknown [10.30.3.20]) by Forcepoint Email with ESMTPS id BDD059A077AC56B0B882 for ; Tue, 10 Oct 2017 15:56:45 +0800 (CST) Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse01.zte.com.cn with ESMTP id v9A7uPbR043371 for ; Tue, 10 Oct 2017 15:56:25 +0800 (GMT-8) (envelope-from jiang.biao2@zte.com.cn) Received: from localhost.localdomain ([10.75.10.200]) by szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6) with ESMTP id 2017101015562852-285070 ; Tue, 10 Oct 2017 15:56:28 +0800 From: Jiang Biao To: qemu-devel@nongnu.org Date: Tue, 10 Oct 2017 15:54:19 +0800 Message-Id: <1507622059-4493-1-git-send-email-jiang.biao2@zte.com.cn> X-Mailer: git-send-email 1.8.3.1 X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2017-10-10 15:56:28, Serialize by Router on notes_smtp/zte_ltd(Release 9.0.1FP7|August 17, 2016) at 2017-10-10 15:56:22, Serialize complete at 2017-10-10 15:56:22 X-MAIL: mse01.zte.com.cn v9A7uPbR043371 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 63.217.80.70 Subject: [Qemu-devel] [PATCH] scripts/checkpatch.pl: fix false error of externs checking. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jiang.biao2@zte.com.cn, zhong.weidong@zte.com.cn Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_6 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When adding a function declaration in a .c file without extern keywork decoration, checkpatch.pl will report *externs should be avoided in .c files* false error. This patch fixes the bug. Signed-off-by: Jiang Biao --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 3c0a28e..c12bc4c 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2534,7 +2534,7 @@ sub process { =20 # check for new externs in .c files. if ($realfile =3D~ /\.c$/ && defined $stat && - $stat =3D~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s) + $stat =3D~ /^.\s*(?:extern\s+)$Type\s+($Ident)(\s*)\(/s) { my $function_name =3D $1; my $paren_space =3D $2; --=20 2.7.4