[Qemu-devel] [PATCH] spapr: fix RTAS method name in comment

Greg Kurz posted 1 patch 6 years, 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/150710659849.14714.9839994452901108634.stgit@bahia.lan
Test checkpatch passed
Test docker passed
Test s390x passed
hw/ppc/spapr.c |    3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[Qemu-devel] [PATCH] spapr: fix RTAS method name in comment
Posted by Greg Kurz 6 years, 6 months ago
Signed-off-by: Greg Kurz <groug@kaod.org>
---
 hw/ppc/spapr.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 352ff3d614e8..b284e0b9d43e 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -2334,7 +2334,8 @@ static void ppc_spapr_init(MachineState *machine)
     /* Set up Interrupt Controller before we create the VCPUs */
     xics_system_init(machine, XICS_IRQS_SPAPR, &error_fatal);
 
-    /* Set up containers for ibm,client-set-architecture negotiated options */
+    /* Set up containers for ibm,client-architecture-support negotiated options
+     */
     spapr->ov5 = spapr_ovec_new();
     spapr->ov5_cas = spapr_ovec_new();
 


Re: [Qemu-devel] [PATCH] spapr: fix RTAS method name in comment
Posted by David Gibson 6 years, 6 months ago
On Wed, Oct 04, 2017 at 10:43:18AM +0200, Greg Kurz wrote:
> Signed-off-by: Greg Kurz <groug@kaod.org>

Applied, except I corrected the short description.
ibm,client-architecture-support is an OF word, not actually an RTAS
method.

> ---
>  hw/ppc/spapr.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 352ff3d614e8..b284e0b9d43e 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -2334,7 +2334,8 @@ static void ppc_spapr_init(MachineState *machine)
>      /* Set up Interrupt Controller before we create the VCPUs */
>      xics_system_init(machine, XICS_IRQS_SPAPR, &error_fatal);
>  
> -    /* Set up containers for ibm,client-set-architecture negotiated options */
> +    /* Set up containers for ibm,client-architecture-support negotiated options
> +     */
>      spapr->ov5 = spapr_ovec_new();
>      spapr->ov5_cas = spapr_ovec_new();
>  
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
Re: [Qemu-devel] [PATCH] spapr: fix RTAS method name in comment
Posted by Greg Kurz 6 years, 6 months ago
On Wed, 4 Oct 2017 20:42:26 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:

> On Wed, Oct 04, 2017 at 10:43:18AM +0200, Greg Kurz wrote:
> > Signed-off-by: Greg Kurz <groug@kaod.org>  
> 
> Applied, except I corrected the short description.
> ibm,client-architecture-support is an OF word, not actually an RTAS
> method.
> 

Oops you're right... not quite sure what I was thinking to when I wrote
that :)

> > ---
> >  hw/ppc/spapr.c |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> > index 352ff3d614e8..b284e0b9d43e 100644
> > --- a/hw/ppc/spapr.c
> > +++ b/hw/ppc/spapr.c
> > @@ -2334,7 +2334,8 @@ static void ppc_spapr_init(MachineState *machine)
> >      /* Set up Interrupt Controller before we create the VCPUs */
> >      xics_system_init(machine, XICS_IRQS_SPAPR, &error_fatal);
> >  
> > -    /* Set up containers for ibm,client-set-architecture negotiated options */
> > +    /* Set up containers for ibm,client-architecture-support negotiated options
> > +     */
> >      spapr->ov5 = spapr_ovec_new();
> >      spapr->ov5_cas = spapr_ovec_new();
> >  
> >   
>