[Qemu-devel] [PATCH v7 0/8] Provide support for the software TPM emulator

Amarnath Valluri posted 8 patches 6 years, 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1506083624-20621-1-git-send-email-amarnath.valluri@intel.com
Test checkpatch passed
Test docker passed
Test s390x passed
backends/tpm.c                   | 114 ++++---
configure                        |  15 +-
hmp.c                            |  12 +-
hw/tpm/Makefile.objs             |   1 +
hw/tpm/tpm_emulator.c            | 649 +++++++++++++++++++++++++++++++++++++++
hw/tpm/tpm_ioctl.h               | 246 +++++++++++++++
hw/tpm/tpm_passthrough.c         | 236 ++++----------
hw/tpm/tpm_tis.c                 |  14 +-
hw/tpm/tpm_util.c                |  25 ++
hw/tpm/tpm_util.h                |   4 +
include/sysemu/tpm_backend.h     |  87 +++---
include/sysemu/tpm_backend_int.h |  41 ---
qapi/tpm.json                    |  21 +-
qemu-options.hx                  |  22 +-
tpm.c                            |  36 +--
15 files changed, 1173 insertions(+), 350 deletions(-)
create mode 100644 hw/tpm/tpm_emulator.c
create mode 100644 hw/tpm/tpm_ioctl.h
delete mode 100644 include/sysemu/tpm_backend_int.h
[Qemu-devel] [PATCH v7 0/8] Provide support for the software TPM emulator
Posted by Amarnath Valluri 6 years, 6 months ago
Briefly, Theses set of patches introduces:
- new TPM backend driver to support software TPM emulators(swtpm(1)).
- and few supported fixes/enhancements/cleanup to existing tpm backend code.

The similar idea was initiated earliar(2) by Stefan Berger(CCed) with slightly
different approach, using CUSE. As swtpm has excellent support for unix domain
sockets, hence this implementation uses unix domain sockets to communicate with
swtpm.

When Qemu is configured with 'emulator' tpm backend, it spawns 'swtpm' and
communicates its via Unix domain sockets.

1) https://github.com/stefanberger/swtpm
2) https://lists.nongnu.org/archive/html/qemu-devel/2016-01/msg00089.html

** Changes in V2:
- Made spawnning swtpm optional
- used QIOChannel instead of plain unix sockets
- incorporated other fixes pointed in v1 review

** Changes in v3:
- Addressed review comments made by Stefan Berger and Deniel
P Berrange

** Changes in v4:
- Moved realloc_buffer() to TIS model
- Made TpmInfo related change backwards compatible.

** Changes in v5:
- updated Reviewed-By: tag to git commits
- added migration blocker to TPM emulator backend

** Changes in v6:
- rebased agianst latest master
- Address review comments maded by Stefan Berger

** Changes in v7:
- rebased agianst latest master
- Rewritten emulater backend using chardev backend

Amarnath Valluri (8):
  tpm-backend: Remove unneeded member variable from backend class
  tpm-backend: Move thread handling inside TPMBackend
  tpm-backend: Initialize and free data members in it's own methods
  tpm-backend: Made few interface methods optional
  tmp backend: Add new api to read backend TpmInfo
  tpm-backend: Move realloc_buffer() implementation to tpm-tis model
  tpm-passthrough: move reusable code to utils
  tpm: Added support for TPM emulator

 backends/tpm.c                   | 114 ++++---
 configure                        |  15 +-
 hmp.c                            |  12 +-
 hw/tpm/Makefile.objs             |   1 +
 hw/tpm/tpm_emulator.c            | 649 +++++++++++++++++++++++++++++++++++++++
 hw/tpm/tpm_ioctl.h               | 246 +++++++++++++++
 hw/tpm/tpm_passthrough.c         | 236 ++++----------
 hw/tpm/tpm_tis.c                 |  14 +-
 hw/tpm/tpm_util.c                |  25 ++
 hw/tpm/tpm_util.h                |   4 +
 include/sysemu/tpm_backend.h     |  87 +++---
 include/sysemu/tpm_backend_int.h |  41 ---
 qapi/tpm.json                    |  21 +-
 qemu-options.hx                  |  22 +-
 tpm.c                            |  36 +--
 15 files changed, 1173 insertions(+), 350 deletions(-)
 create mode 100644 hw/tpm/tpm_emulator.c
 create mode 100644 hw/tpm/tpm_ioctl.h
 delete mode 100644 include/sysemu/tpm_backend_int.h

-- 
2.7.4