From nobody Sun Apr 28 20:58:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1506048459943528.9316997323878; Thu, 21 Sep 2017 19:47:39 -0700 (PDT) Received: from localhost ([::1]:56432 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvE09-0002do-Aw for importer@patchew.org; Thu, 21 Sep 2017 22:47:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvDzJ-0002Je-4q for qemu-devel@nongnu.org; Thu, 21 Sep 2017 22:46:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvDzC-0005Dv-O9 for qemu-devel@nongnu.org; Thu, 21 Sep 2017 22:46:45 -0400 Received: from m15-111.126.com ([220.181.15.111]:60931) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvDzB-00058A-Ts for qemu-devel@nongnu.org; Thu, 21 Sep 2017 22:46:38 -0400 Received: from localhost.localdomain.localdomain (unknown [58.213.111.46]) by smtp1 (Coremail) with SMTP id C8mowAAHrmFtecRZE+qWBQ--.3096S2; Fri, 22 Sep 2017 10:46:28 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id; bh=cu9+VKRjOS+vOOYsgd VAHQAANusoGoqhyPGyI+CjiJo=; b=XRbBieP/8K6CHuLcFHihnRFXXHek8kqadk BxADGoxgaSXaehJKoL1MH7n70kBnsnFTy0kJ3t2DZgcz6l1ge7Lc5Q6DmrO18irh DgZoVyCfdDklNbwsOMOtDktixapXS64OqIYyvEyTtQNkN88AjFP250itJWQWKrNk TErx1wj2Y= From: Chen Hanxiao To: mdroth@linux.vnet.ibm.com Date: Fri, 22 Sep 2017 10:46:06 +0800 Message-Id: <1506048366-23368-1-git-send-email-chen_han_xiao@126.com> X-Mailer: git-send-email 2.7.5 X-CM-TRANSID: C8mowAAHrmFtecRZE+qWBQ--.3096S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7tF4fGFWkXryxuw13ZFyfCrg_yoW8JFyDpF 40krsxKw48tr4IyFySga48JF1fA395Cr1DWrn0y3WUZFnxW3Wqyws7Ar9Y9r4fAr48tryf Zr98trZ3u3yUZw7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jzYLkUUUUU= X-Originating-IP: [58.213.111.46] X-CM-SenderInfo: xfkh0spkdqs5xldrqiyswou0bp/1tbi4x5brlUw7ZNjBAACs2 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 220.181.15.111 Subject: [Qemu-devel] [PATCH] qga-win: don't hang if vss hold writes timeout X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tomoki.sekiyama@gmail.com, qemu-devel@nongnu.org, Chen Hanxiao Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @126.com) X-ZohoMail: RDKM_0 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Chen Hanxiao When VM is in a heavy IO, if the command "guest-fsfreeze-freeze" is executed, VSS may timeout when trying to hold writes. Inside guest, Event ID 12298(VSS_ERROR_HOLD_WRITES_TIMEOUT) is logged in the Event Viewer. At that time, if we call AbortBackup, qga may hang forever. This patch will solve this issues. Signed-off-by: Chen Hanxiao --- qga/vss-win32/requester.cpp | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp index 301762d..3d9c971 100644 --- a/qga/vss-win32/requester.cpp +++ b/qga/vss-win32/requester.cpp @@ -419,6 +419,16 @@ void requester_freeze(int *num_vols, ErrorSet *errset) break; } } + + if (wait_status =3D=3D WAIT_TIMEOUT) { + err_set(errset, E_FAIL, + "timeout when try to receive Frozen event from VSS provide= r"); + /* If we are here, VSS had timeout. + * Don't call AbortBackup, just return directly. + */ + goto out1; + } + if (wait_status !=3D WAIT_OBJECT_0) { err_set(errset, E_FAIL, "couldn't receive Frozen event from VSS provider"); @@ -432,6 +442,8 @@ out: if (vss_ctx.pVssbc) { vss_ctx.pVssbc->AbortBackup(); } + +out1: requester_cleanup(); CoUninitialize(); } --=20 2.7.5