[Qemu-devel] [PATCH v3 0/2] x86_iommu: Fix segfault when starting on non-PCI machines

Mohammed Gamal posted 2 patches 6 years, 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1505729649-11943-1-git-send-email-mgamal@redhat.com
Test checkpatch passed
Test docker passed
Test s390x passed
There is a newer version of this series
hw/i386/amd_iommu.c   | 10 +---------
hw/i386/intel_iommu.c | 10 +---------
hw/i386/x86-iommu.c   | 12 ++++++++++++
3 files changed, 14 insertions(+), 18 deletions(-)
[Qemu-devel] [PATCH v3 0/2] x86_iommu: Fix segfault when starting on non-PCI machines
Posted by Mohammed Gamal 6 years, 6 months ago
Starting qemu with
qemu-system-x86_64 -S -M isapc -device {amd|intel}-iommu
leads to a segfault. The code assume PCI bus is present and
tries to access the bus structure without checking.

The patch series moves the error checks from vtd_realize()
and amdvi_realize() to the generic x86_iommu_realize() and
adds a check for PCI bus presence.

v2 --> v3:
* Use PC_MACHINE macro directly

Mohammed Gamal (2):
  x86_iommu: Move machine check to x86_iommu_realize()
  x86_iommu: check if machine has PCI bus

 hw/i386/amd_iommu.c   | 10 +---------
 hw/i386/intel_iommu.c | 10 +---------
 hw/i386/x86-iommu.c   | 12 ++++++++++++
 3 files changed, 14 insertions(+), 18 deletions(-)

-- 
1.8.3.1