Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1503178840-21512-1-git-send-email-minyard@acm.org
Subject: [Qemu-devel] [PATCH 0/3] ipmi: Fix some minor issues
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
3d36816e3d ipmi: Add the platform event message command
f35f019721 ipmi: Don't set the timestamp on add events that don't have it
1e6c3d5b54 ipmi: Fix SEL get/set time commands
=== OUTPUT BEGIN ===
Checking PATCH 1/3: ipmi: Fix SEL get/set time commands...
Checking PATCH 2/3: ipmi: Don't set the timestamp on add events that don't have it...
ERROR: braces {} are necessary for all arms of this statement
#29: FILE: hw/ipmi/ipmi_bmc_sim.c:451:
+ if (event[2] < 0xe0) /* Don't set timestamps for these, per the spec. */
[...]
total: 1 errors, 0 warnings, 22 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/3: ipmi: Add the platform event message command...
ERROR: braces {} are necessary for all arms of this statement
#45: FILE: hw/ipmi/ipmi_bmc_sim.c:1601:
+ if (sel_add_event(ibs, event))
[...]
total: 1 errors, 0 warnings, 41 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org