From nobody Fri May 3 15:32:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1502807492303462.7191507775916; Tue, 15 Aug 2017 07:31:32 -0700 (PDT) Received: from localhost ([::1]:37315 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhcsU-0008Us-PH for importer@patchew.org; Tue, 15 Aug 2017 10:31:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhcrW-00080M-Ib for qemu-devel@nongnu.org; Tue, 15 Aug 2017 10:30:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhcrV-0004aR-Mz for qemu-devel@nongnu.org; Tue, 15 Aug 2017 10:30:30 -0400 Received: from orth.archaic.org.uk ([2001:8b0:1d0::2]:36886) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dhcrV-0004O4-FS for qemu-devel@nongnu.org; Tue, 15 Aug 2017 10:30:29 -0400 Received: from pm215 by orth.archaic.org.uk with local (Exim 4.89) (envelope-from ) id 1dhcrM-0007zg-3b; Tue, 15 Aug 2017 15:30:20 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Date: Tue, 15 Aug 2017 15:30:18 +0100 Message-Id: <1502807418-9994-1-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 2.7.4 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:8b0:1d0::2 Subject: [Qemu-devel] [PATCH for-2.10] mmio-interface: Mark as not user creatable X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: edgar.iglesias@gmail.com, KONRAD Frederic , Thomas Huth , patches@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The mmio-interface device is not something we want to allow users to create on the command line: * it is intended as an implementation detail of the memory subsystem, which gets created and deleted by that subsystem on demand; it makes no sense to create it by hand on the command line * it uses a pointer property 'host_ptr' which can't be set on the command line Mark the device as not user_creatable to avoid confusion. Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Iglesias Reviewed-by: Thomas Huth --- hw/misc/mmio_interface.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/misc/mmio_interface.c b/hw/misc/mmio_interface.c index da154e5..894e980 100644 --- a/hw/misc/mmio_interface.c +++ b/hw/misc/mmio_interface.c @@ -111,6 +111,11 @@ static void mmio_interface_class_init(ObjectClass *oc,= void *data) dc->realize =3D mmio_interface_realize; dc->unrealize =3D mmio_interface_unrealize; dc->props =3D mmio_interface_properties; + /* Reason: pointer property "host_ptr", and this device + * is an implementation detail of the memory subsystem, + * not intended to be created directly by the user. + */ + dc->user_creatable =3D false; } =20 static const TypeInfo mmio_interface_info =3D { --=20 2.7.4