[Qemu-devel] [PULL V2] qemu-doc: Mention host_net_add/-remove in the deprecation chapter

Jason Wang posted 1 patch 6 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1502712555-4587-2-git-send-email-jasowang@redhat.com
Test FreeBSD passed
Test checkpatch passed
Test docker passed
Test s390x passed
There is a newer version of this series
qemu-doc.texi | 8 ++++++++
1 file changed, 8 insertions(+)
[Qemu-devel] [PULL V2] qemu-doc: Mention host_net_add/-remove in the deprecation chapter
Posted by Jason Wang 6 years, 8 months ago
From: Thomas Huth <thuth@redhat.com>

The two HMP commands host_net_add and -remove have recently been
marked as deprecated, too, so we should now mention them in the
chapter of deprecated features.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 qemu-doc.texi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/qemu-doc.texi b/qemu-doc.texi
index aeb7bc5..7b62fdf 100644
--- a/qemu-doc.texi
+++ b/qemu-doc.texi
@@ -3283,6 +3283,14 @@ by the ``convert -l snapshot_param'' argument instead.
 
 @section System emulator human monitor commands
 
+@subsection host_net_add (since 2.10.0)
+
+The ``host_net_add'' command is replaced by the ``netdev_add'' command.
+
+@subsection host_net_remove (since 2.10.0)
+
+The ``host_net_remove'' command is replaced by the ``host_net_remove'' command.
+
 @subsection usb_add (since 2.10.0)
 
 The ``usb_add'' command is replaced by the ``device_add'' command.
-- 
2.7.4


Re: [Qemu-devel] [PULL V2] qemu-doc: Mention host_net_add/-remove in the deprecation chapter
Posted by Cornelia Huck 6 years, 8 months ago
On Mon, 14 Aug 2017 20:09:15 +0800
Jason Wang <jasowang@redhat.com> wrote:

> From: Thomas Huth <thuth@redhat.com>
> 
> The two HMP commands host_net_add and -remove have recently been
> marked as deprecated, too, so we should now mention them in the
> chapter of deprecated features.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
>  qemu-doc.texi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/qemu-doc.texi b/qemu-doc.texi
> index aeb7bc5..7b62fdf 100644
> --- a/qemu-doc.texi
> +++ b/qemu-doc.texi
> @@ -3283,6 +3283,14 @@ by the ``convert -l snapshot_param'' argument instead.
>  
>  @section System emulator human monitor commands
>  
> +@subsection host_net_add (since 2.10.0)
> +
> +The ``host_net_add'' command is replaced by the ``netdev_add'' command.
> +
> +@subsection host_net_remove (since 2.10.0)
> +
> +The ``host_net_remove'' command is replaced by the ``host_net_remove'' command.

Err.. that does not look right...

> +
>  @subsection usb_add (since 2.10.0)
>  
>  The ``usb_add'' command is replaced by the ``device_add'' command.


Re: [Qemu-devel] [PULL V2] qemu-doc: Mention host_net_add/-remove in the deprecation chapter
Posted by Thomas Huth 6 years, 8 months ago
On 14.08.2017 14:14, Cornelia Huck wrote:
> On Mon, 14 Aug 2017 20:09:15 +0800
> Jason Wang <jasowang@redhat.com> wrote:
> 
>> From: Thomas Huth <thuth@redhat.com>
>>
>> The two HMP commands host_net_add and -remove have recently been
>> marked as deprecated, too, so we should now mention them in the
>> chapter of deprecated features.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>> ---
>>  qemu-doc.texi | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/qemu-doc.texi b/qemu-doc.texi
>> index aeb7bc5..7b62fdf 100644
>> --- a/qemu-doc.texi
>> +++ b/qemu-doc.texi
>> @@ -3283,6 +3283,14 @@ by the ``convert -l snapshot_param'' argument instead.
>>  
>>  @section System emulator human monitor commands
>>  
>> +@subsection host_net_add (since 2.10.0)
>> +
>> +The ``host_net_add'' command is replaced by the ``netdev_add'' command.
>> +
>> +@subsection host_net_remove (since 2.10.0)
>> +
>> +The ``host_net_remove'' command is replaced by the ``host_net_remove'' command.
> 
> Err.. that does not look right...

Ah, right, that was the wrong version, I already sent a v2 here:

https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg01954.html

 Thomas

Re: [Qemu-devel] [PULL V2] qemu-doc: Mention host_net_add/-remove in the deprecation chapter
Posted by Jason Wang 6 years, 8 months ago

On 2017年08月14日 20:21, Thomas Huth wrote:
> On 14.08.2017 14:14, Cornelia Huck wrote:
>> On Mon, 14 Aug 2017 20:09:15 +0800
>> Jason Wang <jasowang@redhat.com> wrote:
>>
>>> From: Thomas Huth <thuth@redhat.com>
>>>
>>> The two HMP commands host_net_add and -remove have recently been
>>> marked as deprecated, too, so we should now mention them in the
>>> chapter of deprecated features.
>>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>>> ---
>>>   qemu-doc.texi | 8 ++++++++
>>>   1 file changed, 8 insertions(+)
>>>
>>> diff --git a/qemu-doc.texi b/qemu-doc.texi
>>> index aeb7bc5..7b62fdf 100644
>>> --- a/qemu-doc.texi
>>> +++ b/qemu-doc.texi
>>> @@ -3283,6 +3283,14 @@ by the ``convert -l snapshot_param'' argument instead.
>>>   
>>>   @section System emulator human monitor commands
>>>   
>>> +@subsection host_net_add (since 2.10.0)
>>> +
>>> +The ``host_net_add'' command is replaced by the ``netdev_add'' command.
>>> +
>>> +@subsection host_net_remove (since 2.10.0)
>>> +
>>> +The ``host_net_remove'' command is replaced by the ``host_net_remove'' command.
>> Err.. that does not look right...
> Ah, right, that was the wrong version, I already sent a v2 here:
>
> https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg01954.html
>
>   Thomas

Aha, let me send a V3.

Thanks