From nobody Tue Apr 16 18:53:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1502438221965941.2951070372338; Fri, 11 Aug 2017 00:57:01 -0700 (PDT) Received: from localhost ([::1]:46171 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dg4oW-0008NY-Iw for importer@patchew.org; Fri, 11 Aug 2017 03:57:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38751) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dg4nJ-0007jI-4i for qemu-devel@nongnu.org; Fri, 11 Aug 2017 03:55:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dg4nH-0006wz-Tv for qemu-devel@nongnu.org; Fri, 11 Aug 2017 03:55:45 -0400 Received: from mel.act-europe.fr ([2a02:2ab8:224:1::a0a:d2]:54950 helo=smtp.eu.adacore.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dg4nH-0006vR-KE for qemu-devel@nongnu.org; Fri, 11 Aug 2017 03:55:43 -0400 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 3BB658137C; Fri, 11 Aug 2017 09:55:41 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jpHnVEb2S-lH; Fri, 11 Aug 2017 09:55:41 +0200 (CEST) Received: from localhost.localdomain.localdomain (unknown [IPv6:2a01:e35:87f0:3180:2b18:7e65:c33:7f62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id 922808136B; Fri, 11 Aug 2017 09:55:39 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at eu.adacore.com From: KONRAD Frederic To: peter.maydell@linaro.org Date: Fri, 11 Aug 2017 09:54:12 +0200 Message-Id: <1502438052-5117-1-git-send-email-frederic.konrad@adacore.com> X-Mailer: git-send-email 1.8.3.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 2a02:2ab8:224:1::a0a:d2 Subject: [Qemu-devel] [PATCH V2 for-2.10] xlnx-qspi: add a property for mmio-execution X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quintela@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com, frederic.konrad@adacore.com, edgar.iglesias@gmail.com, alistair.francis@xilinx.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This adds mmio-exec property to workaround the migration bug. When enabled the migration is blocked and will return an error. Signed-off-by: KONRAD Frederic V1 -> V2: * changed mmio-exec to x-mmio-exec Reviewed-by: Edgar E. Iglesias --- hw/ssi/xilinx_spips.c | 36 +++++++++++++++++++++++++++++++++--- 1 file changed, 33 insertions(+), 3 deletions(-) diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c index e833028..ef56d35 100644 --- a/hw/ssi/xilinx_spips.c +++ b/hw/ssi/xilinx_spips.c @@ -31,6 +31,8 @@ #include "hw/ssi/ssi.h" #include "qemu/bitops.h" #include "hw/ssi/xilinx_spips.h" +#include "qapi/error.h" +#include "migration/blocker.h" =20 #ifndef XILINX_SPIPS_ERR_DEBUG #define XILINX_SPIPS_ERR_DEBUG 0 @@ -139,6 +141,8 @@ typedef struct { =20 uint8_t lqspi_buf[LQSPI_CACHE_SIZE]; hwaddr lqspi_cached_addr; + Error *migration_blocker; + bool mmio_execution_enabled; } XilinxQSPIPS; =20 typedef struct XilinxSPIPSClass { @@ -500,12 +504,13 @@ static void xilinx_qspips_invalidate_mmio_ptr(XilinxQ= SPIPS *q) { XilinxSPIPS *s =3D &q->parent_obj; =20 - if (q->lqspi_cached_addr !=3D ~0ULL) { + if ((q->mmio_execution_enabled) && (q->lqspi_cached_addr !=3D ~0ULL)) { /* Invalidate the current mapped mmio */ memory_region_invalidate_mmio_ptr(&s->mmlqspi, q->lqspi_cached_add= r, LQSPI_CACHE_SIZE); - q->lqspi_cached_addr =3D ~0ULL; } + + q->lqspi_cached_addr =3D ~0ULL; } =20 static void xilinx_qspips_write(void *opaque, hwaddr addr, @@ -601,8 +606,13 @@ static void *lqspi_request_mmio_ptr(void *opaque, hwad= dr addr, unsigned *size, unsigned *offset) { XilinxQSPIPS *q =3D opaque; - hwaddr offset_within_the_region =3D addr & ~(LQSPI_CACHE_SIZE - 1); + hwaddr offset_within_the_region; =20 + if (!q->mmio_execution_enabled) { + return NULL; + } + + offset_within_the_region =3D addr & ~(LQSPI_CACHE_SIZE - 1); lqspi_load_cache(opaque, offset_within_the_region); *size =3D LQSPI_CACHE_SIZE; *offset =3D offset_within_the_region; @@ -693,6 +703,15 @@ static void xilinx_qspips_realize(DeviceState *dev, Er= ror **errp) sysbus_init_mmio(sbd, &s->mmlqspi); =20 q->lqspi_cached_addr =3D ~0ULL; + + /* mmio_execution breaks migration better aborting than having strange + * bugs. + */ + if (q->mmio_execution_enabled) { + error_setg(&q->migration_blocker, + "enabling mmio_execution breaks migration"); + migrate_add_blocker(q->migration_blocker, &error_fatal); + } } =20 static int xilinx_spips_post_load(void *opaque, int version_id) @@ -716,6 +735,16 @@ static const VMStateDescription vmstate_xilinx_spips = =3D { } }; =20 +static Property xilinx_qspips_properties[] =3D { + /* We had to turn this off for 2.10 as it is not compatible with migra= tion. + * It can be enabled but will prevent the device to be migrated. + * This will go aways when a fix will be released. + */ + DEFINE_PROP_BOOL("x-mmio-exec", XilinxQSPIPS, mmio_execution_enabled, + false), + DEFINE_PROP_END_OF_LIST(), +}; + static Property xilinx_spips_properties[] =3D { DEFINE_PROP_UINT8("num-busses", XilinxSPIPS, num_busses, 1), DEFINE_PROP_UINT8("num-ss-bits", XilinxSPIPS, num_cs, 4), @@ -729,6 +758,7 @@ static void xilinx_qspips_class_init(ObjectClass *klass= , void * data) XilinxSPIPSClass *xsc =3D XILINX_SPIPS_CLASS(klass); =20 dc->realize =3D xilinx_qspips_realize; + dc->props =3D xilinx_qspips_properties; xsc->reg_ops =3D &qspips_ops; xsc->rx_fifo_size =3D RXFF_A_Q; xsc->tx_fifo_size =3D TXFF_A_Q; --=20 1.8.3.1