[Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io throttling

Pradeep Jagadeesh posted 6 patches 6 years, 7 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1502109458-31251-1-git-send-email-pradeep.jagadeesh@huawei.com
Test FreeBSD passed
Test checkpatch passed
Test docker passed
Test s390x passed
There is a newer version of this series
Makefile                        |   4 ++
blockdev.c                      |  97 ++------------------------------
fsdev/qemu-fsdev-dummy.c        |  11 ++++
fsdev/qemu-fsdev-throttle.c     | 120 ++++++++++++++++++++++++++--------------
fsdev/qemu-fsdev-throttle.h     |   8 ++-
fsdev/qemu-fsdev.c              |  38 +++++++++++++
hmp-commands-info.hx            |  18 ++++++
hmp-commands.hx                 |  19 +++++++
hmp.c                           |  81 +++++++++++++++++++++++++--
hmp.h                           |   4 ++
include/qemu/throttle-options.h |   7 +++
include/qemu/throttle.h         |   4 +-
include/qemu/typedefs.h         |   1 +
monitor.c                       |   5 ++
qapi-schema.json                |   3 +
qapi/block-core.json            |  76 +------------------------
qapi/fsdev.json                 |  84 ++++++++++++++++++++++++++++
qapi/iothrottle.json            |  88 +++++++++++++++++++++++++++++
qmp.c                           |  14 +++++
util/throttle.c                 | 110 ++++++++++++++++++++++++++++++++++++
20 files changed, 574 insertions(+), 218 deletions(-)
create mode 100644 qapi/fsdev.json
create mode 100644 qapi/iothrottle.json
[Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io throttling
Posted by Pradeep Jagadeesh 6 years, 7 months ago
These patches provide the qmp interface, to query the io throttle 
status of the all fsdev devices that are present in a vm.
also, it provides an interface to set the io throttle parameters of a
fsdev to a required value. some of the patches also remove the duplicate
code that was present in block and fsdev files. 

Pradeep Jagadeesh (6):
  throttle: factor out duplicate code
  qmp: Create IOThrottle structure
  throttle: move out function to reuse the code
  hmp: create a throttle initialization function for code reusability
  fsdev: QMP interface for throttling
  fsdev: hmp interface for throttling

 Makefile                        |   4 ++
 blockdev.c                      |  97 ++------------------------------
 fsdev/qemu-fsdev-dummy.c        |  11 ++++
 fsdev/qemu-fsdev-throttle.c     | 120 ++++++++++++++++++++++++++--------------
 fsdev/qemu-fsdev-throttle.h     |   8 ++-
 fsdev/qemu-fsdev.c              |  38 +++++++++++++
 hmp-commands-info.hx            |  18 ++++++
 hmp-commands.hx                 |  19 +++++++
 hmp.c                           |  81 +++++++++++++++++++++++++--
 hmp.h                           |   4 ++
 include/qemu/throttle-options.h |   7 +++
 include/qemu/throttle.h         |   4 +-
 include/qemu/typedefs.h         |   1 +
 monitor.c                       |   5 ++
 qapi-schema.json                |   3 +
 qapi/block-core.json            |  76 +------------------------
 qapi/fsdev.json                 |  84 ++++++++++++++++++++++++++++
 qapi/iothrottle.json            |  88 +++++++++++++++++++++++++++++
 qmp.c                           |  14 +++++
 util/throttle.c                 | 110 ++++++++++++++++++++++++++++++++++++
 20 files changed, 574 insertions(+), 218 deletions(-)
 create mode 100644 qapi/fsdev.json
 create mode 100644 qapi/iothrottle.json

v0 -> v1:
 Addressed comments from Eric Blake, Greg Kurz and Daniel P.Berrange
 Mainly renaming the functions and removing the redundant code.

v1 -> v2:
 Addressed comments from Eric Blake and Greg Kurz.
 As per the suggestion I split the patches into smaller patches.
 Removed some more duplicate code.

v2 -> v3:
 Addresssed comments from Alberto Garcia.
 Changed the comment from block to iothrottle in the iothrottle.json 
 Added the dummy functions in qemu-fsdev-dummy.c to address the compilation
 issues that were observed.

v3 -> v4:
 Addressed comments from Eric Blake and Greg Kurz
 Re-ordered the patches
 Added the dummy functions in qmp.c to address the cross compilation issues

v4 -> v5:
  Addressed comments from Eric Blake and Greg Kurz
  Split the fsdev qmp patch into hmp and qmp related patches
  Moved the common functionalities to throttle.c instead of creating
  a new file

v5 -> v6:
  Addressed comments from Greg Kurz and Markus Armbruster
  Split the commits to specific to hmp and throttle as suggested by Greg
  Moved ThrottleConfig typedef to qemu/typedefs.h
  Addressed compilation issue on FreeBSD by adding flags in qmp.c

v6 -> v7:
  Addressed comments from Albert Garcia and Dr. David Alan Gilbert
  Fixed the hmp-commands-info.hx and hmp-commands.hx as per Dr. David's
  comments.
  Fixed the bug with the hmp fsdev_set_io_throttle and info fsdev_iothrottle  

v7 -> v8:
  Addressed comments from Markus Armbruster and Eric Blake
  Removed unwanted headers from qmp-fsdev-throttle.h
-- 
1.8.3.1