MAINTAINERS: Improve the NetBSD regex pattern

[Qemu-devel] [PATCH] MAINTAINERS: Improve the NetBSD regex pattern

Thomas Huth posted 1 patch 6 years, 9 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1501150174-19431-1-git-send-email-thuth@redhat.com

Test FreeBSD passed

Test checkpatch passed

Test s390x passed

MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] MAINTAINERS: Improve the NetBSD regex pattern

Posted by Thomas Huth 6 years, 9 months ago

Currently get_maintainers.pl claims that the configure script is
maintained by Kamil:

 $ scripts/get_maintainer.pl -f configure
 Kamil Rytarowski <kamil@netbsd.org> (maintainer:NETBSD)
 qemu-devel@nongnu.org (open list:All patches CC here)

This happens because the regex pattern for the NETBSD entry triggers
on everything that contains the keyword "NetBSD". Ease the situation
a little bit by restricting this to "Subject:" lines only, like
we do it in the "trivial patches" section already.

Reported-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index ce2341a..ccee28b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -353,7 +353,7 @@ NETBSD
 L: qemu-devel@nongnu.org
 M: Kamil Rytarowski <kamil@netbsd.org>
 S: Maintained
-K: (?i)NetBSD
+K: ^Subject:.*(?i)NetBSD
 
 W32, W64
 L: qemu-devel@nongnu.org
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH] MAINTAINERS: Improve the NetBSD regex pattern

Posted by Eric Blake 6 years, 9 months ago

On 07/27/2017 05:09 AM, Thomas Huth wrote:
> Currently get_maintainers.pl claims that the configure script is
> maintained by Kamil:
> 
>  $ scripts/get_maintainer.pl -f configure
>  Kamil Rytarowski <kamil@netbsd.org> (maintainer:NETBSD)
>  qemu-devel@nongnu.org (open list:All patches CC here)
> 
> This happens because the regex pattern for the NETBSD entry triggers
> on everything that contains the keyword "NetBSD". Ease the situation
> a little bit by restricting this to "Subject:" lines only, like
> we do it in the "trivial patches" section already.
> 
> Reported-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  MAINTAINERS | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org