testchardev2 is not a valid chardev id here. Use testchardev1
instead which has been created with chardev-add right before
the 'chardev-send-break' line.
And while we're at it, add the test-hmp.c file to the MAINTAINERS
file, too.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
MAINTAINERS | 1 +
tests/test-hmp.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 5ea273f..ce2341a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1346,6 +1346,7 @@ F: monitor.c
F: hmp.[ch]
F: hmp-commands*.hx
F: include/monitor/hmp-target.h
+F: tests/test-hmp.c
Network device backends
M: Jason Wang <jasowang@redhat.com>
diff --git a/tests/test-hmp.c b/tests/test-hmp.c
index d77b3c8..729c033 100644
--- a/tests/test-hmp.c
+++ b/tests/test-hmp.c
@@ -22,7 +22,7 @@ static int verbose;
static const char *hmp_cmds[] = {
"boot_set ndc",
"chardev-add null,id=testchardev1",
- "chardev-send-break testchardev2",
+ "chardev-send-break testchardev1",
"chardev-change testchardev1 ringbuf",
"chardev-remove testchardev1",
"commit all",
--
1.8.3.1
* Thomas Huth (thuth@redhat.com) wrote: > testchardev2 is not a valid chardev id here. Use testchardev1 > instead which has been created with chardev-add right before > the 'chardev-send-break' line. > And while we're at it, add the test-hmp.c file to the MAINTAINERS > file, too. > > Signed-off-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > --- > MAINTAINERS | 1 + > tests/test-hmp.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 5ea273f..ce2341a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1346,6 +1346,7 @@ F: monitor.c > F: hmp.[ch] > F: hmp-commands*.hx > F: include/monitor/hmp-target.h > +F: tests/test-hmp.c > > Network device backends > M: Jason Wang <jasowang@redhat.com> > diff --git a/tests/test-hmp.c b/tests/test-hmp.c > index d77b3c8..729c033 100644 > --- a/tests/test-hmp.c > +++ b/tests/test-hmp.c > @@ -22,7 +22,7 @@ static int verbose; > static const char *hmp_cmds[] = { > "boot_set ndc", > "chardev-add null,id=testchardev1", > - "chardev-send-break testchardev2", > + "chardev-send-break testchardev1", > "chardev-change testchardev1 ringbuf", > "chardev-remove testchardev1", > "commit all", > -- > 1.8.3.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
On 27 July 2017 at 10:55, Dr. David Alan Gilbert <dgilbert@redhat.com> wrote: > * Thomas Huth (thuth@redhat.com) wrote: >> testchardev2 is not a valid chardev id here. Use testchardev1 >> instead which has been created with chardev-add right before >> the 'chardev-send-break' line. >> And while we're at it, add the test-hmp.c file to the MAINTAINERS >> file, too. >> >> Signed-off-by: Thomas Huth <thuth@redhat.com> > > > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Thanks, applied to master. -- PMM
© 2016 - 2024 Red Hat, Inc.